[eradicate] remove dated debug info

Reviewed By: mbouaziz

Differential Revision: D9847271

fbshipit-source-id: 918eedbcb
master
Jeremy Dubreil 6 years ago committed by Facebook Github Bot
parent c52125cfcf
commit dc89f3b5a4

@ -1264,10 +1264,6 @@ INTERNAL OPTIONS
Activates: Condition redundant warnings (Conversely:
--no-eradicate-condition-redundant)
--eradicate-debug
Activates: Print debug info when errors are found (Conversely:
--no-eradicate-debug)
--eradicate-field-not-mutable
Activates: Field not mutable warnings (Conversely:
--no-eradicate-field-not-mutable)

@ -1300,10 +1300,6 @@ and eradicate_return_over_annotated =
CLOpt.mk_bool ~long:"eradicate-return-over-annotated" "Return over-annotated warning"
and eradicate_debug =
CLOpt.mk_bool ~long:"eradicate-debug" "Print debug info when errors are found"
and eradicate_verbose =
CLOpt.mk_bool ~long:"eradicate-verbose" "Print initial and final typestates"
@ -2706,8 +2702,6 @@ and eradicate_optional_present = !eradicate_optional_present
and eradicate_return_over_annotated = !eradicate_return_over_annotated
and eradicate_debug = !eradicate_debug
and eradicate_verbose = !eradicate_verbose
and external_java_packages = !external_java_packages

@ -340,8 +340,6 @@ val eradicate : bool
val eradicate_condition_redundant : bool
val eradicate_debug : bool
val eradicate_field_not_mutable : bool
val eradicate_field_over_annotated : bool

@ -36,21 +36,6 @@ let explain_expr tenv node e =
| None ->
None
(** Classify a procedure. *)
let classify_procedure proc_attributes =
let pn = proc_attributes.ProcAttributes.proc_name in
let unique_id = Typ.Procname.to_unique_id pn in
let classification =
if Models.is_modelled_nullable pn then "M" (* modelled *)
else if Summary.proc_is_library proc_attributes then "L" (* library *)
else if not proc_attributes.ProcAttributes.is_defined then "S" (* skip *)
else if String.is_prefix ~prefix:"com.facebook" unique_id then "F" (* FB *)
else "?"
in
classification
let is_virtual = function (p, _, _) :: _ when Mangled.is_this p -> true | _ -> false
(** Check an access (read or write) to a field. *)

@ -6,7 +6,6 @@
*)
open! IStd
module L = Logging
module F = Format
module DExp = DecompiledExp
@ -789,10 +788,6 @@ let typecheck_instr tenv calls_this checks (node : Procdesc.Node.t) idenv curr_p
let resolved_ret = apply_annotation_transformer resolved_ret_ resolved_params in
let typestate_after_call =
if not is_anonymous_inner_class_constructor then (
( if Config.eradicate_debug then
let unique_id = Typ.Procname.to_unique_id callee_pname in
let classification = EradicateChecks.classify_procedure callee_attributes in
L.result " %s unique id: %s@." classification unique_id ) ;
if cflags.CallFlags.cf_virtual && checks.eradicate then
EradicateChecks.check_call_receiver tenv find_canonical_duplicate curr_pdesc node
typestate1 call_params callee_pname instr_ref loc

Loading…
Cancel
Save