[racerd] improve interface not thread safe report text

Summary:
The text is ambiguous because it sounds as if it recommends annotating the current class as `ThreadSafe`, not the interface invoked.

Also, remove the not useful part "or using an interface known to be thread-safe" because developers don't know in general what interfaces Infer thinks are thread-safe.

Reviewed By: skcho

Differential Revision: D20675729

fbshipit-source-id: 9da438621
master
Nikos Gorogiannis 5 years ago committed by Facebook GitHub Bot
parent 76f80f114c
commit dfb19d7c3e

@ -680,7 +680,7 @@ let report_unannotated_interface_violation ~issue_log reported_pname reported_ac
let make_description _ _ _ _ = let make_description _ _ _ _ =
F.asprintf F.asprintf
"Unprotected call to method %a of un-annotated interface %a. Consider annotating the \ "Unprotected call to method %a of un-annotated interface %a. Consider annotating the \
class with %a, adding a lock, or using an interface that is known to be thread-safe." interface with %a or adding a lock."
describe_pname reported_pname MF.pp_monospaced class_name MF.pp_monospaced "@ThreadSafe" describe_pname reported_pname MF.pp_monospaced class_name MF.pp_monospaced "@ThreadSafe"
in in
report_thread_safety_violation ~issue_log ~make_description ~report_kind:UnannotatedInterface report_thread_safety_violation ~issue_log ~make_description ~report_kind:UnannotatedInterface

Loading…
Cancel
Save