[clang] Run direct tests with --no-failures-allowed flag

Reviewed By: dulmarod

Differential Revision: D4674385

fbshipit-source-id: 0816239

infer/src/clang/cFrontend_decl.ml

@@ -21,6 +21,10 @@ struct
   (* Translates the method/function's body into nodes of the cfg. *)
   let add_method trans_unit_ctx tenv cg cfg class_decl_opt procname body has_return_param
       is_objc_method outer_context_opt extra_instrs =
+    let handle_translation_failure () =
+      Cfg.remove_proc_desc cfg procname;
+      CMethod_trans.create_external_procdesc cfg procname is_objc_method None
+    in
     Logging.out_debug
       "@\n@\n>>---------- ADDING METHOD: '%s' ---------<<@\n@." (Procname.to_string procname);
     try
@@ -48,11 +52,12 @@ struct
         (* this shouldn't happen, because self or [a class] should always be arguments of
            functions. This is to make sure I'm not wrong. *)
         assert false
+    | CTrans_utils.TemplatedCodeException _ ->
+        Logging.out "Fatal error: frontend doesn't support translation of templated code\n";
+        handle_translation_failure ()
     | Assert_failure (file, line, column) when Config.failures_allowed ->
         Logging.out "Fatal error: exception Assert_failure(%s, %d, %d)\n%!" file line column;
-        Cfg.remove_proc_desc cfg procname;
+        handle_translation_failure ()
-        CMethod_trans.create_external_procdesc cfg procname is_objc_method None;
-        ()
 
   let function_decl trans_unit_ctx tenv cfg cg func_decl block_data_opt =
     let captured_vars, outer_context_opt =

infer/src/clang/cTrans.ml

@@ -2665,6 +2665,13 @@ struct
     | VAArgExpr (_, _, expr_info) ->
         trans_into_undefined_expr trans_state expr_info
 
+
+    (* Infer somehow ended up in templated non instantiated code - right now
+       it's not supported and failure in those cases is expected. *)
+    | SubstNonTypeTemplateParmExpr _
+    | SubstNonTypeTemplateParmPackExpr _
+    | CXXDependentScopeMemberExpr _ -> raise (CTrans_utils.TemplatedCodeException instr)
+
     | s -> (Logging.out
               "\n!!!!WARNING: found statement %s. \nACTION REQUIRED: \
                Translation need to be defined. Statement ignored.... \n"

infer/src/clang/cTrans_utils.ml

@@ -14,6 +14,8 @@ module Hashtbl = Caml.Hashtbl
 
 module L = Logging
 
+exception TemplatedCodeException of Clang_ast_t.stmt
+
 (* Extract the element of a singleton list. If the list is not a singleton *)
 (* It stops the computation giving a warning. We use this because we       *)
 (* assume in many places that a list is just a singleton. We use the       *)

infer/src/clang/cTrans_utils.mli

@@ -40,6 +40,8 @@ type trans_result = {
   is_cpp_call_virtual : bool;
 }
 
+exception TemplatedCodeException of Clang_ast_t.stmt
+
 val empty_res_trans: trans_result
 
 val undefined_expression: unit -> Exp.t

infer/tests/codetoanalyze/c/bufferoverrun/Makefile

@@ -12,7 +12,7 @@ TESTS_DIR = ../../..
 
 ANALYZER = bufferoverrun
 CLANG_OPTIONS = -c
-INFER_OPTIONS = -nf --project-root $(TESTS_DIR)
+INFER_OPTIONS = -nf --project-root $(TESTS_DIR) --no-failures-allowed
 INFERPRINT_OPTIONS = --issues-tests
 
 SOURCES = \

infer/tests/codetoanalyze/c/errors/Makefile

@@ -9,7 +9,7 @@ TESTS_DIR = ../../..
 
 ANALYZER = infer
 CLANG_OPTIONS = -c
-INFER_OPTIONS = --report-custom-error --developer-mode --no-filtering --debug-exceptions --project-root $(TESTS_DIR)
+INFER_OPTIONS = --report-custom-error --developer-mode --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --no-failures-allowed
 # we need to disable traces in C tests because assertions/assertion_failure.c has different traces
 # on Linux and OSX because of different implementations of assert() on each platform
 INFERPRINT_OPTIONS = --issues-fields "file,procedure,line_offset,bug_type" --issues-tests

infer/tests/codetoanalyze/c/frontend/Makefile

@@ -8,6 +8,7 @@
 TESTS_DIR=../../..
 
 CLANG_OPTIONS = -c
+INFER_OPTIONS = --no-failures-allowed
 
 SOURCES = \
   $(wildcard */*.c) \

infer/tests/codetoanalyze/cpp/checkers/Makefile

@@ -10,7 +10,7 @@ TESTS_DIR = ../../..
 ANALYZER = checkers
 # see explanations in cpp/errors/Makefile for the custom isystem
 CLANG_OPTIONS = -x c++ -std=c++11 -nostdinc++ -isystem$(MODELS_DIR)/cpp/include -isystem$(CLANG_INCLUDES)/c++/v1/ -c
-INFER_OPTIONS = --ml-buckets cpp --no-filtering --debug-exceptions --project-root $(TESTS_DIR)
+INFER_OPTIONS = --ml-buckets cpp --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --no-failures-allowed
 INFERPRINT_OPTIONS = --issues-tests
 
 SOURCES = \

infer/tests/codetoanalyze/cpp/errors/Makefile

@@ -12,7 +12,7 @@ ANALYZER = infer
 # Use the system headers of our own clang. This way, we always use the same system headers
 # regardless of the libraries installed on the machine.
 CLANG_OPTIONS = -x c++ -std=c++11 -nostdinc++ -isystem$(ROOT_DIR) -isystem$(CLANG_INCLUDES)/c++/v1/ -c
-INFER_OPTIONS = --ml-buckets cpp --no-filtering --debug-exceptions --project-root $(TESTS_DIR)
+INFER_OPTIONS = --ml-buckets cpp --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --no-failures-allowed
 INFERPRINT_OPTIONS = --issues-tests
 
 SOURCES = \

infer/tests/codetoanalyze/cpp/frontend/Makefile

@@ -11,7 +11,7 @@ TESTS_DIR=../../..
 CLANG_OPTIONS = \
   -nostdinc++ -isystem$(ROOT_DIR) -isystem$(CLANG_INCLUDES)/c++/v1/ \
   -x c++ -std=c++11 -c
-INFER_OPTIONS = --headers
+INFER_OPTIONS = --headers --no-failures-allowed
 
 
 SOURCES = \

infer/tests/codetoanalyze/cpp/quandary/Makefile

@@ -10,7 +10,7 @@ TESTS_DIR = ../../..
 ANALYZER = quandary
 # see explanations in cpp/errors/Makefile for the custom isystem
 CLANG_OPTIONS = -x c++ -std=c++11 -nostdinc++ -isystem$(ROOT_DIR) -isystem$(CLANG_INCLUDES)/c++/v1/ -c
-INFER_OPTIONS = --ml-buckets cpp --no-filtering --debug-exceptions --project-root $(TESTS_DIR)
+INFER_OPTIONS = --ml-buckets cpp --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --no-failures-allowed
 INFERPRINT_OPTIONS = --issues-tests
 
 SOURCES = \

infer/tests/codetoanalyze/objc/errors/Makefile

@@ -18,7 +18,7 @@ CLANG_OPTIONS = -x objective-c \
 
 CLEAN_EXTRA = infer-out-arc infer-out-all infer-out-all infer-out-arc \
               issues.exp.test.all issues.exp.test.arc issues.exp.test.default
-INFER_OPTIONS = --check-duplicate-symbols --no-filtering --debug-exceptions --project-root $(TESTS_DIR)
+INFER_OPTIONS = --check-duplicate-symbols --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --no-failures-allowed
 INFERPRINT_OPTIONS = --issues-tests
 
 SOURCES_DEFAULT = \

infer/tests/codetoanalyze/objc/ioslints/Makefile

@@ -17,7 +17,7 @@ CLANG_OPTIONS = -x objective-c \
 
 ANALYZER = linters
 INFER_OPTIONS = --no-filtering --debug-exceptions --project-root $(TESTS_DIR) \
---iphoneos-target-sdk-version 8.0
+--iphoneos-target-sdk-version 8.0 --no-failures-allowed
 INFERPRINT_OPTIONS = --issues-tests
 
 SOURCES = \

infer/tests/codetoanalyze/objc/linters/Makefile

@@ -9,7 +9,7 @@ TESTS_DIR = ../../..
 
 ANALYZER = linters
 CLANG_OPTIONS = -x objective-c -fobjc-arc -c
-INFER_OPTIONS = --no-filtering --debug-exceptions --project-root $(TESTS_DIR)
+INFER_OPTIONS = --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --no-failures-allowed
 INFERPRINT_OPTIONS = --issues-tests
 
 SOURCES = \

infer/tests/codetoanalyze/objc/quandary/Makefile

@@ -16,7 +16,7 @@ CLANG_OPTIONS = -x objective-c \
   -mios-simulator-version-min=8.2 --target=x86_64-apple-darwin14 -c \
 
 ANALYZER = quandary
-INFER_OPTIONS = --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --iphoneos-target-sdk-version 8.0
+INFER_OPTIONS = --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --iphoneos-target-sdk-version 8.0 --no-failures-allowed
 INFERPRINT_OPTIONS = --issues-tests
 
 SOURCES = \

infer/tests/codetoanalyze/objcpp/frontend/Makefile

@@ -15,6 +15,8 @@ CLANG_OPTIONS = -x objective-c++ -std=c++11 \
   -isysroot $(XCODEROOT)$(IPHONESIMULATOR_ISYSROOT_SUFFIX) \
   -mios-simulator-version-min=8.2 --target=x86_64-apple-darwin14 -c \
 
+INFER_OPTIONS = --no-failures-allowed
+
 SOURCES = \
   $(wildcard */*.mm) \
 

infer/tests/codetoanalyze/objcpp/linters/Makefile

@@ -9,8 +9,9 @@ TESTS_DIR = ../../..
 
 ANALYZER = linters
 CLANG_OPTIONS = -x objective-c++ -std=c++11 -fobjc-arc -c
-INFER_OPTIONS = --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --enable-checks GLOBAL_VARIABLE_INITIALIZED_WITH_FUNCTION_OR_METHOD_CALL
+INFER_OPTIONS = --no-filtering --debug-exceptions --project-root $(TESTS_DIR) --no-failures-allowed \
-INFERPRINT_OPTIONS = --issues-tests
+--enable-checks GLOBAL_VARIABLE_INITIALIZED_WITH_FUNCTION_OR_METHOD_CALL
+INFERPRINT_OPTIONS = --issues-tests 
 
 SOURCES = \
   $(wildcard */*.mm) \