[sledge][NFC] Refactor to avoid an unused open warning

Summary:
OCaml 4.08 has a new warning (66) on unused `open!` statements. This
has a suboptimal interaction with `ppx_let`'s `let%map_open` which
leads to triggering the warning if any of a group of such let bindings
does not need the open.

In this case, the refactor is easy.

But, warning 66 is very dubious, so also just switch it off.

Reviewed By: jvillard

Differential Revision: D18708466

fbshipit-source-id: 77618ab6e
master
Josh Berdine 5 years ago committed by Facebook Github Bot
parent 6c5d9d4acb
commit e201e517c9

@ -7,7 +7,7 @@
*) *)
let common_flags = let common_flags =
{|(-w +a-4-9-18-40-42-44-48@50 {|(-w +a-4-9-18-40-42-44-48@50-66
-strict-formats -strict-sequence -strict-formats -strict-sequence
-short-paths -bin-annot -keep-docs -short-paths -bin-annot -keep-docs
-unboxed-types)|} -unboxed-types)|}

@ -176,9 +176,8 @@ let abs_path_arg =
Command.Param.(Arg_type.map string ~f:(make_absolute cwd)) Command.Param.(Arg_type.map string ~f:(make_absolute cwd))
let main ~(command : unit Command.basic_command) ~analyze = let main ~(command : unit Command.basic_command) ~analyze =
let target_flag = Command.Param.(anon ("<target>" %: string)) in
let bitcode_inputs = let bitcode_inputs =
let%map_open target = target_flag let%map_open target = anon ("<target>" %: string)
and modules = and modules =
flag "modules" (optional string) flag "modules" (optional string)
~doc: ~doc:

Loading…
Cancel
Save