Add test incremental_analysis_remove_file to the toplevel makefile

Summary:
Add test `incremental_analysis_remove_file` to the toplevel makefile so that it is called by `make test` etc

Also swapped the src_before and src_after files so the test checks file removal instead of addition.

Reviewed By: jvillard

Differential Revision: D16562340

fbshipit-source-id: 79bab5f66

.gitignore

@@ -44,7 +44,7 @@ duplicates.txt
 /infer/tests/build_systems/differential_*/**/*.class
 /infer/tests/build_systems/differential_*/**/Diff*.java
 /infer/tests/build_systems/genrule/report.json
-/infer/tests/build_systems/incremental_analysis/src
+/infer/tests/build_systems/incremental_analysis_remove_file/src
 /infer/tests/build_systems/java_test_determinator/*.test
 /infer/tests/codetoanalyze/java/classloads/*.loads
 /infer/tests/codetoanalyze/java/classloads/loads.exp

Makefile

@@ -46,7 +46,7 @@ BUILD_SYSTEMS_TESTS += \
   tracebugs \
   utf8_in_procname \
   export_changed_functions \
-  buck_export_changed_functions \
+  incremental_analysis_remove_file \
 
 DIRECT_TESTS += \
   c_biabduction \
@@ -80,6 +80,7 @@ BUILD_SYSTEMS_TESTS += \
   buck_flavors_diff \
   buck_flavors_run \
   buck_flavors_deterministic \
+  buck_export_changed_functions \
 
 endif
 ifneq ($(CMAKE),no)

infer/tests/build_systems/incremental_analysis/reverse_analysis_callgraph.dot

@@ -1,17 +0,0 @@
-
-digraph callgraph {
-  N1 [ label = "a", flag = true ];
-  N1 -> N4 ;
-
-  N0 [ label = "b", flag = true ];
-  N0 -> N1 ;
-
-  N4 [ label = "main", flag = true ];
-
-  N2 [ label = "c", flag = true ];
-  N2 -> N0 ;
-
-  N3 [ label = "d", flag = false ];
-  N3 -> N2 ;
-
-}

infer/tests/build_systems/incremental_analysis_remove_file/Makefile

@@ -37,7 +37,9 @@ $(PREVIOUS_REPORT): $(INFER_CLANG_DEPS) $(SOURCES) $(CURRENT_REPORT)
 	$(QUIET)$(REMOVE_DIR) src
 	$(QUIET)$(MKDIR_P) src
 	$(QUIET)$(COPY) src_before/* src/
+	$(QUIET)$(REMOVE_DIR) $(PREVIOUS_DIR)
 	$(QUIET)$(COPY) -r $(CURRENT_DIR) $(PREVIOUS_DIR)
-	$(QUIET)$(INFER_BIN) -o $(PREVIOUS_DIR) $(INFER_OPTIONS) -- clang -c src/*.c
+	$(QUIET)$(REMOVE) $@
+	$(QUIET)$(INFER_BIN) -o $(PREVIOUS_DIR) $(INFER_OPTIONS) -- clang -c src/*.c 
 	$(QUIET)$(COPY) $(PREVIOUS_DIR)/reverse_analysis_callgraph.dot \
-	                                reverse_analysis_callgraph.dot.test
+	        reverse_analysis_callgraph.dot.test

infer/tests/build_systems/incremental_analysis_remove_file/reverse_analysis_callgraph.dot

@@ -0,0 +1,13 @@
+
+digraph callgraph {
+  N1 [ label = "b", flag = true ];
+
+  N0 [ label = "c", flag = true ];
+  N0 -> N1 ;
+
+  N2 [ label = "a", flag = true ];
+  N2 -> N3 ;
+
+  N3 [ label = "main", flag = true ];
+
+}