Fix cases of resource leaks not detected when the resource indirectly implements Closeable

Summary:public
Before this diff, the Java frontend was not adding the definition of the inherited interfaces to the type environment, thus failing to answer questions like "does type X implements Closeable". Infer was therefore missing to detect resource leaks when the resource was indirectly implementing Closeable via an intermediate interface.

Reviewed By: sblackshear

Differential Revision: D3067555

fb-gh-sync-id: 86d0760
shipit-source-id: 86d0760

infer/src/java/jTransType.ml

@@ -312,6 +312,7 @@ and create_sil_type program tenv cn =
   | None -> dummy_type cn
   | Some node ->
       let create_super_list interface_names =
+        IList.iter (fun cn -> ignore (get_class_type_no_pointer program tenv cn)) interface_names;
         IList.map typename_of_classname interface_names in
       let superclasses, instance_fields, static_fields, struct_annotations =
         match node with

infer/tests/build_systems/expected_outputs/ant_report.json

@@ -399,6 +399,11 @@
     "file": "codetoanalyze/java/infer/ResourceLeaks.java",
     "procedure": "void ResourceLeaks.jarOutputStreamLeak()"
   },
+  {
+    "bug_type": "RESOURCE_LEAK",
+    "file": "codetoanalyze/java/infer/CloseableAsResourceExample.java",
+    "procedure": "void CloseableAsResourceExample.leakFoundWhenIndirectlyImplementingCloseable()"
+  },
   {
     "bug_type": "RESOURCE_LEAK",
     "file": "codetoanalyze/java/infer/CursorLeaks.java",

infer/tests/build_systems/expected_outputs/buck_report.json

@@ -399,6 +399,11 @@
     "file": "infer/tests/codetoanalyze/java/infer/ResourceLeaks.java",
     "procedure": "void ResourceLeaks.jarOutputStreamLeak()"
   },
+  {
+    "bug_type": "RESOURCE_LEAK",
+    "file": "infer/tests/codetoanalyze/java/infer/CloseableAsResourceExample.java",
+    "procedure": "void CloseableAsResourceExample.leakFoundWhenIndirectlyImplementingCloseable()"
+  },
   {
     "bug_type": "RESOURCE_LEAK",
     "file": "infer/tests/codetoanalyze/java/infer/CursorLeaks.java",

infer/tests/codetoanalyze/java/infer/CloseableAsResourceExample.java

@@ -149,4 +149,14 @@ public class CloseableAsResourceExample {
     return null;
   }
 
+  interface MyCloseable extends Closeable {}
+
+  class MyResource implements MyCloseable {
+    public void close() {}
+  }
+
+  void leakFoundWhenIndirectlyImplementingCloseable() {
+    MyResource res = new MyResource();
+  }
+
 }

infer/tests/endtoend/java/infer/CloseableAsResourceTest.java

@@ -43,6 +43,7 @@ public class CloseableAsResourceTest {
         "notClosingWrapper",
         "failToCloseWithCloseQuietly",
         "sourceOfNullWithResourceLeak",
+        "leakFoundWhenIndirectlyImplementingCloseable",
     };
     assertThat(
         "Results should not contain resource leak errors",