[sledge] Factor out Frontend translation of "instruction" intrinsics

Summary:
Move the translation of Calls to intrinsics that map to instructions
into a separat function.

No functional change.

Reviewed By: jvillard

Differential Revision: D25146169

fbshipit-source-id: 79c640344

sledge/cli/frontend.ml

@@ -936,6 +936,61 @@ let ignored_callees = StringS.create 0
 let xlate_size_of x llv =
   Exp.integer Typ.siz (Z.of_int (size_of x (Llvm.type_of llv)))
 
+let xlate_intrinsic_inst emit_inst x llname instr loc =
+  let emit_inst ?prefix inst = Some (emit_inst ?prefix inst) in
+  match String.split_on_char llname ~by:'.' with
+  | ["__llair_choice"] ->
+      let reg = xlate_name x instr in
+      let msg = "__llair_choice" in
+      emit_inst (Inst.nondet ~reg:(Some reg) ~msg ~loc)
+  | ["__llair_alloc" (* void* __llair_alloc(unsigned size) *)] ->
+      let reg = xlate_name x instr in
+      let num_operand = Llvm.operand instr 0 in
+      let prefix, arg = xlate_value x num_operand in
+      let num =
+        convert_to_siz (xlate_type x (Llvm.type_of num_operand)) arg
+      in
+      let len = 1 in
+      emit_inst ~prefix (Inst.alloc ~reg ~num ~len ~loc)
+  | ["_Znwm" (* operator new(size_t num) *)]
+   |[ "_ZnwmSt11align_val_t"
+      (* operator new(unsigned long, std::align_val_t) *) ] ->
+      let reg = xlate_name x instr in
+      let prefix, num = xlate_value x (Llvm.operand instr 0) in
+      let len = size_of x (Llvm.type_of instr) in
+      emit_inst ~prefix (Inst.alloc ~reg ~num ~len ~loc)
+  | ["_ZdlPv" (* operator delete(void* ptr) *)]
+   |[ "_ZdlPvSt11align_val_t"
+      (* operator delete(void* ptr, std::align_val_t) *) ]
+   |[ "_ZdlPvmSt11align_val_t"
+      (* operator delete(void* ptr, unsigned long, std::align_val_t) *) ]
+   |["free" (* void free(void* ptr) *)] ->
+      let prefix, ptr = xlate_value x (Llvm.operand instr 0) in
+      emit_inst ~prefix (Inst.free ~ptr ~loc)
+  | "llvm" :: "memset" :: _ ->
+      let pre_0, dst = xlate_value x (Llvm.operand instr 0) in
+      let pre_1, byt = xlate_value x (Llvm.operand instr 1) in
+      let pre_2, len = xlate_value x (Llvm.operand instr 2) in
+      emit_inst
+        ~prefix:(pre_0 @ pre_1 @ pre_2)
+        (Inst.memset ~dst ~byt ~len ~loc)
+  | "llvm" :: "memcpy" :: _ ->
+      let pre_0, dst = xlate_value x (Llvm.operand instr 0) in
+      let pre_1, src = xlate_value x (Llvm.operand instr 1) in
+      let pre_2, len = xlate_value x (Llvm.operand instr 2) in
+      emit_inst
+        ~prefix:(pre_0 @ pre_1 @ pre_2)
+        (Inst.memcpy ~dst ~src ~len ~loc)
+  | "llvm" :: "memmove" :: _ ->
+      let pre_0, dst = xlate_value x (Llvm.operand instr 0) in
+      let pre_1, src = xlate_value x (Llvm.operand instr 1) in
+      let pre_2, len = xlate_value x (Llvm.operand instr 2) in
+      emit_inst
+        ~prefix:(pre_0 @ pre_1 @ pre_2)
+        (Inst.memmov ~dst ~src ~len ~loc)
+  | ["abort"] | ["llvm"; "trap"] -> emit_inst (Inst.abort ~loc)
+  | _ -> None
+
 let xlate_instr :
        pop_thunk
     -> x
@@ -1019,65 +1074,18 @@ let xlate_instr :
       (* intrinsics *)
       match xlate_intrinsic_exp fname with
       | Some intrinsic -> inline_or_move (intrinsic x)
+      | None -> (
+        match xlate_intrinsic_inst emit_inst x fname instr loc with
+        | Some code -> code
         | None -> (
           match String.split_on_char fname ~by:'.' with
-        | ["__llair_choice"] ->
-            let reg = xlate_name x instr in
-            let msg = "__llair_choice" in
-            emit_inst (Inst.nondet ~reg:(Some reg) ~msg ~loc)
           | ["__llair_throw"] ->
               let pre, exc = xlate_value x (Llvm.operand instr 0) in
               emit_term ~prefix:(pop loc @ pre) (Term.throw ~exc ~loc)
-        | ["__llair_alloc" (* void* __llair_alloc(unsigned size) *)] ->
-            let reg = xlate_name x instr in
-            let num_operand = Llvm.operand instr 0 in
-            let prefix, arg = xlate_value x num_operand in
-            let num =
-              convert_to_siz (xlate_type x (Llvm.type_of num_operand)) arg
-            in
-            let len = 1 in
-            emit_inst ~prefix (Inst.alloc ~reg ~num ~len ~loc)
-        | ["_Znwm" (* operator new(size_t num) *)]
-         |[ "_ZnwmSt11align_val_t"
-            (* operator new(unsigned long, std::align_val_t) *) ] ->
-            let reg = xlate_name x instr in
-            let prefix, num = xlate_value x (Llvm.operand instr 0) in
-            let len = size_of x (Llvm.type_of instr) in
-            emit_inst ~prefix (Inst.alloc ~reg ~num ~len ~loc)
-        | ["_ZdlPv" (* operator delete(void* ptr) *)]
-         |[ "_ZdlPvSt11align_val_t"
-            (* operator delete(void* ptr, std::align_val_t) *) ]
-         |[ "_ZdlPvmSt11align_val_t"
-            (* operator delete(void* ptr, unsigned long, std::align_val_t) *)
-          ]
-         |["free" (* void free(void* ptr) *)] ->
-            let prefix, ptr = xlate_value x (Llvm.operand instr 0) in
-            emit_inst ~prefix (Inst.free ~ptr ~loc)
-        | "llvm" :: "memset" :: _ ->
-            let pre_0, dst = xlate_value x (Llvm.operand instr 0) in
-            let pre_1, byt = xlate_value x (Llvm.operand instr 1) in
-            let pre_2, len = xlate_value x (Llvm.operand instr 2) in
-            emit_inst
-              ~prefix:(pre_0 @ pre_1 @ pre_2)
-              (Inst.memset ~dst ~byt ~len ~loc)
-        | "llvm" :: "memcpy" :: _ ->
-            let pre_0, dst = xlate_value x (Llvm.operand instr 0) in
-            let pre_1, src = xlate_value x (Llvm.operand instr 1) in
-            let pre_2, len = xlate_value x (Llvm.operand instr 2) in
-            emit_inst
-              ~prefix:(pre_0 @ pre_1 @ pre_2)
-              (Inst.memcpy ~dst ~src ~len ~loc)
-        | "llvm" :: "memmove" :: _ ->
-            let pre_0, dst = xlate_value x (Llvm.operand instr 0) in
-            let pre_1, src = xlate_value x (Llvm.operand instr 1) in
-            let pre_2, len = xlate_value x (Llvm.operand instr 2) in
-            emit_inst
-              ~prefix:(pre_0 @ pre_1 @ pre_2)
-              (Inst.memmov ~dst ~src ~len ~loc)
-        | ["abort"] | ["llvm"; "trap"] -> emit_inst (Inst.abort ~loc)
           (* dropped / handled elsewhere *)
           | ["llvm"; "dbg"; ("declare" | "value")]
-         |"llvm" :: ("lifetime" | "invariant") :: ("start" | "end") :: _ ->
+           |"llvm" :: ("lifetime" | "invariant") :: ("start" | "end") :: _
+            ->
               nop ()
           (* unimplemented *)
           | ["llvm"; ("stacksave" | "stackrestore")] ->
@@ -1108,8 +1116,8 @@ let xlate_instr :
                         && not (Llvm.is_declaration llfunc)
                       then
                         warn
-                        "ignoring variable arguments to variadic function: \
+                          "ignoring variable arguments to variadic \
-                         %a"
+                           function: %a"
                           Exp.pp callee () ;
                       let llfty = Llvm.element_type lltyp in
                       ( match Llvm.classify_type llfty with
@@ -1124,12 +1132,12 @@ let xlate_instr :
                 let areturn = xlate_name_opt x instr in
                 let return = Jump.mk lbl in
                 ( pre
-              , Term.call ~callee ~typ ~actuals ~areturn ~return ~throw:None
+                , Term.call ~callee ~typ ~actuals ~areturn ~return
-                  ~loc )
+                    ~throw:None ~loc )
               in
               continue (fun (insts, term) ->
                   let cmnd = IArray.of_list insts in
-                (pre0 @ pre, call, [Block.mk ~lbl ~cmnd ~term]) ) ) )
+                  (pre0 @ pre, call, [Block.mk ~lbl ~cmnd ~term]) ) ) ) )
   | Invoke -> (
       let llfunc = Llvm.operand instr (Llvm.num_operands instr - 3) in
       let lltyp = Llvm.type_of llfunc in