[attrs] look at capture DB only -- annotations.ml

Summary:
This call back introduces non-determinism because it first looks for the proc desc in a summary and if it doesn't find it then returns the one from the capture DB.

The problem is:
- the main factor affecting the existence of a summary on-disk is timing;
- the two proc descs are generally different, as the one in the summary is preanalysed and the one in the capture DB is not;
- this extends to the attributes included in the proc desc potentially.

The plan is to eliminate these calls one by one using the CI for correctness.

Reviewed By: skcho

Differential Revision: D29792603

fbshipit-source-id: 129054541

infer/src/absint/annotations.ml

@@ -163,7 +163,7 @@ let pdesc_return_annot_ends_with pdesc annot =
 
 
 let pname_has_return_annot pname predicate =
-  match AnalysisCallbacks.proc_resolve_attributes pname with
+  match Attributes.load pname with
   | Some attributes ->
       predicate attributes.ProcAttributes.method_annotation.return
   | None ->