12 Commits (aa6f5b2ed52f114e4a8dadd8da6c296503c4edff)

Author	SHA1	Message	Date
Josh Berdine	40ab73037e	[ocamlformat] upgrade to ocamlformat 0.7 ... Reviewed By: mbouaziz Differential Revision: D9496601 fbshipit-source-id: 83c6fd241	6 years ago
Jules Villard	8b882ac1df	Change license to MIT ... Summary: Change the license of the source code from BSD + PATENTS to MIT. Change `checkCopyright` to reflect the new license and learn some new file types. Generated with: ``` git grep BSD | xargs -n 1 ./scripts/checkCopyright -i ``` Reviewed By: jeremydubreil, mbouaziz, jberdine Differential Revision: D8071249 fbshipit-source-id: 97ca23a	7 years ago
Jules Villard	ce0ffaf877	[ocaml] detect and kill dead modules ... Summary: Add warning 60 (unused module) to the list of fatal warnings. Whitelisting modules at toplevel is tricky (see inline comments) but doable. Reviewed By: mbouaziz Differential Revision: D7790073 fbshipit-source-id: 6f591c4	7 years ago
Jules Villard	dc2cd65a2c	[explore] print only non-default values in the attributes ... Summary: Attributes have lots of fields, but the majority is usually the same from one procedure to the other. This attempts to print only non-default values, where the default is the "empty" attributes (as opposed to the "most commonly seen value" for each field), in an attempt to be predictible. This is largely something that should be done with a ppx but since there's only one use case it didn't seem worth the trouble. Output of `infer explore --procedures --procedures-attributes --procedures-name` before: ``` test: examples/hello.c test <defined> {access= <Default>; captured= []; did_preanalysis= false; err_log= [ ]; exceptions= []; formals= []; const_formals= []; by_vals= []; func_attributes= []; is_abstract= false; is_bridge_method= false; is_defined= true; is_cpp_noexcept_method= false; is_java_synchronized_method= false; is_model= false; is_specialized= false; is_synthetic_method= false; clang_method_kind= C_FUNCTION; loc= line 12, column 1; translation_unit= Some examples/hello.c; locals= [{name= s;typ= ;attributes= }]; method_annotation= <> (); objc_accessor= None; proc_flags= []; proc_name= test; ret_type= ; source_file_captured=examples/hello.c} int Hello.test(): examples/Hello.java int Hello.test() <defined> {access= <Default>; captured= []; did_preanalysis= false; err_log= [ ]; exceptions= []; formals= [(this,)]; const_formals= []; by_vals= [ ]; func_attributes= []; is_abstract= false; is_bridge_method= false; is_defined= true; is_cpp_noexcept_method= false; is_java_synchronized_method= false; is_model= false; is_specialized= false; is_synthetic_method= false; clang_method_kind= C_FUNCTION; loc= line 11; translation_unit= None; locals= [{name= $irvar0;typ= ;attributes= }; {name= s;typ= ;attributes= }]; method_annotation= <> (); objc_accessor= None; proc_flags= []; proc_name= int Hello.test(); ret_type= ; source_file_captured=examples/Hello.java} Hello.<init>(): examples/Hello.java Hello.<init>() <defined> {access= <Default>; captured= []; did_preanalysis= false; err_log= [ ]; exceptions= []; formals= [(this,)]; const_formals= []; by_vals= [ ]; func_attributes= []; is_abstract= false; is_bridge_method= false; is_defined= true; is_cpp_noexcept_method= false; is_java_synchronized_method= false; is_model= false; is_specialized= false; is_synthetic_method= false; clang_method_kind= C_FUNCTION; loc= line 10; translation_unit= None; locals= []; method_annotation= <> (); objc_accessor= None; proc_flags= []; proc_name= Hello.<init>(); ret_type= ; source_file_captured=examples/Hello.java} ``` Now: ``` test source_file: examples/hello.c proc_name: test attribute_kind: <defined> attributes: { proc_name= test ; source_file_captured= examples/hello.c ; formals= [] ; is_defined= true ; loc= line 12, column 1 ; translation_unit= <Some examples/hello.c> ; locals= [{ name= s; typ= int* }] ; ret_type= void } int Hello.test() source_file: examples/Hello.java proc_name: int Hello.test() attribute_kind: <defined> attributes: { proc_name= int Hello.test() ; source_file_captured= examples/Hello.java ; formals= [(this,Hello*)] ; is_defined= true ; loc= line 11 ; locals= [{ name= $irvar0; typ= void }; { name= s; typ= java.lang.String* }] ; ret_type= int } Hello.<init>() source_file: examples/Hello.java proc_name: Hello.<init>() attribute_kind: <defined> attributes: { proc_name= Hello.<init>() ; source_file_captured= examples/Hello.java ; formals= [(this,Hello*)] ; is_defined= true ; loc= line 10 ; ret_type= void } ``` Reviewed By: mbouaziz Differential Revision: D7757890 fbshipit-source-id: 5507ec6	7 years ago
Josh Berdine	16988b0a7a	[ocamlformat] Upgrade to ocamlformat 0.5 ... Summary: Upgrade ocamlformat, and base which needs to be done in sync in order to build ocamlformat, and the other deps can come for the ride. Reviewed By: jvillard Differential Revision: D7663537 fbshipit-source-id: 3e90970	7 years ago
Dulma Churchill	c689d5a91e	[annotations] Pretty print also the annotations parameters ... Reviewed By: jeremydubreil Differential Revision: D7112878 fbshipit-source-id: be6ea53	7 years ago
Jules Villard	58e0cbe6ee	[base] move `Config.language` to its own `Language` module ... Summary: I needed to do this for something, now I don't know if I want to do the thing anymore but this seems generally useful to decrease a little bit the size of Config.ml. Reviewed By: sblackshear, mbouaziz Differential Revision: D6796427 fbshipit-source-id: d9c009d	7 years ago
Jules Villard	4b1a7b1771	[cleanup] remove dead code ... Summary: Found the dead code with the script in the next commit, iteratively until no warnings remained. Methodology: 1. I kept pretty-printers for values, which can be useful to use from infer's REPL (or when printf-debugging infer in general) 2. I kept functions that formed some consistent API (but not often, so YMMV), for instance if it looked like `Set.S`, or if it provides utility functions for stuff in development (mostly the procname dispatcher functions) 3. I tried not to lose comments associated with values no longer exported: if the value is commented in the .mli and not the .ml, I moved the comment 4. Some comments needed updating (not claiming I caught all of those) 5. Sometimes I rewrote the comments a bit when I noticed mis-attached comments Reviewed By: mbouaziz Differential Revision: D6723482 fbshipit-source-id: eabaafd	7 years ago
Jules Villard	6a8d71ad81	[style] s/_foo/foo_/ when `foo_` is not unused ... Summary: Naming a variable `_foo` makes the compiler not warn about them if they are unused, but there are lots of instances of such variables in the code where they are in fact used, defeating the warning and introducing confusion for those used to this naming convention. Basically `sed -i -e "s/ _\([a-zA-Z][a-zA-Z0-9_']*\)/ \1_/g" **/*.ml` followed by manual fixing of compilation errors (lots of `compare__foo` -> `compare_foo_`). Reviewed By: mbouaziz Differential Revision: D6358837 fbshipit-source-id: 7ffb4ac	7 years ago
Josh Berdine	f89e687efa	[ocamlformat] Use ocamlformat from github ... Summary: Install ocamlformat from github as part of `make devsetup`, and use it for formatting OCaml (and jbuild) code. Reviewed By: jvillard Differential Revision: D6092464 fbshipit-source-id: 4ba0845	7 years ago
Sam Blackshear	e43090bdc2	[java] translate `final` keyword as annotation ... Reviewed By: jeremydubreil Differential Revision: D5500344 fbshipit-source-id: d401c51	7 years ago
Josh Berdine	bab3d81cb0	Convert Reason to OCaml, and auto-format OCaml ... Summary: Conversion and reformat of infer source using ocamlformat auto-formatting tool. Current status: - Because Reason does not handle docstrings, the output of the conversion is not 'Warning 50'-clean, meaning that there are docstrings with ambiguous placement. I'll need to manually fix them just before landing. Reviewed By: jvillard Differential Revision: D5225546 fbshipit-source-id: 3bd2786	7 years ago