Mehdi Bouaziz
f8380f9480
Trying to fix comments on Localise.ml
...
Reviewed By: da319
Differential Revision: D9496535
fbshipit-source-id: b73c89633
6 years ago
Nikos Gorogiannis
14556f52b4
[starvation] whitelist @WorkerThread methods
...
Reviewed By: mbouaziz, ddino
Differential Revision: D9480061
fbshipit-source-id: 4648319e1
6 years ago
Mehdi Bouaziz
a06685c517
[inferbo] Add mli for proof obligations
...
Reviewed By: skcho
Differential Revision: D9480149
fbshipit-source-id: 305ab24b1
6 years ago
Jeremy Dubreil
426ddb5e1c
[nullable] make the Eradicate flag use_models to be the default mode
...
Summary: There no clear alternative to using models of the standard library at this point so we can simplify the code a little bit
Reviewed By: mbouaziz
Differential Revision: D9491062
fbshipit-source-id: 9e5a6eeea
6 years ago
Sungkeun Cho
524ae3a7e2
[inferbo] Return unknown value on non-const function calls
...
Summary:
It returns unknown values on non-const function calls like on unknown
function calls.
Reviewed By: mbouaziz
Differential Revision: D9478862
fbshipit-source-id: 4b795ec55
6 years ago
Jules Villard
a3d5f0283d
[clang] only pass `--Xclang` args to driver commands
...
Summary:
Not all clang commands are happy with all arguments, but the driver is usually
the place we want to add arguments to.
Reviewed By: martinoluca
Differential Revision: D9421403
fbshipit-source-id: fa6d39a9b
6 years ago
Sungkeun Cho
76bf31bc17
[inferbo] Add a test case of global constant
...
Summary: `CONDITION_ALWAYS_**` can be introduced by global constants.
Reviewed By: ezgicicek, mbouaziz
Differential Revision: D9478528
fbshipit-source-id: 7b1a46e7a
6 years ago
Jeremy Dubreil
ed638de189
[eradicate] remove the check extension flag which was always false
...
Reviewed By: mbouaziz
Differential Revision: D9130163
fbshipit-source-id: 4510eb4a5
6 years ago
Mehdi Bouaziz
277fd06782
[inferbo] Simplify condition trace
...
Reviewed By: skcho
Differential Revision: D9372262
fbshipit-source-id: 5338d5437
6 years ago
Mehdi Bouaziz
5817ff6adc
[inferbo] Do not re-report issues if the precision hasn't improved
...
Reviewed By: Julek
Differential Revision: D9400004
fbshipit-source-id: 916de6db1
6 years ago
Jeremy Dubreil
735b28f359
[infer] remove the bug_class from the Infer report
...
Summary: This field does not seem to be used anywhere
Reviewed By: mbouaziz
Differential Revision: D9184595
fbshipit-source-id: d6eb62bca
6 years ago
Jeremy Dubreil
3cffdb9745
[infer] remove the field procedure_id in the analysis report
...
Summary: The `procedure_id` is not used in the final report
Reviewed By: mbouaziz
Differential Revision: D9176276
fbshipit-source-id: 2397b01c4
6 years ago
Mehdi Bouaziz
5a4d4f0882
[inferbo] Fail if trying to substitute non-symbolic conditions
...
Reviewed By: ezgicicek
Differential Revision: D9377804
fbshipit-source-id: 609fd1594
6 years ago
Mehdi Bouaziz
6bb429ef63
Reporting cleanup 13: log_issue_external
...
Reviewed By: jvillard
Differential Revision: D9369295
fbshipit-source-id: faf56b177
6 years ago
Mehdi Bouaziz
9dad4c3648
Reporting cleanup 12: node_id_key -> node
...
Reviewed By: jvillard
Differential Revision: D9360943
fbshipit-source-id: 6f2c5720c
6 years ago
Mehdi Bouaziz
3986a823f8
Reporting cleanup 11: node_id
...
Reviewed By: jvillard
Differential Revision: D9360697
fbshipit-source-id: 688aae944
6 years ago
Jules Villard
3f4cb5cae9
[dune] upgrade to 1.1.1
...
Summary:
This seems to fix intermittent "Corrupted compilation unit description" failures in the build: https://github.com/ocaml/dune/issues/1157
It also fixes build warnings 58: https://github.com/ocaml/dune/issues/1107
Reviewed By: mbouaziz
Differential Revision: D9420579
fbshipit-source-id: d63adee67
6 years ago
Mehdi Bouaziz
1a75fa9ebd
[inferbo] Propagate INFERBO_ALLOC_MAY_BE_ even when the bound is infinity
...
Reviewed By: skcho
Differential Revision: D9398450
fbshipit-source-id: 7b676615e
6 years ago
Mehdi Bouaziz
693089ab08
[inferbo] Alloc site in the trace for INFERBO_ALLOC_xx issues
...
Reviewed By: skcho
Differential Revision: D9398353
fbshipit-source-id: 0d2e5c961
6 years ago
Mehdi Bouaziz
364099530e
[inferbo] Retrieve callee_pdesc and payload at the same time
...
Reviewed By: jvillard
Differential Revision: D9378011
fbshipit-source-id: c67c46e12
6 years ago
Jeremy Dubreil
1938c4b758
[eradicate] remove TypeState extensions
...
Reviewed By: mbouaziz
Differential Revision: D9388068
fbshipit-source-id: dd63c8863
6 years ago
Dino Distefano
370f33c8dc
Added predicate for CXX11ConstantExpr
...
Reviewed By: jvillard
Differential Revision: D9313716
fbshipit-source-id: 24588b600
6 years ago
Nikos Gorogiannis
af14da6a13
[starvation] stop considering View.get... as blocking.
...
Reviewed By: ddino
Differential Revision: D9397992
fbshipit-source-id: da6d5a987
6 years ago
Ezgi Çiçek
527fb90bbe
[Cost] Add a Java model for functions to be considered invariant
...
fbshipit-source-id: e2fa74b19
6 years ago
Jeremy Dubreil
070f541226
[infer][nullsafe] cleanup of the Eradicate code 1
...
Summary: Remove unecessary level of functorisation
Reviewed By: jberdine
Differential Revision: D9387985
fbshipit-source-id: e0bcf1b13
6 years ago
Jeremy Dubreil
98c596c546
[infer][biabduction] generate the Objective C and C++ models in single core mode
...
Reviewed By: mbouaziz
Differential Revision: D9370381
fbshipit-source-id: 5da2d2e76
6 years ago
Katie Ots
7c8f00eb76
Update ocamlformat hash to match git release hash
...
Reviewed By: jberdine
Differential Revision: D9378850
fbshipit-source-id: c245a8cfd
6 years ago
Katie Ots
789fcaff4c
Add file containing hash of required ocamlformat version
...
Reviewed By: jvillard
Differential Revision: D9360792
fbshipit-source-id: 0e8725ea0
6 years ago
Mehdi Bouaziz
07f22daada
[inferbo] Report calls without ()
...
Summary: This is not needed.
Reviewed By: skcho
Differential Revision: D9372037
fbshipit-source-id: 9c9a90ba6
6 years ago
Mehdi Bouaziz
34a6a487c5
Reporting cleanup 10: log_frontend_issue
...
Summary: Actually only `CFrontend_errors` is calling `log_issue_from_errlog` directly, let's rename it, and specify `node_id_key` to `node_key`
Reviewed By: jeremydubreil
Differential Revision: D9360651
fbshipit-source-id: 5d63e51e9
6 years ago
Ezgi Çiçek
cc18f9883d
[Cost] Fix invariant variable analysis to be based on all reaching defns
...
Reviewed By: mbouaziz
Differential Revision: D9337572
fbshipit-source-id: f7f5f7572
6 years ago
Mehdi Bouaziz
eb282797ab
Reporting cleanup 9: move NodeKey to Procdesc
...
Reviewed By: jeremydubreil
Differential Revision: D9351622
fbshipit-source-id: f8c5690f8
6 years ago
Jules Villard
d9e12850b9
[biabd] do not try to bypass `Ondemand` to get proc desc of models
...
Summary:
After some testing, it looks like getting the pdesc via
`Ondemand.get_proc_desc` will also load models' proc descs from their
summaries, so this code should not be needed.
Reviewed By: jeremydubreil, mbouaziz, martintrojer
Differential Revision: D9197176
fbshipit-source-id: 1b8603bfa
6 years ago
Martino Luca
55c2188615
[Perf] Emit costs to a separate file named costs-report.json
...
Reviewed By: mbouaziz
Differential Revision: D9337974
fbshipit-source-id: 392410736
6 years ago
Mehdi Bouaziz
04af716fba
Reporting cleanup 8: move errlog to summary
...
Reviewed By: jeremydubreil
Differential Revision: D9351379
fbshipit-source-id: 7056c6e87
6 years ago
Mehdi Bouaziz
ac5633bf58
Reporting cleanup 7: session
...
Reviewed By: jeremydubreil
Differential Revision: D9349672
fbshipit-source-id: 6d33c8e76
6 years ago
Mehdi Bouaziz
fbe1e853f4
Reporting cleanup 6: mandatory loc for reporting errors
...
Summary:
`Errlog` will merge similar issues (same severity, name, description) reported at the same location, so let's make sure the locaiton is mandatory.
Issues:
- errors happening in `Ondemand` still use the `State` which makes sense only for biabduction and eradicate
- a case of `NullabilitySuggest` didn't have a location, I did my best to patch it but I'm sure the location could be more precise
Reviewed By: jvillard
Differential Revision: D9332840
fbshipit-source-id: ee7898146
6 years ago
Mehdi Bouaziz
7024543dc9
Reporting cleanup 5: log_warning/error node_id_key
...
Summary: Keeping pushing arguments higher in the stack, `node_id_key` is not used in calls to `log_warning/error`
Reviewed By: jvillard
Differential Revision: D9332826
fbshipit-source-id: e5c48c686
6 years ago
Mehdi Bouaziz
2ee4b5da18
Reporting cleanup 4: clang_method_kind
...
Summary:
Before we would convert it to string in `Reporting` and pass it to `Errlog` which would use it only to 'log events'.
I guess the reason is that there was a cyclic dependency between `Errlog` and `clang_method_kind` defined in `ProcAttributes`.
This diff:
- moves it to its own module
- defers the conversion to string
Reviewed By: jvillard
Differential Revision: D9332819
fbshipit-source-id: 43a028b61
6 years ago
Martin Trojer
451f8f1efa
Add --Xbuck-no-inline and --Xclang flags to enable jackalope/ios builds.
...
Reviewed By: jvillard
Differential Revision: D9296445
fbshipit-source-id: 196e527eb
6 years ago
Mehdi Bouaziz
919d05b5ef
Reporting cleanup 3: NodeKey
...
Summary:
- abstracted the type for a node key
- moved it to its own module with an ugly `compute` to avoid cyclic dependencies...
- renamed `node_id` to `node_id_key` where needed
- moved key computation from `State` to `Procdesc.Node`
Reviewed By: jvillard
Differential Revision: D9332803
fbshipit-source-id: fe1ae8c1c
6 years ago
Julian Sutherland
dd4ee55d5a
fixed error in java expected test results
...
Reviewed By: mbouaziz
Differential Revision: D9337793
fbshipit-source-id: f0fa95015
6 years ago
Martin Trojer
7c57d6e017
Lock g++ platform so clang-plugins builds on devservers
...
Reviewed By: codemiller
Differential Revision: D9136267
fbshipit-source-id: 64819e7cf
6 years ago
Mehdi Bouaziz
114c4e436d
Reporting cleanup 2: Errlog.log_issue
...
Summary:
- made arguments of `Errlog.log_issue` mandatory
- pushed some arguments of `log_issue_from_errlog` higher in the stack, the goal is to make sure `State` is only used in analyses that update it (biabduction and eradicate, if I'm correct)
Reviewed By: jvillard
Differential Revision: D9332773
fbshipit-source-id: ce79df21c
6 years ago
Julian Sutherland
b7c90c3fe0
Fixed incorrect reporting of tainted index in function call by quandary
...
Reviewed By: mbouaziz
Differential Revision: D9315815
fbshipit-source-id: 943ab2a14
6 years ago
Martino Luca
90a3315042
[InferPrint] Refactor common aspects to emit json reports
...
Reviewed By: mbouaziz
Differential Revision: D9295513
fbshipit-source-id: 5d966217a
6 years ago
Mehdi Bouaziz
f08ba1c016
Reporting cleanup 1: log_issue_deprecated
...
Summary:
- inlined `log_info/warning/error_deprecated` to make calls to `log_issue_deprecated` easier to grep
- removed unused optional `store_summary`
- removed 'not supported severity'
Reviewed By: jvillard
Differential Revision: D9332733
fbshipit-source-id: 821324c21
6 years ago
Katie Ots
ecde8a7660
Add ocamlformat shim script to install correct version
...
Reviewed By: jvillard
Differential Revision: D9333255
fbshipit-source-id: 7b5de2d61
6 years ago
Mehdi Bouaziz
e3e521afca
Kill MinTree
...
Reviewed By: ddino
Differential Revision: D8379876
fbshipit-source-id: 6aac787f2
6 years ago
Mehdi Bouaziz
add478d97d
Remove Errlog.equal
...
Reviewed By: jeremydubreil
Differential Revision: D9327478
fbshipit-source-id: 465e09a6b
6 years ago