[racerd] make unknown-returns-owned true by default

Summary: This option makes RacerD angelic wrt the ownership of returned objects from procedures without summary. This will now be made the default and the option deprecated up the diff stack.

Reviewed By: dulmarod

Differential Revision: D21174676

fbshipit-source-id: 9c48d3d7d

infer/man/man1/infer-analyze.txt

@@ -430,10 +430,10 @@ RACERD CHECKER OPTIONS
            Activates: Check @GuardedBy annotations with RacerD (Conversely:
            --no-racerd-guardedby)
 
-       --racerd-unknown-returns-owned
+       --no-racerd-unknown-returns-owned
-           Activates: Assume that all methods without a CFG (including
+           Deactivates: Assume that all methods without a CFG (including
            abstract methods) return owned objects (Conversely:
-           --no-racerd-unknown-returns-owned)
+           --racerd-unknown-returns-owned)
 
        --threadsafe-aliases json
            Specify custom annotations that should be considered aliases of

infer/man/man1/infer-full.txt

@@ -910,10 +910,10 @@ OPTIONS
            Activates: Enable --racerd and disable all other checkers
            (Conversely: --no-racerd-only)           See also infer-analyze(1).
 
-       --racerd-unknown-returns-owned
+       --no-racerd-unknown-returns-owned
-           Activates: Assume that all methods without a CFG (including
+           Deactivates: Assume that all methods without a CFG (including
            abstract methods) return owned objects (Conversely:
-           --no-racerd-unknown-returns-owned)           See also infer-analyze(1).
+           --racerd-unknown-returns-owned)           See also infer-analyze(1).
 
        --reactive,-r
            Activates: Reactive mode: the analysis starts from the files

infer/man/man1/infer.txt

@@ -910,10 +910,10 @@ OPTIONS
            Activates: Enable --racerd and disable all other checkers
            (Conversely: --no-racerd-only)           See also infer-analyze(1).
 
-       --racerd-unknown-returns-owned
+       --no-racerd-unknown-returns-owned
-           Activates: Assume that all methods without a CFG (including
+           Deactivates: Assume that all methods without a CFG (including
            abstract methods) return owned objects (Conversely:
-           --no-racerd-unknown-returns-owned)           See also infer-analyze(1).
+           --racerd-unknown-returns-owned)           See also infer-analyze(1).
 
        --reactive,-r
            Activates: Reactive mode: the analysis starts from the files

infer/src/base/Config.ml

@@ -1830,7 +1830,7 @@ and racerd_guardedby =
 
 
 and racerd_unknown_returns_owned =
-  CLOpt.mk_bool ~long:"racerd-unknown-returns-owned" ~default:false
+  CLOpt.mk_bool ~long:"racerd-unknown-returns-owned" ~default:true
     ~in_help:InferCommand.[(Analyze, manual_racerd)]
     "Assume that all methods without a CFG (including abstract methods) return owned objects"