Revert "[sqlite] enforce attribute.is_defined iff procdesc is not NULL"

Summary: This reverts commit 983216cb697840fce59af80ffc143353b8e1473d.

Reviewed By: jvillard

Differential Revision: D23706950

fbshipit-source-id: 9b1cf9e64

infer/src/IR/Attributes.ml

@@ -67,13 +67,6 @@ let find =
 let load pname = find (Procname.to_unique_id pname)
 
 let store ~proc_desc (attr : ProcAttributes.t) =
-  if attr.is_defined && Option.is_none proc_desc then
-    Logging.die InternalError "Was given DEFINED procedure without procdesc: %a@." ProcAttributes.pp
-      attr ;
-  if (not attr.is_defined) && Option.is_some proc_desc then
-    Logging.die InternalError
-      "Was given UNDEFINED procedure WITH procdesc:@\nAttributes:%a@\nProcdesc:%a@."
-      ProcAttributes.pp attr (Pp.option Procdesc.pp_signature) proc_desc ;
   let pname = attr.proc_name in
   let akind = proc_kind_of_attr attr in
   let proc_uid = Procname.to_unique_id pname in

infer/src/IR/Cfg.ml

@@ -52,7 +52,7 @@ let store source_file cfg =
       {attributes with loc= loc'; translation_unit= source_file}
     in
     Procdesc.set_attributes proc_desc attributes' ;
-    Attributes.store ~proc_desc:(Option.some_if attributes.is_defined proc_desc) attributes'
+    Attributes.store ~proc_desc:(Some proc_desc) attributes'
   in
   Procname.Hash.iter save_proc cfg
 

infer/src/biabduction/SymExec.ml

@@ -374,7 +374,7 @@ let reason_to_skip ~callee_desc : string option =
         if Option.is_some attr_reason then attr_reason else Some "function or method not found"
   | `ProcName callee_pname ->
       let pname_reason = reason_from_pname callee_pname in
-      if Option.is_some pname_reason then pname_reason else Some "method has no implementation"
+      if Option.is_some pname_reason then pname_reason else Some "function or method not found"
 
 
 (** In case of constant string dereference, return the result immediately *)

infer/tests/codetoanalyze/objc/biabduction/issues.exp

@@ -79,7 +79,6 @@ codetoanalyze/objc/biabduction/subtyping/KindOfClassExample.m, shouldThrowDivide
 codetoanalyze/objc/biabduction/subtyping/KindOfClassExample.m, shouldThrowDivideByZero2, 2, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure shouldThrowDivideByZero2(),start of procedure init,return from a call to Base.init,start of procedure returnsZero2(),Taking false branch,return from a call to returnsZero2]
 codetoanalyze/objc/biabduction/subtyping/KindOfClassExample.m, shouldThrowDivideByZero3, 3, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure shouldThrowDivideByZero3(),start of procedure init,return from a call to Derived.init,Taking true branch]
 codetoanalyze/objc/biabduction/variadic_methods/premature_nil_termination.m, PrematureNilTermA.nilInArrayWithObjects, 5, PREMATURE_NIL_TERMINATION_ARGUMENT, B1, WARNING, [start of procedure nilInArrayWithObjects]
-objc/src/CADisplayLink.m, CADisplayLink.displayLinkWithTarget:selector:, 3, Missing_fld, no_bucket, ERROR, [start of procedure displayLinkWithTarget:selector:]
 codetoanalyze/objc/biabduction/memory_leaks_benchmark/NSData_models_tests.m, NSData_models_tests.macForIV:, 2, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure macForIV:]
 codetoanalyze/objc/biabduction/memory_leaks_benchmark/NSString_models_tests.m, StringInitA.hexStringValue, 11, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure hexStringValue,Skipping CFStringCreateWithBytesNoCopy(): method has no implementation,Taking false branch]
 codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleLength3.m, strongcycle, 6, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure strongcycle(),start of procedure setB:,return from a call to AA.setB:,start of procedure setC:,return from a call to BB.setC:,start of procedure setA:,return from a call to CC.setA:]
@@ -98,8 +97,7 @@ codetoanalyze/objc/biabduction/npe/block.m, BlockA.foo7, 2, IVAR_NOT_NULL_CHECKE
 codetoanalyze/objc/biabduction/npe/dynamic_dispatch.m, DynamicDispatchMain.npe_bad, 2, NULL_DEREFERENCE, B5, ERROR, [start of procedure npe_bad,start of procedure get_ddclass_from:,start of procedure get_ddclass,return from a call to PInstance.get_ddclass,return from a call to DynamicDispatchMain.get_ddclass_from:]
 codetoanalyze/objc/biabduction/npe/dynamic_dispatch.m, objc_blockDynamicDispatchMain.dispatch_async_block_npe_bad_1, 3, NULL_DEREFERENCE, B5, ERROR, [start of procedure block,start of procedure get_ddclass_from:,start of procedure get_ddclass,return from a call to PInstance.get_ddclass,return from a call to DynamicDispatchMain.get_ddclass_from:]
 codetoanalyze/objc/biabduction/npe/ivar_blocks.m, MyClass.ivar_npe, 1, IVAR_NOT_NULL_CHECKED, B1, WARNING, [start of procedure ivar_npe]
-codetoanalyze/objc/biabduction/npe/skip_method_with_nil_object.m, SkipMethodNilA.testBug:, 6, PARAMETER_NOT_NULL_CHECKED, B2, WARNING, [start of procedure testBug:,Message get_a with receiver nil returns nil.,Skipping skip_method: method has no implementation,Taking false branch]
+codetoanalyze/objc/biabduction/npe/skip_method_with_nil_object.m, SkipMethodNilA.testBug:, 6, PARAMETER_NOT_NULL_CHECKED, B2, WARNING, [start of procedure testBug:,Message get_a with receiver nil returns nil.,Message skip_method with receiver nil returns nil.,Taking false branch]
-codetoanalyze/objc/biabduction/npe/skip_method_with_nil_object.m, SkipMethodNilA.testOk_FP, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure testOk_FP,Skipping skip_method: method has no implementation,Taking true branch]
 codetoanalyze/objc/biabduction/property/main.c, property_main, 3, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure property_main(),Skipping aProperty: method has no implementation]
 codetoanalyze/objc/biabduction/resource_leaks/Dispatch_sources.m, ProcessContentsOfFile, 35, RESOURCE_LEAK, no_bucket, ERROR, [start of procedure ProcessContentsOfFile(),Taking false branch,Skipping dispatch_get_global_queue(): method has no implementation,Skipping dispatch_source_create(): method has no implementation,Taking false branch]
 codetoanalyze/objc/biabduction/resource_leaks/Dispatch_sources.m, objc_blockProcessContentsOfFile_2, 6, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure block,Skipping dispatch_source_get_data(): method has no implementation,Taking true branch,Skipping MyProcessFileData(): method has no implementation]

infer/tests/codetoanalyze/objc/biabduction/npe/ObjCMethodCallInCondition.m

@@ -21,7 +21,7 @@
 - (void)testLength:(NSData*)imageData {
   unsigned char* pixels = (unsigned char*)[imageData bytes];
 
-  if (imageData && imageData.length > 0) {
+  if (imageData.length > 0) {
     pixels[0] = 255;
   }
 }

infer/tests/codetoanalyze/objc/biabduction/npe/skip_method_with_nil_object.m

@@ -23,8 +23,8 @@
   return [SkipMethodNilA new];
 }
 
-- (int)testOk_FP {
+- (int)testOk:(SkipMethodNilA*)person {
-  SkipMethodNilA* personID = nil;
+  SkipMethodNilA* personID = [person get_a];
   NSString* lastRecord = [personID skip_method];
   if (lastRecord) {
     personID->x = 6;