[infer] use the procedure name to match Java methods instead of the procedure id

Summary: The procedure id is likely to be trucated with random CRC values so we should probably not use it to match Java names

Reviewed By: mbouaziz

Differential Revision: D9183518

fbshipit-source-id: b450c7869
master
Jeremy Dubreil 7 years ago committed by Facebook Github Bot
parent d000a27bd4
commit 54946ce08e

@ -42,7 +42,6 @@ JSON_INDEX_ISL_ENUM = 'enum'
JSON_INDEX_KIND = 'kind' JSON_INDEX_KIND = 'kind'
JSON_INDEX_LINE = 'line' JSON_INDEX_LINE = 'line'
JSON_INDEX_PROCEDURE = 'procedure' JSON_INDEX_PROCEDURE = 'procedure'
JSON_INDEX_PROCEDURE_ID = 'procedure_id'
JSON_INDEX_QUALIFIER = 'qualifier' JSON_INDEX_QUALIFIER = 'qualifier'
JSON_INDEX_QUALIFIER_TAGS = 'qualifier_tags' JSON_INDEX_QUALIFIER_TAGS = 'qualifier_tags'
JSON_INDEX_TYPE = 'bug_type' JSON_INDEX_TYPE = 'bug_type'
@ -229,7 +228,7 @@ def _pmd_xml_of_issues(issues):
successful_java = False successful_java = False
if issue[JSON_INDEX_FILENAME].endswith('.java'): if issue[JSON_INDEX_FILENAME].endswith('.java'):
fully_qualified_method_name = re.search( fully_qualified_method_name = re.search(
'(.*)\(.*', issue[JSON_INDEX_PROCEDURE_ID]) '(.*)\(.*', issue[JSON_INDEX_PROCEDURE])
if fully_qualified_method_name is not None: if fully_qualified_method_name is not None:
# probably Java, let's try # probably Java, let's try
try: try:

Loading…
Cancel
Save