[cost] Critical parts of the cost message should be to bold

Summary: Let's make UI/Cold start parts of the message bold to get more attention.

Reviewed By: jvillard

Differential Revision: D18504857

fbshipit-source-id: b0f199f55
master
Ezgi Çiçek 5 years ago committed by Facebook Github Bot
parent bf581e0b72
commit 80d294ff8d

@ -250,9 +250,11 @@ let issue_of_cost kind CostIssues.{complexity_increase_issue; zero_issue; infini
let cold_start_or_ui_msg = let cold_start_or_ui_msg =
let common_msg = "It is very important to avoid potential regressions in this phase." in let common_msg = "It is very important to avoid potential regressions in this phase." in
if is_on_ui_thread then if is_on_ui_thread then
Format.asprintf "This function is called on the UI Thread! %s" common_msg Format.asprintf "%a %s" MarkupFormatter.pp_bold
"This function is called on the UI Thread!" common_msg
else if ExternalPerfData.in_profiler_data_map procname then else if ExternalPerfData.in_profiler_data_map procname then
Format.asprintf "This function is called during cold start! %s" common_msg Format.asprintf "%a %s" MarkupFormatter.pp_bold
"This function is called during cold start!" common_msg
else "" else ""
in in
let msg = let msg =

Loading…
Cancel
Save