[buck] do not pass unused --buck to python

Summary:
It is not used, so one fewer thing to track inside Python.

Note that Python does pass `--buck` to OCaml infer to make it aware that it is
running from within Buck, and the OCaml code uses that flag to trim infer-out
to only what's strictly necessary (and especially to remove non-deterministic
output that would mess with Buck's cache).

Reviewed By: jberdine

Differential Revision: D5200043

fbshipit-source-id: 1c84442

infer/lib/python/inferlib/analyze.py

@@ -71,8 +71,5 @@ infer_group.add_argument('-l', '--load-average', metavar='<float>', type=float,
                          'be started if there are others jobs running and the '
                          'load average is at least <float>.')
 
-infer_group.add_argument('--buck', action='store_true', dest='buck',
-                         help='To use when run with buck')
-
 infer_group.add_argument('--java-jar-compiler',
                          metavar='<file>')

infer/src/backend/infer.ml

@@ -270,8 +270,6 @@ let capture = function
            | _ -> []) @
           (if not Config.create_harness then [] else
              ["--android-harness"]) @
-          (if not Config.buck then [] else
-             ["--buck"]) @
           (match Config.java_jar_compiler with None -> [] | Some p ->
               ["--java-jar-compiler"; p]) @
           (match List.rev Config.buck_build_args with