[reporting] fix position of optional arg

Summary: Optional args shouldn't be at the end of the arg list.

Reviewed By: dulmarod

Differential Revision: D8298979

fbshipit-source-id: 17680f6
master
Nikos Gorogiannis 7 years ago committed by Facebook Github Bot
parent cacc975394
commit a5f9bcbbde

@ -100,7 +100,7 @@ let log_issue_external procname ?clang_method_kind err_kind ?loc ?node_id ?sessi
?linters_def_file ?doc_url ?access exn ?linters_def_file ?doc_url ?access exn
let is_suppressed tenv proc_desc kind ?(field_name= None) = let is_suppressed ?(field_name= None) tenv proc_desc kind =
let lookup = Tenv.lookup tenv in let lookup = Tenv.lookup tenv in
let proc_attributes = Summary.pdesc_resolve_attributes proc_desc in let proc_attributes = Summary.pdesc_resolve_attributes proc_desc in
(* Errors can be suppressed with annotations. An error of kind CHECKER_ERROR_NAME can be (* Errors can be suppressed with annotations. An error of kind CHECKER_ERROR_NAME can be

@ -47,5 +47,5 @@ val log_issue_external :
(** Log an issue to the error log in [IssueLog] associated with the given procname. *) (** Log an issue to the error log in [IssueLog] associated with the given procname. *)
val is_suppressed : val is_suppressed :
Tenv.t -> Procdesc.t -> IssueType.t -> ?field_name:Typ.Fieldname.t option -> bool ?field_name:Typ.Fieldname.t option -> Tenv.t -> Procdesc.t -> IssueType.t -> bool
(** should an issue report be suppressed due to a [@SuppressLint("issue")] annotation? *) (** should an issue report be suppressed due to a [@SuppressLint("issue")] annotation? *)

Loading…
Cancel
Save