[hoisting] Turn on hoisting of expensive functions by default

Reviewed By: mbouaziz

Differential Revision: D14971084

fbshipit-source-id: ccbf6055e

infer/man/man1/infer-full.txt

@@ -440,10 +440,10 @@ OPTIONS
            infer-diff(1), infer-events(1), infer-explore(1), infer-report(1),
            infer-reportdiff(1), and infer-run(1).
 
-       --hoisting-report-only-expensive
-           Activates: [Hoisting] Report loop-invariant calls only when the
+       --no-hoisting-report-only-expensive
+           Deactivates: [Hoisting] Report loop-invariant calls only when the
            function is expensive, i.e. at least linear (Conversely:
-           --no-hoisting-report-only-expensive)           See also infer-report(1).
+           --hoisting-report-only-expensive)           See also infer-report(1).
 
        --html
            Activates: Generate html report. (Conversely: --no-html)       

infer/man/man1/infer-report.txt

@@ -165,10 +165,10 @@ OPTIONS
            compiled or not (Conversely:
            --no-skip-analysis-in-path-skips-compilation)
 HOISTING OPTIONS
-       --hoisting-report-only-expensive
-           Activates: [Hoisting] Report loop-invariant calls only when the
+       --no-hoisting-report-only-expensive
+           Deactivates: [Hoisting] Report loop-invariant calls only when the
            function is expensive, i.e. at least linear (Conversely:
-           --no-hoisting-report-only-expensive)
+           --hoisting-report-only-expensive)
 
 
 ENVIRONMENT

infer/man/man1/infer.txt

@@ -440,10 +440,10 @@ OPTIONS
            infer-diff(1), infer-events(1), infer-explore(1), infer-report(1),
            infer-reportdiff(1), and infer-run(1).
 
-       --hoisting-report-only-expensive
-           Activates: [Hoisting] Report loop-invariant calls only when the
+       --no-hoisting-report-only-expensive
+           Deactivates: [Hoisting] Report loop-invariant calls only when the
            function is expensive, i.e. at least linear (Conversely:
-           --no-hoisting-report-only-expensive)           See also infer-report(1).
+           --hoisting-report-only-expensive)           See also infer-report(1).
 
        --html
            Activates: Generate html report. (Conversely: --no-html)       

infer/src/base/Config.ml

@@ -1432,7 +1432,7 @@ and html =
 
 
 and hoisting_report_only_expensive =
-  CLOpt.mk_bool ~long:"hoisting-report-only-expensive" ~default:false
+  CLOpt.mk_bool ~long:"hoisting-report-only-expensive" ~default:true
     ~in_help:InferCommand.[(Report, manual_hoisting)]
     "[Hoisting] Report loop-invariant calls only when the function is expensive, i.e. at least \
      linear"

infer/tests/codetoanalyze/java/hoisting/Makefile

@@ -5,7 +5,7 @@
 
 TESTS_DIR = ../../..
 
-INFER_OPTIONS = --loop-hoisting-only --purity  --debug-exceptions
+INFER_OPTIONS = --loop-hoisting-only --purity --no-hoisting-report-only-expensive  --debug-exceptions
 INFERPRINT_OPTIONS = --issues-tests
 SOURCES = $(wildcard *.java)
 

infer/tests/codetoanalyze/java/hoistingExpensive/Makefile

@@ -5,7 +5,7 @@
 
 TESTS_DIR = ../../..
 
-INFER_OPTIONS = --loop-hoisting-only --purity --hoisting-report-only-expensive  --debug-exceptions
+INFER_OPTIONS = --loop-hoisting-only --purity --debug-exceptions
 INFERPRINT_OPTIONS = --issues-tests
 SOURCES = $(wildcard *.java)