pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '7df439c814'
${ noResults }
infer_clone/Makefile

894 lines
31 KiB
Raw Normal View History Unescape

[copyright] Remove years Reviewed By: jvillard Differential Revision: D15771884 fbshipit-source-id: e2997e3a3
6 years ago
# Copyright (c) Facebook, Inc. and its affiliates.
add files lost in sync with internal repo
9 years ago
#
Change license to MIT Summary: Change the license of the source code from BSD + PATENTS to MIT. Change `checkCopyright` to reflect the new license and learn some new file types. Generated with: ``` git grep BSD | xargs -n 1 ./scripts/checkCopyright -i ``` Reviewed By: jeremydubreil, mbouaziz, jberdine Differential Revision: D8071249 fbshipit-source-id: 97ca23a
7 years ago
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
add files lost in sync with internal repo
9 years ago
[make] only compile infer by default Summary: Define `default` target at the very top of the Makefile to make sure some other target doesn't replace it, as was done accidentally in D5498555 Reviewed By: martinoluca Differential Revision: D5536691 fbshipit-source-id: 7398ec0
7 years ago
.PHONY: default
default: infer
add files lost in sync with internal repo
9 years ago
ROOT_DIR = .
[tests] convert ant integration test to a Makefile Summary: Time for this framework to die. This converts the ant test to a Makefile. The design is that each test or family of tests will have its own directory. Do the necessary plumbing from the toplevel Makefile so that `make test` runs the migrated tests. Reviewed By: jberdine Differential Revision: D4106298 fbshipit-source-id: 7bd694d
8 years ago
include $(ROOT_DIR)/Makefile.config
Update infer to use yarn to manage dependencies Reviewed By: bestander, jvillard Differential Revision: D3944701 fbshipit-source-id: 62b019c
8 years ago
[make] fix `make devsetup` Summary: Making the shell stricter revealed a bug in `make devsetup`: `shell_config_file` can be used without being initialised. Also, the error path when testing if `BUILD_MODE` was set to default was wrong and would execute all except the first `echo` command unconditionally. I changed the test so that it tests only if `BUILD_MODE` is set in the environment. Reviewed By: martinoluca Differential Revision: D7615333 fbshipit-source-id: 08c5eb0
7 years ago
ORIG_SHELL_BUILD_MODE = $(BUILD_MODE)
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
# override this for faster builds (but slower infer)
BUILD_MODE ?= opt
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
MAKE_SOURCE = $(MAKE) -C $(SRC_DIR)
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
[make] s/ocamlbuild/jbuilder/g Summary: Use jbuilder to build infer instead of ocamlbuild. This is mainly to get faster builds: ``` times in 10ms, ±differences measured in speedups, 4 cores | | ocb total | jb | ±total | ocb user | jb | ±user | ocb cpu | jb | ±cpu | ocb sys | jb | ±sys | |-----------------------------------+-----------+------+--------+----------+------+-------+---------+-----+------+---------+------+------| | byte from scratch | 6428 | 2456 | 2.62 | 7743 | 6662 | 1.16 | 138 | 331 | 2.40 | 1184 | 1477 | 0.80 | | native from scratch | 9841 | 4289 | 2.29 | 9530 | 8834 | 1.08 | 110 | 245 | 2.23 | 1373 | 1712 | 0.80 | | byte after native | 29578 | 1602 | 18.46 | 4514 | 4640 | 0.97 | 170 | 325 | 1.91 | 543 | 576 | 0.94 | | change infer.ml byte | 344 | 282 | 1.22 | 292 | 215 | 1.36 | 96 | 99 | 1.03 | 040 | 066 | 0.61 | | change infer.ml native | 837 | 223 | 3.75 | 789 | 174 | 4.53 | 98 | 99 | 1.01 | 036 | 47 | 0.77 | | change Config.ml byte | 451 | 339 | 1.33 | 382 | 336 | 1.14 | 97 | 122 | 1.26 | 056 | 80 | 0.70 | | change Config.ml native | 4024 | 1760 | 2.29 | 4585 | 4225 | 1.09 | 127 | 276 | 2.17 | 559 | 644 | 0.87 | | change cFrontend_config.ml byte | 348 | 643 | 0.54 | 297 | 330 | 0.90 | 96 | 67 | 0.70 | 038 | 102 | 0.37 | | change cFrontend_config.ml native | 1480 | 584 | 2.53 | 1435 | 906 | 1.58 | 106 | 185 | 1.75 | 136 | 178 | 0.76 | #+TBLFM: $4=$2/$3;f2::$7=$5/$6;f2::$10=$9/$8;f2::$13=$11/$12;f2 50 cores | | ocb total | jb | ±total | ocb user | jb | ±user | ocb cpu | jb | ±cpu | ocb sys | jb | ±sys | |---------------------+-----------+------+--------+----------+------+-------+---------+----+------+---------+------+------| | byte from scratch | 9114 | 2061 | 4.42 | 9334 | 5133 | 1.82 | | | 0/0 | 2566 | 1726 | 1.49 | | native from scratch | 13481 | 3967 | 3.40 | 12291 | 7608 | 1.62 | | | 0/0 | 3003 | 2100 | 1.43 | | byte after native | 3467 | 1476 | 2.35 | 5067 | 3912 | 1.30 | | | 0/0 | 971 | 801 | 1.21 | #+TBLFM: $4=$2/$3;f2::$7=$5/$6;f2::$10=$9/$8;f2::$13=$11/$12;f2 ``` Menu: 1. Write a jbuild file, autogenerated from jbuild.in because we need to fill in some information at build-time (really, at configure time, but TODO), such as whether or not clang is enabled. 2. Nuke lots of stuff from infer/src/Makefile that is now in the jbuild file 3. The jbuild file lives in infer/src/ so it can see all the sources. If we put it somewhere else, eg, infer/, then `jbuilder` scans too many files (all irrelevant) and takes 2.5s to start instead of .8s. Adding irrelevant directories to jbuild-ignore does not help. 4. jbuilder does not support subdirectories, so resort to listing all the source files in the generated jbuild (only source directories need to be manually listed in jbuild.in though). Still, the generated .merlin is wrong and makes merlin find source files in _build, so manually tune it to get good merlin support. We also lose some of merlin for unit tests as it cannot see their build artefacts anymore. 5. checkCopyright gets its own jbuild because it's standalone. Also, remove some deprecation warnings in checkCopyright due to the new version of Core from a while ago. 6. Drop less-used Makefile features (they had regressed anyway) such as building individual modules. Also, building mod_dep.pdf now takes all the source files available so they better build (before, it would only take the source files from the config, eg with or without clang) (that's pretty minor). 7. The toplevel is now built as a custom toplevel because that was easier. It should soon be even easier: https://github.com/janestreet/jbuilder/issues/210 8. Move BUILTINS.mli to BUILTINS.ml because jbuilder is not happy about interface files without implementations. In particular, I did not try to migrate too much of the Makefile logic to jbuilder, more can be done in the future. Reviewed By: jberdine Differential Revision: D5573661 fbshipit-source-id: 4ca6d8f
7 years ago
ifneq ($(UTOP),no)
[make] fix toplevel Summary: I needed it for debugging but, to my dismay, it was borked again. This time it was because `jbuilder` moved the object files to another directory since the last jbuilder update. Reviewed By: mbouaziz Differential Revision: D7926267 fbshipit-source-id: 42ad26a
7 years ago
BUILD_SYSTEMS_TESTS += infertop
[make] s/ocamlbuild/jbuilder/g Summary: Use jbuilder to build infer instead of ocamlbuild. This is mainly to get faster builds: ``` times in 10ms, ±differences measured in speedups, 4 cores | | ocb total | jb | ±total | ocb user | jb | ±user | ocb cpu | jb | ±cpu | ocb sys | jb | ±sys | |-----------------------------------+-----------+------+--------+----------+------+-------+---------+-----+------+---------+------+------| | byte from scratch | 6428 | 2456 | 2.62 | 7743 | 6662 | 1.16 | 138 | 331 | 2.40 | 1184 | 1477 | 0.80 | | native from scratch | 9841 | 4289 | 2.29 | 9530 | 8834 | 1.08 | 110 | 245 | 2.23 | 1373 | 1712 | 0.80 | | byte after native | 29578 | 1602 | 18.46 | 4514 | 4640 | 0.97 | 170 | 325 | 1.91 | 543 | 576 | 0.94 | | change infer.ml byte | 344 | 282 | 1.22 | 292 | 215 | 1.36 | 96 | 99 | 1.03 | 040 | 066 | 0.61 | | change infer.ml native | 837 | 223 | 3.75 | 789 | 174 | 4.53 | 98 | 99 | 1.01 | 036 | 47 | 0.77 | | change Config.ml byte | 451 | 339 | 1.33 | 382 | 336 | 1.14 | 97 | 122 | 1.26 | 056 | 80 | 0.70 | | change Config.ml native | 4024 | 1760 | 2.29 | 4585 | 4225 | 1.09 | 127 | 276 | 2.17 | 559 | 644 | 0.87 | | change cFrontend_config.ml byte | 348 | 643 | 0.54 | 297 | 330 | 0.90 | 96 | 67 | 0.70 | 038 | 102 | 0.37 | | change cFrontend_config.ml native | 1480 | 584 | 2.53 | 1435 | 906 | 1.58 | 106 | 185 | 1.75 | 136 | 178 | 0.76 | #+TBLFM: $4=$2/$3;f2::$7=$5/$6;f2::$10=$9/$8;f2::$13=$11/$12;f2 50 cores | | ocb total | jb | ±total | ocb user | jb | ±user | ocb cpu | jb | ±cpu | ocb sys | jb | ±sys | |---------------------+-----------+------+--------+----------+------+-------+---------+----+------+---------+------+------| | byte from scratch | 9114 | 2061 | 4.42 | 9334 | 5133 | 1.82 | | | 0/0 | 2566 | 1726 | 1.49 | | native from scratch | 13481 | 3967 | 3.40 | 12291 | 7608 | 1.62 | | | 0/0 | 3003 | 2100 | 1.43 | | byte after native | 3467 | 1476 | 2.35 | 5067 | 3912 | 1.30 | | | 0/0 | 971 | 801 | 1.21 | #+TBLFM: $4=$2/$3;f2::$7=$5/$6;f2::$10=$9/$8;f2::$13=$11/$12;f2 ``` Menu: 1. Write a jbuild file, autogenerated from jbuild.in because we need to fill in some information at build-time (really, at configure time, but TODO), such as whether or not clang is enabled. 2. Nuke lots of stuff from infer/src/Makefile that is now in the jbuild file 3. The jbuild file lives in infer/src/ so it can see all the sources. If we put it somewhere else, eg, infer/, then `jbuilder` scans too many files (all irrelevant) and takes 2.5s to start instead of .8s. Adding irrelevant directories to jbuild-ignore does not help. 4. jbuilder does not support subdirectories, so resort to listing all the source files in the generated jbuild (only source directories need to be manually listed in jbuild.in though). Still, the generated .merlin is wrong and makes merlin find source files in _build, so manually tune it to get good merlin support. We also lose some of merlin for unit tests as it cannot see their build artefacts anymore. 5. checkCopyright gets its own jbuild because it's standalone. Also, remove some deprecation warnings in checkCopyright due to the new version of Core from a while ago. 6. Drop less-used Makefile features (they had regressed anyway) such as building individual modules. Also, building mod_dep.pdf now takes all the source files available so they better build (before, it would only take the source files from the config, eg with or without clang) (that's pretty minor). 7. The toplevel is now built as a custom toplevel because that was easier. It should soon be even easier: https://github.com/janestreet/jbuilder/issues/210 8. Move BUILTINS.mli to BUILTINS.ml because jbuilder is not happy about interface files without implementations. In particular, I did not try to migrate too much of the Makefile logic to jbuilder, more can be done in the future. Reviewed By: jberdine Differential Revision: D5573661 fbshipit-source-id: 4ca6d8f
7 years ago
endif
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
ifeq ($(BUILD_C_ANALYZERS),yes)
BUILD_SYSTEMS_TESTS += \
[annot reachability] add debug logging and light refactor Summary: - run the tests! they weren't hooked up to the main Makefile :/ - add some html debug messages - formatting Reviewed By: skcho Differential Revision: D16895578 fbshipit-source-id: e96d737cc
5 years ago
annotation-reachability-sources-override \
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
assembly \
[infer] Fix filename to relative Reviewed By: jvillard Differential Revision: D13552198 fbshipit-source-id: b9be4dd2e
6 years ago
backtrack_level \
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
ck_analytics ck_imports \
[clangdb] support shell-escaped compilation databases Summary: Xcode's compilation databases follows a different convention than cmake's and escape the `"file"` and `"dir"` fields of each unit to make them shell-ready. We need to treat them differently when reading them. This adds a new `--clang-compilation-db-files-escaped` option and makes the code related to reading compilation databases deal correctly with both conventions. Reviewed By: akotulski Differential Revision: D4559239 fbshipit-source-id: 51120ae
8 years ago
clang_compilation_db_escaped clang_compilation_db_relpath \
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
clang_multiple_files \
clang_translation \
clang_unknown_ext \
[clang] do not error on bogus arguments to `fsanitize` Summary: Simpler approach than having to look into argfiles Reviewed By: mbouaziz Differential Revision: D6546388 fbshipit-source-id: 3d08001
7 years ago
clang_with_blacklisted_flags \
[clang capture] Don't attach plugin when clang is invoked in preprocessor mode Summary: There is no point in attaching plugin to `clang -E` calls since they don't produce any AST. Same applies to `-M`, `-MM`, etc. (but not `-MD` nor `-MMD`). Reviewed By: jvillard Differential Revision: D4681618 fbshipit-source-id: 7a76add
8 years ago
clang_with_E_flag \
clang_with_M_flag \
clang_with_MD_flag \
[inferprint] fix template deduplication Reviewed By: jeremydubreil Differential Revision: D6024848 fbshipit-source-id: 8223fcd
7 years ago
deduplicate_template_warnings \
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
delete_results_dir \
[proc-cfg][2/5] fix duplicate symbols detection Summary: Fix the logic for computing duplicate symbols. It was broken at some point and some duplicate symbols creeped into our tests. Fix these, and add a test to avoid duplicate symbols detection to regress again. Also, this removes one use of `Cfg.load`, on the way to removing file-wide CFGs from the database. Reviewed By: ngorogiannis Differential Revision: D10173349 fbshipit-source-id: a0d2365b3
6 years ago
duplicate_symbols \
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
fail_on_issue \
j1 \
linters \
project_root_rel \
reactive \
run_hidden_linters \
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
tracebugs \
[test] make tests pass in clang-only or java-only mode Summary: This is useful to make sure `./build-infer.sh clang` and `./build-infer.sh java` work correctly. I had to move one unit test inside a new unit/clang/ directory used only if clang is enabled, and create a stub for it in unit/clang_stubs/ for when clang is disabled. Renamed `OCAML_SOURCES` to the more consistent and descriptive `OCAML_CONFIG_SOURCES`. Reviewed By: jeremydubreil Differential Revision: D4571997 fbshipit-source-id: 9502114
8 years ago
utf8_in_procname \
New faster version of Diff/Test-Determinator Reviewed By: jvillard Differential Revision: D15876508 fbshipit-source-id: f5d407025
5 years ago
export_changed_functions \
Add test incremental_analysis_remove_file to the toplevel makefile Summary: Add test `incremental_analysis_remove_file` to the toplevel makefile so that it is called by `make test` etc Also swapped the src_before and src_after files so the test checks file removal instead of addition. Reviewed By: jvillard Differential Revision: D16562340 fbshipit-source-id: 79bab5f66
5 years ago
incremental_analysis_remove_file \
Add incremental analysis test for changing a file Summary: Write a test for the invalidation of changed procedures Reverse analysis graph for this test: https://fburl.com/graphviz/ybidpidq The procedures marked as changed are `a` and `d`, and this causes `a,b,c,d,e,main` to be invalidated as expected Reviewed By: jvillard Differential Revision: D16579526 fbshipit-source-id: cbec304ce
5 years ago
incremental_analysis_change_procedure \
hook in incremental analysis add procedure test Summary: Adding a test to the top level makefile that I forgot to add (ooops) Reviewed By: jvillard Differential Revision: D17366065 fbshipit-source-id: 8111ccf7a
5 years ago
incremental_analysis_add_procedure \
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
DIRECT_TESTS += \
[pulse] initial commit Summary: New analysis in foetal form to detect invalid use of C++ objects after their lifetime has ended. For now it has: - A domain consisting of a graph of abstract locations representing the heap, a map from program variables to abstract locations representing the stack, and a set of locations known to be invalid (their lifetime has ended) - The heap graph is unfolded lazily when we resolve accesses to the heap down to an abstract location. When we traverse a memory location we check that it's not known to be invalid. - A simple transfer function reads and updates the stack and heap in a rudimentary way for now - C++ `delete` is modeled as adding the location that its argument resolves to to the set of invalid locations - Also, the domain has a really crappy join and widening for now (see comments in the code) With this we already pass most of the "use after delete" tests from the Ownership checker. The ones we don't pass are only because we are missing models. Reviewed By: mbouaziz Differential Revision: D10383249 fbshipit-source-id: f414664cb
6 years ago
c_biabduction \
c_bufferoverrun \
c_frontend \
c_performance \
[pulse] Add model for malloc Summary: Adding a model for malloc: we add an attribute "Allocated". This can be used for implementing memory leaks: whenever the variables get out of scope, we can check that if the variable has an attribute Allocated, it also has an attribute Invalid CFree. Possibly we will need more details in the Allocated attribute, to know if it's malloc, or other allocation function, but we can add that later when we know how it should look like. Reviewed By: jvillard Differential Revision: D20364541 fbshipit-source-id: 5e667a8c3
5 years ago
c_pulse \
[purity] Enable Clang in purity analysis Reviewed By: mbouaziz Differential Revision: D14437821 fbshipit-source-id: 4b5f761b2
6 years ago
c_purity \
[pulse] initial commit Summary: New analysis in foetal form to detect invalid use of C++ objects after their lifetime has ended. For now it has: - A domain consisting of a graph of abstract locations representing the heap, a map from program variables to abstract locations representing the stack, and a set of locations known to be invalid (their lifetime has ended) - The heap graph is unfolded lazily when we resolve accesses to the heap down to an abstract location. When we traverse a memory location we check that it's not known to be invalid. - A simple transfer function reads and updates the stack and heap in a rudimentary way for now - C++ `delete` is modeled as adding the location that its argument resolves to to the set of invalid locations - Also, the domain has a really crappy join and widening for now (see comments in the code) With this we already pass most of the "use after delete" tests from the Ownership checker. The ones we don't pass are only because we are missing models. Reviewed By: mbouaziz Differential Revision: D10383249 fbshipit-source-id: f414664cb
6 years ago
c_uninit \
[annot reachability] add debug logging and light refactor Summary: - run the tests! they weren't hooked up to the main Makefile :/ - add some html debug messages - formatting Reviewed By: skcho Differential Revision: D16895578 fbshipit-source-id: e96d737cc
5 years ago
cpp_annotation-reachability \
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
cpp_biabduction \
[pulse] initial commit Summary: New analysis in foetal form to detect invalid use of C++ objects after their lifetime has ended. For now it has: - A domain consisting of a graph of abstract locations representing the heap, a map from program variables to abstract locations representing the stack, and a set of locations known to be invalid (their lifetime has ended) - The heap graph is unfolded lazily when we resolve accesses to the heap down to an abstract location. When we traverse a memory location we check that it's not known to be invalid. - A simple transfer function reads and updates the stack and heap in a rudimentary way for now - C++ `delete` is modeled as adding the location that its argument resolves to to the set of invalid locations - Also, the domain has a really crappy join and widening for now (see comments in the code) With this we already pass most of the "use after delete" tests from the Ownership checker. The ones we don't pass are only because we are missing models. Reviewed By: mbouaziz Differential Revision: D10383249 fbshipit-source-id: f414664cb
6 years ago
cpp_bufferoverrun \
cpp_conflicts \
cpp_frontend \
[pulse][impurity] Use pulse for detecting impurity Summary: Introduce a new experimental checker (`--impurity`) that detects impurity information, tracking which parameters and global variables of a function are modified. The checker relies on Pulse to detect how the state changes: it traverses the pre and post pairs starting from the parameter/global variable and finds where the pre and post heaps diverge. At diversion points, we expect to see WrittenTo/Invalid attributes containing a trace of how the address was modified. We use these to construct the trace of impurity. This checker is a complement to the purity checker that exists mainly for Java (and used for cost and loop-hoisting analyses). The aim of this new experimental checker is to rely on Pulse's precise memory treatment and come up with a more precise im(purity) analysis. To distinguish the two checkers, we introduce a new issue type `IMPURE_FUNCTION` that reports when a function is impure, rather than when it is pure (as in the purity checker). TODO: - improve the analysis to rely on impurity information of external library calls. Currently, all library calls are assumed to be nops, hence pure. - de-entangle Pulse reporting from analysis. Reviewed By: skcho Differential Revision: D17051567 fbshipit-source-id: 5e10afb4f
5 years ago
cpp_impurity \
delete ownership checker Summary: Replaced by pulse. `--ownership` is now a deprecated form of `--pulse`. The ownership checker is starting to give wrong answers due to changes in the clang frontend, so it's better to remove it in favour of pulse. there_goes_my_hero Reviewed By: ngorogiannis Differential Revision: D16107650 fbshipit-source-id: bb2446a19
5 years ago
cpp_linters \
[pulse] initial commit Summary: New analysis in foetal form to detect invalid use of C++ objects after their lifetime has ended. For now it has: - A domain consisting of a graph of abstract locations representing the heap, a map from program variables to abstract locations representing the stack, and a set of locations known to be invalid (their lifetime has ended) - The heap graph is unfolded lazily when we resolve accesses to the heap down to an abstract location. When we traverse a memory location we check that it's not known to be invalid. - A simple transfer function reads and updates the stack and heap in a rudimentary way for now - C++ `delete` is modeled as adding the location that its argument resolves to to the set of invalid locations - Also, the domain has a really crappy join and widening for now (see comments in the code) With this we already pass most of the "use after delete" tests from the Ownership checker. The ones we don't pass are only because we are missing models. Reviewed By: mbouaziz Differential Revision: D10383249 fbshipit-source-id: f414664cb
6 years ago
cpp_linters-for-test-only \
cpp_liveness \
delete ownership checker Summary: Replaced by pulse. `--ownership` is now a deprecated form of `--pulse`. The ownership checker is starting to give wrong answers due to changes in the clang frontend, so it's better to remove it in favour of pulse. there_goes_my_hero Reviewed By: ngorogiannis Differential Revision: D16107650 fbshipit-source-id: bb2446a19
5 years ago
cpp_pulse \
[quandaryBO] delete :( Summary: This was never quite finished and inferbo has a new way to do sort of the same thing. Reviewed By: skcho, ngorogiannis Differential Revision: D20362619 fbshipit-source-id: 7c7935d47
5 years ago
cpp_quandary \
[pulse] initial commit Summary: New analysis in foetal form to detect invalid use of C++ objects after their lifetime has ended. For now it has: - A domain consisting of a graph of abstract locations representing the heap, a map from program variables to abstract locations representing the stack, and a set of locations known to be invalid (their lifetime has ended) - The heap graph is unfolded lazily when we resolve accesses to the heap down to an abstract location. When we traverse a memory location we check that it's not known to be invalid. - A simple transfer function reads and updates the stack and heap in a rudimentary way for now - C++ `delete` is modeled as adding the location that its argument resolves to to the set of invalid locations - Also, the domain has a really crappy join and widening for now (see comments in the code) With this we already pass most of the "use after delete" tests from the Ownership checker. The ones we don't pass are only because we are missing models. Reviewed By: mbouaziz Differential Revision: D10383249 fbshipit-source-id: f414664cb
6 years ago
cpp_racerd \
cpp_siof \
delete ownership checker Summary: Replaced by pulse. `--ownership` is now a deprecated form of `--pulse`. The ownership checker is starting to give wrong answers due to changes in the clang frontend, so it's better to remove it in favour of pulse. there_goes_my_hero Reviewed By: ngorogiannis Differential Revision: D16107650 fbshipit-source-id: bb2446a19
5 years ago
cpp_starvation \
[pulse] initial commit Summary: New analysis in foetal form to detect invalid use of C++ objects after their lifetime has ended. For now it has: - A domain consisting of a graph of abstract locations representing the heap, a map from program variables to abstract locations representing the stack, and a set of locations known to be invalid (their lifetime has ended) - The heap graph is unfolded lazily when we resolve accesses to the heap down to an abstract location. When we traverse a memory location we check that it's not known to be invalid. - A simple transfer function reads and updates the stack and heap in a rudimentary way for now - C++ `delete` is modeled as adding the location that its argument resolves to to the set of invalid locations - Also, the domain has a really crappy join and widening for now (see comments in the code) With this we already pass most of the "use after delete" tests from the Ownership checker. The ones we don't pass are only because we are missing models. Reviewed By: mbouaziz Differential Revision: D10383249 fbshipit-source-id: f414664cb
6 years ago
cpp_uninit \
[java] Add support for openjdk11 Reviewed By: jeremydubreil Differential Revision: D14323194 fbshipit-source-id: afa532c23
6 years ago
[inferbo] Add taint domain Summary: This diff adds a taint domain in Inferbo. The taint value will be used to find vulnerable array accesses in the following diffs. Reviewed By: ezgicicek Differential Revision: D19391028 fbshipit-source-id: 566b4c0fe
5 years ago
ifeq ($(IS_FACEBOOK_TREE),yes)
DIRECT_TESTS += cpp_fb-taint
endif
[bufferoverrun][tests] Move bufferoverrun cpp tests to their own directory Summary: `bufferoverrun` is not part of `checkers` yet so bufferoverrun tests require their own Makefile Reviewed By: jvillard Differential Revision: D4937558 fbshipit-source-id: 20380f1
8 years ago
[buck-db] add flavour more robustly Summary: Two issues in the previous code: 1. We'd just tack on `#compilation-database` so if there already are `#flavors` in a Buck target then we get a malformed `#flavors#compilation-database` instead of `#flavors,compilation-database`. There's already code to deal with that for other flavors (`#infer-capture-all`), so extend and reuse that. 2. The code didn't work if there are spaces in target names (sigh). Harden the code a bit so that it works. Unfortunately Buck doesn't escape spaces at all in its `buck targets --show-output` output, so the parsing still relies on there being no spaces in flavors to work correctly. Sample output: ``` $ buck targets --show-full-output //clang_compilation_database:Hel\ lo#compilation-database Not using buckd because watchman isn't installed. [+] PROCESSING BUCK FILES...0.1s [100%] 🐳 New buck daemon //clang_compilation_database:Hel lo#compilation-database /home/jul/infer/infer/tests/build_systems/codetoanalyze/buck-out/gen/clang_compilation_database/__Hel lo#compilation-database.json ``` Also, some code in codetoanalyze/clang-compilation-database/ didn't compile, so fix that. Reviewed By: dulmarod Differential Revision: D4714338 fbshipit-source-id: b8ae324
8 years ago
ifneq ($(BUCK),no)
Fix test buck_flavours_diff Summary: This test wasn't building correctly or being called by the toplevel makefile Reviewed By: jvillard Differential Revision: D16458386 fbshipit-source-id: 48a0c2f36
5 years ago
BUILD_SYSTEMS_TESTS += \
buck_blacklist \
buck-clang-db \
[test determinator] Merge test determinator results under buck capture all flavours, add test Reviewed By: skcho Differential Revision: D18039141 fbshipit-source-id: 3faef0615
5 years ago
buck_clang_test_determinator \
Fix test buck_flavours_diff Summary: This test wasn't building correctly or being called by the toplevel makefile Reviewed By: jvillard Differential Revision: D16458386 fbshipit-source-id: 48a0c2f36
5 years ago
buck_flavors \
buck_flavors_diff \
buck_flavors_run \
buck_flavors_deterministic \
Add test incremental_analysis_remove_file to the toplevel makefile Summary: Add test `incremental_analysis_remove_file` to the toplevel makefile so that it is called by `make test` etc Also swapped the src_before and src_after files so the test checks file removal instead of addition. Reviewed By: jvillard Differential Revision: D16562340 fbshipit-source-id: 79bab5f66
5 years ago
buck_export_changed_functions \
Fix test buck_flavours_diff Summary: This test wasn't building correctly or being called by the toplevel makefile Reviewed By: jvillard Differential Revision: D16458386 fbshipit-source-id: 48a0c2f36
5 years ago
[buck-db] add flavour more robustly Summary: Two issues in the previous code: 1. We'd just tack on `#compilation-database` so if there already are `#flavors` in a Buck target then we get a malformed `#flavors#compilation-database` instead of `#flavors,compilation-database`. There's already code to deal with that for other flavors (`#infer-capture-all`), so extend and reuse that. 2. The code didn't work if there are spaces in target names (sigh). Harden the code a bit so that it works. Unfortunately Buck doesn't escape spaces at all in its `buck targets --show-output` output, so the parsing still relies on there being no spaces in flavors to work correctly. Sample output: ``` $ buck targets --show-full-output //clang_compilation_database:Hel\ lo#compilation-database Not using buckd because watchman isn't installed. [+] PROCESSING BUCK FILES...0.1s [100%] 🐳 New buck daemon //clang_compilation_database:Hel lo#compilation-database /home/jul/infer/infer/tests/build_systems/codetoanalyze/buck-out/gen/clang_compilation_database/__Hel lo#compilation-database.json ``` Also, some code in codetoanalyze/clang-compilation-database/ didn't compile, so fix that. Reviewed By: dulmarod Differential Revision: D4714338 fbshipit-source-id: b8ae324
8 years ago
endif
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
ifneq ($(CMAKE),no)
Allow ints for int options in .inferconfig Reviewed By: jvillard Differential Revision: D10861323 fbshipit-source-id: 78453ff9f
6 years ago
BUILD_SYSTEMS_TESTS += clang_compilation_db cmake inferconfig inferconfig_not_strict
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
endif
ifneq ($(NDKBUILD),no)
BUILD_SYSTEMS_TESTS += ndk_build
endif
Decouple objc tests from xcode-select Reviewed By: jvillard Differential Revision: D9359621 fbshipit-source-id: e490dac4a
6 years ago
ifeq ($(HAS_OBJC),yes)
[make] do not run clang_test_determinator tests if no objc Summary: The test requires objc and won't run on Linux. Reviewed By: ngorogiannis Differential Revision: D19164588 fbshipit-source-id: b92f4302f
5 years ago
BUILD_SYSTEMS_TESTS += \
clang_test_determinator \
objc_getters_setters \
objc_missing_fld \
objc_retain_cycles \
objc_retain_cycles_weak
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
DIRECT_TESTS += \
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
objc_biabduction \
[objc] make quandary test run Summary: That test wasn't hooked up to `make test` and so regressed at some unknown time in the past. Just recording the new state of things for now. Reviewed By: ngorogiannis Differential Revision: D15495234 fbshipit-source-id: 14fb112de
6 years ago
objc_frontend \
objc_ioslints \
objc_linters \
objc_linters-def-folder \
objc_linters-for-test-only \
objc_liveness \
objc_performance \
[pulse] Add pulse tests for objective-c (the c part of it) Reviewed By: ngorogiannis Differential Revision: D17183375 fbshipit-source-id: 0ecdf2072
5 years ago
objc_pulse \
[objc] make quandary test run Summary: That test wasn't hooked up to `make test` and so regressed at some unknown time in the past. Just recording the new state of things for now. Reviewed By: ngorogiannis Differential Revision: D15495234 fbshipit-source-id: 14fb112de
6 years ago
objc_quandary \
[self in block] Add a new checker to detect correct uses of when ObjC blocks capture self. Reviewed By: skcho Differential Revision: D18245267 fbshipit-source-id: 6e3f1a7f7
5 years ago
objc_self-in-block \
[objc] make quandary test run Summary: That test wasn't hooked up to `make test` and so regressed at some unknown time in the past. Just recording the new state of things for now. Reviewed By: ngorogiannis Differential Revision: D15495234 fbshipit-source-id: 14fb112de
6 years ago
objc_uninit \
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
objcpp_biabduction \
[objc] make quandary test run Summary: That test wasn't hooked up to `make test` and so regressed at some unknown time in the past. Just recording the new state of things for now. Reviewed By: ngorogiannis Differential Revision: D15495234 fbshipit-source-id: 14fb112de
6 years ago
objcpp_frontend \
objcpp_linters \
objcpp_linters-for-test-only \
objcpp_liveness \
[objc] pass SDK config to plugin Summary: This makes the plugin follow infer's configuration. Reviewed By: martintrojer Differential Revision: D18595972 fbshipit-source-id: f685dd057
5 years ago
objcpp_pulse \
[objc] make quandary test run Summary: That test wasn't hooked up to `make test` and so regressed at some unknown time in the past. Just recording the new state of things for now. Reviewed By: ngorogiannis Differential Revision: D15495234 fbshipit-source-id: 14fb112de
6 years ago
objcpp_racerd \
objcpp_retain-cycles \
Added more allocation primitives Reviewed By: mbouaziz Differential Revision: D14385870 fbshipit-source-id: 7e3ef32bf
6 years ago
Decouple objc tests from xcode-select Reviewed By: jvillard Differential Revision: D9359621 fbshipit-source-id: e490dac4a
6 years ago
ifneq ($(XCODE_SELECT),no)
BUILD_SYSTEMS_TESTS += xcodebuild_no_xcpretty
endif
[ios] Fix xcodebuild integration with xcpretty, add test. Reviewed By: jvillard Differential Revision: D4572057 fbshipit-source-id: 0d20370
8 years ago
ifneq ($(XCPRETTY),no)
BUILD_SYSTEMS_TESTS += xcodebuild
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
endif
Decouple objc tests from xcode-select Reviewed By: jvillard Differential Revision: D9359621 fbshipit-source-id: e490dac4a
6 years ago
endif # HAS_OBJC
[ios] Fix xcodebuild integration with xcpretty, add test. Reviewed By: jvillard Differential Revision: D4572057 fbshipit-source-id: 0d20370
8 years ago
endif # BUILD_C_ANALYZERS
[tests] enable tests based on which analyzers are enabled Summary: One step on the way to being able to test java/clang separately. Reviewed By: akotulski Differential Revision: D4558948 fbshipit-source-id: c0c7556
8 years ago
ifeq ($(BUILD_JAVA_ANALYZERS),yes)
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
BUILD_SYSTEMS_TESTS += \
[annot reachability] add debug logging and light refactor Summary: - run the tests! they weren't hooked up to the main Makefile :/ - add some html debug messages - formatting Reviewed By: skcho Differential Revision: D16895578 fbshipit-source-id: e96d737cc
5 years ago
differential_interesting_paths_filter \
[Perf] Perform comparisons of costs-reports by using costs-report.json files Reviewed By: ezgicicek, mbouaziz Differential Revision: D9634617 fbshipit-source-id: 6d349ce40
6 years ago
differential_of_costs_report \
Add test for cost change detection with incremental analysis Summary: Test that cost analysis works with incremental analysis enabled Reviewed By: ezgicicek Differential Revision: D16620101 fbshipit-source-id: b41403954
5 years ago
incremental_analysis_cost_change \
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
differential_skip_anonymous_class_renamings \
differential_skip_duplicated_types_on_filenames \
differential_skip_duplicated_types_on_filenames_with_renamings \
gradle \
[annot reachability] add debug logging and light refactor Summary: - run the tests! they weren't hooked up to the main Makefile :/ - add some html debug messages - formatting Reviewed By: skcho Differential Revision: D16895578 fbshipit-source-id: e96d737cc
5 years ago
java_test_determinator \
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
javac \
[Infer] Emit potential exception lines into qualifier's message Summary: Sometimes reports need traces to be fully understood, but sometimes reporting where the exception takes place can save time to developers. Reviewed By: jvillard Differential Revision: D4914037 fbshipit-source-id: 039ab63
8 years ago
resource_leak_exception_lines \
[annot reachability] add debug logging and light refactor Summary: - run the tests! they weren't hooked up to the main Makefile :/ - add some html debug messages - formatting Reviewed By: skcho Differential Revision: D16895578 fbshipit-source-id: e96d737cc
5 years ago
racerd_dedup
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
[java] Add support for openjdk11 Reviewed By: jeremydubreil Differential Revision: D14323194 fbshipit-source-id: afa532c23
6 years ago
#TODO T41549034: Jdk11 translates string append differently, causing
#test failures in NullPointerExceptions:stringVarEqualsFalseNPE
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
DIRECT_TESTS += \
[annot reachability] add debug logging and light refactor Summary: - run the tests! they weren't hooked up to the main Makefile :/ - add some html debug messages - formatting Reviewed By: skcho Differential Revision: D16895578 fbshipit-source-id: e96d737cc
5 years ago
java_annotreach \
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
java_biabduction \
Makefile: run inferbo java tests Reviewed By: skcho Differential Revision: D13114223 fbshipit-source-id: 8bd1b9da0
6 years ago
java_bufferoverrun \
[inferbo] Fix check of access condition Reviewed By: mbouaziz Differential Revision: D13114160 fbshipit-source-id: 9e46cf814
6 years ago
java_checkers \
java_classloads \
[nullsafe] move tests nullsafe-default/ -> nullsafe/ Summary: The directory was created to have several sets of nullsafe tests but there is only one in the end. Remove the redundant "-default". Reviewed By: mityal Differential Revision: D21300205 fbshipit-source-id: 46ed8b032
5 years ago
java_nullsafe \
[inferbo] Fix check of access condition Reviewed By: mbouaziz Differential Revision: D13114160 fbshipit-source-id: 9e46cf814
6 years ago
java_hoisting \
java_hoistingExpensive \
[impurity] Add initial Java support and don't run pulse twice Summary: Let's add basic Java support to impurity checker. Since impurity checker relies on pulse, we need to add Java with Pulse callback as well. Pulse doesn't officially support Java yet, but we can enable it for impurity checker for now. Many Java primitives/operations are not yet modeled (such as creation of new objects, support for collections etc.). Still, it is good to run impurity checker on the existing tests of the purity checker. Also, it is nice to see that we can identify most of the impure functions correctly in the purity dir. There are a lot of FNs though. Reviewed By: skcho Differential Revision: D17906237 fbshipit-source-id: 15308d285
5 years ago
java_impurity \
[inefficient-keyset-iterator] New checker for finding inefficient keySet iterator Summary: This is a simple checker that identifies inefficient uses of `keySet` iterator where (not only the key but also) the value is accessed via `get(key)`. It is more efficient to use `entrySet` iterator which already returns both key-value pairs. This optimization would get rid of many extra lookups which can be expensive. We simply traverse the CFG starting from the loop head upwards and pick up the map that is iterated over. Then, we check in the loop nodes if there is a call to `get(...)` over this map. If, so we report. Reviewed By: ngorogiannis Differential Revision: D15737779 fbshipit-source-id: 702465b4e
6 years ago
java_inefficientKeysetIterator \
[litho] Add new tests for new litho domain Reviewed By: skcho Differential Revision: D18851068 fbshipit-source-id: b34840a63
5 years ago
java_litho-required-props \
[inferbo] Fix check of access condition Reviewed By: mbouaziz Differential Revision: D13114160 fbshipit-source-id: 9e46cf814
6 years ago
java_performance \
[cost] add a mode to compute exclusive cost Summary: Add a flag `is-inclusive-cost` (`true` by default) which computes inclusive cost for each function. Setting the flag to `false` computes exclusive cost of the function where the cost of the callees are assumed to be `0`. Reviewed By: skcho Differential Revision: D20558275 fbshipit-source-id: 6b5798916
5 years ago
java_performance-exclusive \
[pulse] add Java tests Summary: Start with tests about dynamic dispatch to test the upcoming pre-analysis. Reviewed By: ezgicicek Differential Revision: D21594496 fbshipit-source-id: 1771ea968
5 years ago
java_pulse \
[inferbo] Fix check of access condition Reviewed By: mbouaziz Differential Revision: D13114160 fbshipit-source-id: 9e46cf814
6 years ago
java_purity \
java_quandary \
java_racerd \
java_starvation \
[starvation] enable some tests Summary: Dedup and whole-program tests were disabled by mistake. Reviewed By: dulmarod Differential Revision: D18572858 fbshipit-source-id: 7fe1633b8
5 years ago
java_starvation-dedup \
java_starvation-whole-program \
[topl] Parser for temporal properties Summary: TOPL properties are essentially automata, which specify a bad pattern. This commit is just a parser for them. Reviewed By: jvillard Differential Revision: D14477671 fbshipit-source-id: c38a8ef37
6 years ago
java_topl \
[inferbo] Fix check of access condition Reviewed By: mbouaziz Differential Revision: D13114160 fbshipit-source-id: 9e46cf814
6 years ago
[cost] Add FB-specific cost models Summary: This diff adds some FB-specific cost models. Reviewed By: ezgicicek Differential Revision: D17787903 fbshipit-source-id: cc49fad83
5 years ago
ifeq ($(IS_FACEBOOK_TREE),yes)
DIRECT_TESTS += java_fb-performance
endif
[build tests] migrate buck integration test to Makefiles Summary: Only run the buck (and ant) tests if the tools can be found at ./configure-time. Reviewed By: jberdine Differential Revision: D4167586 fbshipit-source-id: e77b736
8 years ago
ifneq ($(ANT),no)
BUILD_SYSTEMS_TESTS += ant
endif
[java] Add support for openjdk11 Reviewed By: jeremydubreil Differential Revision: D14323194 fbshipit-source-id: afa532c23
6 years ago
[build tests] migrate buck integration test to Makefiles Summary: Only run the buck (and ant) tests if the tools can be found at ./configure-time. Reviewed By: jberdine Differential Revision: D4167586 fbshipit-source-id: e77b736
8 years ago
ifneq ($(BUCK),no)
[tests] remove genrule test Summary: This is fragile and redundant. Reviewed By: ezgicicek Differential Revision: D20249041 fbshipit-source-id: fc22bc0fb
5 years ago
BUILD_SYSTEMS_TESTS += genrulecapture
[build tests] migrate buck integration test to Makefiles Summary: Only run the buck (and ant) tests if the tools can be found at ./configure-time. Reviewed By: jberdine Differential Revision: D4167586 fbshipit-source-id: e77b736
8 years ago
endif
[mvn] new integration Summary: This replaces the previous integration written in Python, which consisted in 1) run the mvn command and parse its output to locate "directories containing source files", 2) run on files named "*.java" in these directories. This meant we had to run javac twice on each source file, and more importantly this mechanism of finding source files was very fragile. In fact, I could not make it work on several mvn projects I tried. The new integration is based on parsing "pom.xml" to add an "infer-capture" profile which instructs mvn to run `/path/to/infer` instead of `javac`. We also add this profile to each maven submodule. Users can specify an "infer-capture" profile themselves if the default one doesn't work; in that case we don't inject our own "infer-capture" profile. Reviewed By: jeremydubreil Differential Revision: D4409613 fbshipit-source-id: d664274
8 years ago
ifneq ($(MVN),no)
BUILD_SYSTEMS_TESTS += mvn
endif
[tests] convert pmd-xml test to Makefile Reviewed By: jberdine Differential Revision: D4329648 fbshipit-source-id: c4bb17a
8 years ago
endif
[tests] convert ant integration test to a Makefile Summary: Time for this framework to die. This converts the ant test to a Makefile. The design is that each test or family of tests will have its own directory. Do the necessary plumbing from the toplevel Makefile so that `make test` runs the migrated tests. Reviewed By: jberdine Differential Revision: D4106298 fbshipit-source-id: 7bd694d
8 years ago
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
ifeq ($(BUILD_C_ANALYZERS)+$(BUILD_JAVA_ANALYZERS),yes+yes)
[build] fix clang and java-only tests Summary: The tests wouldn't pass in clang-only or Java-only mode. Reviewed By: mbouaziz Differential Revision: D5498555 fbshipit-source-id: 8e49b8d
7 years ago
BUILD_SYSTEMS_TESTS += make utf8_in_pwd waf
[make] better way of limiting concurrency and better jbuilder concurrency Summary: This gets rid of the horrible hack of asking jbuilder to build _build/{default,test}/.ppx/ppx_compare/ppx.exe prior to starting several jbuilds in parallel. We now refrain from starting several jbuilds in parallel. Also, I finally understood that order-only deps do nothing for phony targets, and not much else for non-phony ones. I hate make even more. Reviewed By: jberdine Differential Revision: D5678699 fbshipit-source-id: 52179e8
7 years ago
endif
add files lost in sync with internal repo
9 years ago
[build] record last modified date of --help data inside ./configure Summary: This will be needed to generate man pages with an accurate date. Reviewed By: jberdine, mbouaziz Differential Revision: D4937498 fbshipit-source-id: b5ebd31
8 years ago
ifeq ($(IS_INFER_RELEASE),no)
[make] make some targets depend on the Makefiles Summary: It's annoying that changing the Makefile or running `./configure` with different options does not always retrigger compilation of some targets, eg infer. Reviewed By: akotulski Differential Revision: D4571988 fbshipit-source-id: dda080f
8 years ago
configure: configure.ac $(wildcard m4/*.m4)
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
# rerun ./autogen.sh in case of failure as the failure may be due to needing to rerun
# ./configure
$(QUIET)($(call silent_on_success,Generate ./configure,./autogen.sh)) || \
[make] make some targets depend on the Makefiles Summary: It's annoying that changing the Makefile or running `./configure` with different options does not always retrigger compilation of some targets, eg infer. Reviewed By: akotulski Differential Revision: D4571988 fbshipit-source-id: dda080f
8 years ago
./autogen.sh
[make] make sure makefile uses config-time values Summary: This makes sure that one can run `./build-infer.sh` then `make`. Otherwise it's not always clear what one should do to recompile infer, eg when `make` will work and when `./build-infer.sh` should be used instead, in particular when the user doesn't have opam configured for her terminal. Reviewed By: jberdine Differential Revision: D4698159 fbshipit-source-id: 5df8059
8 years ago
Makefile.autoconf: configure Makefile.autoconf.in
[make] make some targets depend on the Makefiles Summary: It's annoying that changing the Makefile or running `./configure` with different options does not always retrigger compilation of some targets, eg infer. Reviewed By: akotulski Differential Revision: D4571988 fbshipit-source-id: dda080f
8 years ago
# rerun ./configure with the flags that were used last time it was run (if available)
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
# retry in case of failure as the failure may be due to needing to rerun ./configure
$(QUIET)($(call silent_on_success,Running\
./configure $(shell ./config.status --config || true),\
./configure $(shell ./config.status --config || true))) || \
[build] use `./config.status` Summary: We had our own mechanism for saving `./configure` flags, which does not work if flags contain whitespace. It turns out that `./config.stats --config` is a thing though. Reviewed By: mbouaziz Differential Revision: D4642422 fbshipit-source-id: ae075ca
8 years ago
./configure $(shell ./config.status --config || true)
[build] record last modified date of --help data inside ./configure Summary: This will be needed to generate man pages with an accurate date. Reviewed By: jberdine, mbouaziz Differential Revision: D4937498 fbshipit-source-id: b5ebd31
8 years ago
endif
[make] make some targets depend on the Makefiles Summary: It's annoying that changing the Makefile or running `./configure` with different options does not always retrigger compilation of some targets, eg infer. Reviewed By: akotulski Differential Revision: D4571988 fbshipit-source-id: dda080f
8 years ago
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
.PHONY: fb-setup
fb-setup:
$(QUIET)$(call silent_on_success,Facebook setup,\
$(MAKE) -C facebook setup)
Convert Reason to OCaml, and auto-format OCaml Summary: Conversion and reformat of infer source using ocamlformat auto-formatting tool. Current status: - Because Reason does not handle docstrings, the output of the conversion is not 'Warning 50'-clean, meaning that there are docstrings with ambiguous placement. I'll need to manually fix them just before landing. Reviewed By: jvillard Differential Revision: D5225546 fbshipit-source-id: 3bd2786
7 years ago
.PHONY: fmt
fmt:
[ocamlformat] Support passing args to ocamlformat Summary: Useful for testing / debugging ocamlformat updates Reviewed By: skcho Differential Revision: D21395971 fbshipit-source-id: d4f2f2dcb
5 years ago
parallel $(OCAMLFORMAT_EXE) $(OCAMLFORMAT_ARGS) -i ::: $$(git diff --name-only --diff-filter=ACMRU $$(git merge-base origin/master HEAD) | grep "\.mli\?$$")
[ocamlformat] Use ocamlformat from github Summary: Install ocamlformat from github as part of `make devsetup`, and use it for formatting OCaml (and jbuild) code. Reviewed By: jvillard Differential Revision: D6092464 fbshipit-source-id: 4ba0845
7 years ago
[ocamlformat] Exclude deadcode/dune.in from list of ocaml dune files Summary: infer/src/deadcode/dune.in is not an OCaml-syntax dune file, so exclude it from the list computed for use by the auto-formatter. Reviewed By: jvillard Differential Revision: D21583047 fbshipit-source-id: 13a99a89b
5 years ago
DUNE_ML:=$(shell find * -name 'dune*.in' | grep -v workspace | grep -v infer-source | grep -v infer/src/deadcode/dune.in)
[ocamlformat] Use ocamlformat from github Summary: Install ocamlformat from github as part of `make devsetup`, and use it for formatting OCaml (and jbuild) code. Reviewed By: jvillard Differential Revision: D6092464 fbshipit-source-id: 4ba0845
7 years ago
[dune] jbuilder -> dune Summary: the_future_is_now Reviewed By: jberdine Differential Revision: D8933124 fbshipit-source-id: e5df1a9a3
6 years ago
.PHONY: fmt_dune
fmt_dune:
[ocamlformat] Support passing args to ocamlformat Summary: Useful for testing / debugging ocamlformat updates Reviewed By: skcho Differential Revision: D21395971 fbshipit-source-id: d4f2f2dcb
5 years ago
parallel $(OCAMLFORMAT_EXE) $(OCAMLFORMAT_ARGS) -i ::: $(DUNE_ML)
Prepare to format OCaml and convert Reason code Summary: Add support for converting without actually converting. To be used as a landing pad for rebasing over the conversion. Reviewed By: jvillard Differential Revision: D5379967 fbshipit-source-id: 1bd932d
7 years ago
[ocamlformat] Upgrade ocamlformat version Reviewed By: jvillard Differential Revision: D18162727 fbshipit-source-id: ffb9f7541
5 years ago
SRC_ML:=$(shell find * \( -name _build -or -name facebook-clang-plugins -or -path facebook/dependencies -or -path sledge/llvm -or -path sledge/.llvm_build \) -not -prune -or -type f -and -name '*'.ml -or -name '*'.mli 2>/dev/null)
Prepare to format OCaml and convert Reason code Summary: Add support for converting without actually converting. To be used as a landing pad for rebasing over the conversion. Reviewed By: jvillard Differential Revision: D5379967 fbshipit-source-id: 1bd932d
7 years ago
.PHONY: fmt_all
Convert Reason to OCaml, and auto-format OCaml Summary: Conversion and reformat of infer source using ocamlformat auto-formatting tool. Current status: - Because Reason does not handle docstrings, the output of the conversion is not 'Warning 50'-clean, meaning that there are docstrings with ambiguous placement. I'll need to manually fix them just before landing. Reviewed By: jvillard Differential Revision: D5225546 fbshipit-source-id: 3bd2786
7 years ago
fmt_all:
[ocamlformat] Support passing args to ocamlformat Summary: Useful for testing / debugging ocamlformat updates Reviewed By: skcho Differential Revision: D21395971 fbshipit-source-id: d4f2f2dcb
5 years ago
parallel $(OCAMLFORMAT_EXE) $(OCAMLFORMAT_ARGS) -i ::: $(SRC_ML) $(DUNE_ML)
Prepare to format OCaml and convert Reason code Summary: Add support for converting without actually converting. To be used as a landing pad for rebasing over the conversion. Reviewed By: jvillard Differential Revision: D5379967 fbshipit-source-id: 1bd932d
7 years ago
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
# pre-building these avoids race conditions when building, eg src_build and test_build in parallel
.PHONY: src_build_common
src_build_common:
$(QUIET)$(call silent_on_success,Generating source dependencies,\
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
$(MAKE_SOURCE) src_build_common)
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: src_build
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
src_build: src_build_common
[make] print build_mode to console Summary: Useful to know if your build is going to take 40s or 4 minutes. Reviewed By: jeremydubreil Differential Revision: D5872878 fbshipit-source-id: 1d370f3
7 years ago
$(QUIET)$(call silent_on_success,Building native($(BUILD_MODE)) Infer,\
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
$(MAKE_SOURCE) infer)
[make] add `make byte` toplevel target Summary: `make byte` will populate infer/bin/ with bytecode version of each executable, plus infer/bin/infer.byte (used to remember which of the native or byte executables have been built most recently). `make infer` now also creates infer/bin/infer.native, so that we're sure to replace the executables with native/byte versions as appropriate. This is to make debugging a tad easier: make byte ledit ocamldebug $(which infer) <infer args> Whereas previously one had to: make -C infer/src byte ledit ocamldebug infer/_build/infer/backend/infer.byte <infer args> Reviewed By: jberdine Differential Revision: D4409476 fbshipit-source-id: ab5f57d
8 years ago
.PHONY: byte
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
byte: src_build_common
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)$(call silent_on_success,Building byte Infer,\
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
$(MAKE_SOURCE) byte)
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
[build] Add `make check` target to build artifacts for tooling/merlin Summary: Quoting the doc: > `dune check` builds the minimal set of targets required for tooling support. Essentially, this is .cmi, .cmt, .cmti, and .merlin files. So, running `make check` can be a tad faster and more economical way to typecheck the code as you develop (and make merlin understand what's going on). We already had `check` taget defined in `infer/src/Makefile` but it was not exposed at the top level. Fixing it. Reviewed By: jberdine Differential Revision: D19619920 fbshipit-source-id: c143cecd8
5 years ago
.PHONY: check
check: src_build_common
$(QUIET)$(call silent_on_success,Building artifacts for tooling support,\
$(MAKE_SOURCE) check)
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
.PHONY: test_build
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
test_build: src_build_common
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)$(call silent_on_success,Testing Infer builds without warnings,\
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
$(MAKE_SOURCE) test)
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
[test] do not run the dead code analysis as part of the tests Summary: The dead code checker slows down the test suite notably, and can be annoying when you're in the middle of a change. Depends on D7443825 Reviewed By: mbouaziz, ngorogiannis Differential Revision: D7443881 fbshipit-source-id: 746cf6e
7 years ago
# deadcode analysis: only do the deadcode detection on Facebook builds and if GNU sed is available
.PHONY: real_deadcode
real_deadcode: src_build_common
[tests] kill some new dead code Summary: Make dead code detection part of `make test` so that dead code stops creeping in. It's only enabled if all the analysers are enabled and if this is a facebook build, because the dead code detection will have false positives otherwise. Reviewed By: mbouaziz Differential Revision: D6807395 fbshipit-source-id: ebbd835
7 years ago
$(QUIET)$(call silent_on_success,Testing there is no dead OCaml code,\
$(MAKE) -C $(SRC_DIR)/deadcode)
[test] do not run the dead code analysis as part of the tests Summary: The dead code checker slows down the test suite notably, and can be annoying when you're in the middle of a change. Depends on D7443825 Reviewed By: mbouaziz, ngorogiannis Differential Revision: D7443881 fbshipit-source-id: 746cf6e
7 years ago
.PHONY: deadcode
deadcode:
ifeq ($(IS_FACEBOOK_TREE),no)
$(QUIET)echo "Deadcode detection only works in Facebook builds, skipping"
endif
ifeq ($(GNU_SED),no)
$(QUIET)echo "Deadcode detection only works with GNU sed installed, skipping"
endif
ifeq ($(IS_FACEBOOK_TREE),yes)
ifneq ($(GNU_SED),no)
deadcode: real_deadcode
endif
endif
[toplevel] install infertop in infer/bin/ to get models and stuff Summary: Some paths are hardcoded in infer as being relative to the current executable, for instance the directory where to find the models. By copying infertop.bc to infer/bin like we do for `infer` these relative paths lead to the expected place, which means models can be loaded in the toplevel like they would be in a normal infer execution. This is more useful for debugging than previously. Reviewed By: jeremydubreil, mbouaziz Differential Revision: D9197142 fbshipit-source-id: 48c4f82fb
6 years ago
.PHONY: toplevel toplevel_test
toplevel toplevel_test: src_build_common
toplevel:
[make] add toplevel target to build and start the toplevel Summary: Convenient. Reviewed By: mbouaziz Differential Revision: D6545072 fbshipit-source-id: a05d384
7 years ago
$(QUIET)$(call silent_on_success,Building Infer REPL,\
$(MAKE_SOURCE) toplevel)
$(QUIET)echo
$(QUIET)echo "You can now use the infer REPL:"
$(QUIET)echo " \"$(ABSOLUTE_ROOT_DIR)/scripts/infer_repl\""
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
toplevel_test:
$(QUIET)$(call silent_on_success,Building Infer REPL,\
$(MAKE_SOURCE) toplevel)
[toplevel] install infertop in infer/bin/ to get models and stuff Summary: Some paths are hardcoded in infer as being relative to the current executable, for instance the directory where to find the models. By copying infertop.bc to infer/bin like we do for `infer` these relative paths lead to the expected place, which means models can be loaded in the toplevel like they would be in a normal infer execution. This is more useful for debugging than previously. Reviewed By: jeremydubreil, mbouaziz Differential Revision: D9197142 fbshipit-source-id: 48c4f82fb
6 years ago
[make] add `make byte` toplevel target Summary: `make byte` will populate infer/bin/ with bytecode version of each executable, plus infer/bin/infer.byte (used to remember which of the native or byte executables have been built most recently). `make infer` now also creates infer/bin/infer.native, so that we're sure to replace the executables with native/byte versions as appropriate. This is to make debugging a tad easier: make byte ledit ocamldebug $(which infer) <infer args> Whereas previously one had to: make -C infer/src byte ledit ocamldebug infer/_build/infer/backend/infer.byte <infer args> Reviewed By: jberdine Differential Revision: D4409476 fbshipit-source-id: ab5f57d
8 years ago
ifeq ($(IS_FACEBOOK_TREE),yes)
[make] s/ocamlbuild/jbuilder/g Summary: Use jbuilder to build infer instead of ocamlbuild. This is mainly to get faster builds: ``` times in 10ms, ±differences measured in speedups, 4 cores | | ocb total | jb | ±total | ocb user | jb | ±user | ocb cpu | jb | ±cpu | ocb sys | jb | ±sys | |-----------------------------------+-----------+------+--------+----------+------+-------+---------+-----+------+---------+------+------| | byte from scratch | 6428 | 2456 | 2.62 | 7743 | 6662 | 1.16 | 138 | 331 | 2.40 | 1184 | 1477 | 0.80 | | native from scratch | 9841 | 4289 | 2.29 | 9530 | 8834 | 1.08 | 110 | 245 | 2.23 | 1373 | 1712 | 0.80 | | byte after native | 29578 | 1602 | 18.46 | 4514 | 4640 | 0.97 | 170 | 325 | 1.91 | 543 | 576 | 0.94 | | change infer.ml byte | 344 | 282 | 1.22 | 292 | 215 | 1.36 | 96 | 99 | 1.03 | 040 | 066 | 0.61 | | change infer.ml native | 837 | 223 | 3.75 | 789 | 174 | 4.53 | 98 | 99 | 1.01 | 036 | 47 | 0.77 | | change Config.ml byte | 451 | 339 | 1.33 | 382 | 336 | 1.14 | 97 | 122 | 1.26 | 056 | 80 | 0.70 | | change Config.ml native | 4024 | 1760 | 2.29 | 4585 | 4225 | 1.09 | 127 | 276 | 2.17 | 559 | 644 | 0.87 | | change cFrontend_config.ml byte | 348 | 643 | 0.54 | 297 | 330 | 0.90 | 96 | 67 | 0.70 | 038 | 102 | 0.37 | | change cFrontend_config.ml native | 1480 | 584 | 2.53 | 1435 | 906 | 1.58 | 106 | 185 | 1.75 | 136 | 178 | 0.76 | #+TBLFM: $4=$2/$3;f2::$7=$5/$6;f2::$10=$9/$8;f2::$13=$11/$12;f2 50 cores | | ocb total | jb | ±total | ocb user | jb | ±user | ocb cpu | jb | ±cpu | ocb sys | jb | ±sys | |---------------------+-----------+------+--------+----------+------+-------+---------+----+------+---------+------+------| | byte from scratch | 9114 | 2061 | 4.42 | 9334 | 5133 | 1.82 | | | 0/0 | 2566 | 1726 | 1.49 | | native from scratch | 13481 | 3967 | 3.40 | 12291 | 7608 | 1.62 | | | 0/0 | 3003 | 2100 | 1.43 | | byte after native | 3467 | 1476 | 2.35 | 5067 | 3912 | 1.30 | | | 0/0 | 971 | 801 | 1.21 | #+TBLFM: $4=$2/$3;f2::$7=$5/$6;f2::$10=$9/$8;f2::$13=$11/$12;f2 ``` Menu: 1. Write a jbuild file, autogenerated from jbuild.in because we need to fill in some information at build-time (really, at configure time, but TODO), such as whether or not clang is enabled. 2. Nuke lots of stuff from infer/src/Makefile that is now in the jbuild file 3. The jbuild file lives in infer/src/ so it can see all the sources. If we put it somewhere else, eg, infer/, then `jbuilder` scans too many files (all irrelevant) and takes 2.5s to start instead of .8s. Adding irrelevant directories to jbuild-ignore does not help. 4. jbuilder does not support subdirectories, so resort to listing all the source files in the generated jbuild (only source directories need to be manually listed in jbuild.in though). Still, the generated .merlin is wrong and makes merlin find source files in _build, so manually tune it to get good merlin support. We also lose some of merlin for unit tests as it cannot see their build artefacts anymore. 5. checkCopyright gets its own jbuild because it's standalone. Also, remove some deprecation warnings in checkCopyright due to the new version of Core from a while ago. 6. Drop less-used Makefile features (they had regressed anyway) such as building individual modules. Also, building mod_dep.pdf now takes all the source files available so they better build (before, it would only take the source files from the config, eg with or without clang) (that's pretty minor). 7. The toplevel is now built as a custom toplevel because that was easier. It should soon be even easier: https://github.com/janestreet/jbuilder/issues/210 8. Move BUILTINS.mli to BUILTINS.ml because jbuilder is not happy about interface files without implementations. In particular, I did not try to migrate too much of the Makefile logic to jbuilder, more can be done in the future. Reviewed By: jberdine Differential Revision: D5573661 fbshipit-source-id: 4ca6d8f
7 years ago
byte src_build_common src_build test_build: fb-setup
[make] add `make byte` toplevel target Summary: `make byte` will populate infer/bin/ with bytecode version of each executable, plus infer/bin/infer.byte (used to remember which of the native or byte executables have been built most recently). `make infer` now also creates infer/bin/infer.native, so that we're sure to replace the executables with native/byte versions as appropriate. This is to make debugging a tad easier: make byte ledit ocamldebug $(which infer) <infer args> Whereas previously one had to: make -C infer/src byte ledit ocamldebug infer/_build/infer/backend/infer.byte <infer args> Reviewed By: jberdine Differential Revision: D4409476 fbshipit-source-id: ab5f57d
8 years ago
endif
add quick-test target Reviewed By: jberdine Differential Revision: D3436716 fbshipit-source-id: 8bfb530
9 years ago
ifeq ($(BUILD_C_ANALYZERS),yes)
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
byte src_build src_build_common test_build: clang_plugin
add quick-test target Reviewed By: jberdine Differential Revision: D3436716 fbshipit-source-id: 8bfb530
9 years ago
endif
[make] do not delete /usr/bin/infer* on uninstall Summary: Also, fix typo to actually install the man pages. Fixes #920 Reviewed By: mbouaziz Differential Revision: D8075978 fbshipit-source-id: e94786d
7 years ago
$(INFER_COMMAND_MANUALS): src_build $(MAKEFILE_LIST)
[make] install man pages Summary: `man infer` for the win! Reviewed By: mbouaziz Differential Revision: D5036764 fbshipit-source-id: 4567d24
8 years ago
$(QUIET)$(MKDIR_P) $(@D)
[help] scrub default values in the checked-in version of the manuals Summary: The default values of config options can sometimes depend on build-time configuration values. This makes checking that the manuals "remain the same" trickier as the manuals can be different depending on the platform. This removes *all* default values from the checked-in manuals. We could be more fine-grained and scrub only the values that are susceptible to change but for now this is probably good enough. This is done by implementing new options `--help-scrubbed` and `--help-scrubbed-full` and using these in our tests instead of `--help` and `--help-full` (which remain unaffected). Also don't wrap the default values in `$(i,...)` anymore because the defaults can trigger line breaks and then the man page is ill-formatted because that format is stupid. Reviewed By: mityal Differential Revision: D16543779 fbshipit-source-id: bc929ff8c
5 years ago
$(QUIET)$(INFER_BIN) $(patsubst infer-%.1,%,$(@F)) --help-scrubbed --help-format=groff > $@
[make] install man pages Summary: `man infer` for the win! Reviewed By: mbouaziz Differential Revision: D5036764 fbshipit-source-id: 4567d24
8 years ago
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
$(INFER_COMMAND_TEXT_MANUALS): src_build $(MAKEFILE_LIST)
$(QUIET)$(MKDIR_P) $(@D)
[help] scrub default values in the checked-in version of the manuals Summary: The default values of config options can sometimes depend on build-time configuration values. This makes checking that the manuals "remain the same" trickier as the manuals can be different depending on the platform. This removes *all* default values from the checked-in manuals. We could be more fine-grained and scrub only the values that are susceptible to change but for now this is probably good enough. This is done by implementing new options `--help-scrubbed` and `--help-scrubbed-full` and using these in our tests instead of `--help` and `--help-full` (which remain unaffected). Also don't wrap the default values in `$(i,...)` anymore because the defaults can trigger line breaks and then the man page is ill-formatted because that format is stupid. Reviewed By: mityal Differential Revision: D16543779 fbshipit-source-id: bc929ff8c
5 years ago
$(QUIET)$(INFER_BIN) $(patsubst infer-%.txt,%,$(@F)) --help-scrubbed --help-format=plain > $@
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
[make] do not delete /usr/bin/infer* on uninstall Summary: Also, fix typo to actually install the man pages. Fixes #920 Reviewed By: mbouaziz Differential Revision: D8075978 fbshipit-source-id: e94786d
7 years ago
$(INFER_MANUAL): src_build $(MAKEFILE_LIST)
[make] install man pages Summary: `man infer` for the win! Reviewed By: mbouaziz Differential Revision: D5036764 fbshipit-source-id: 4567d24
8 years ago
$(QUIET)$(MKDIR_P) $(@D)
[help] scrub default values in the checked-in version of the manuals Summary: The default values of config options can sometimes depend on build-time configuration values. This makes checking that the manuals "remain the same" trickier as the manuals can be different depending on the platform. This removes *all* default values from the checked-in manuals. We could be more fine-grained and scrub only the values that are susceptible to change but for now this is probably good enough. This is done by implementing new options `--help-scrubbed` and `--help-scrubbed-full` and using these in our tests instead of `--help` and `--help-full` (which remain unaffected). Also don't wrap the default values in `$(i,...)` anymore because the defaults can trigger line breaks and then the man page is ill-formatted because that format is stupid. Reviewed By: mityal Differential Revision: D16543779 fbshipit-source-id: bc929ff8c
5 years ago
$(QUIET)$(INFER_BIN) --help-scrubbed --help-format=groff > $@
[make] install man pages Summary: `man infer` for the win! Reviewed By: mbouaziz Differential Revision: D5036764 fbshipit-source-id: 4567d24
8 years ago
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
$(INFER_TEXT_MANUAL): src_build $(MAKEFILE_LIST)
$(QUIET)$(MKDIR_P) $(@D)
[help] scrub default values in the checked-in version of the manuals Summary: The default values of config options can sometimes depend on build-time configuration values. This makes checking that the manuals "remain the same" trickier as the manuals can be different depending on the platform. This removes *all* default values from the checked-in manuals. We could be more fine-grained and scrub only the values that are susceptible to change but for now this is probably good enough. This is done by implementing new options `--help-scrubbed` and `--help-scrubbed-full` and using these in our tests instead of `--help` and `--help-full` (which remain unaffected). Also don't wrap the default values in `$(i,...)` anymore because the defaults can trigger line breaks and then the man page is ill-formatted because that format is stupid. Reviewed By: mityal Differential Revision: D16543779 fbshipit-source-id: bc929ff8c
5 years ago
$(QUIET)$(INFER_BIN) --help-scrubbed --help-format=plain > $@
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
$(INFER_FULL_TEXT_MANUAL): src_build $(MAKEFILE_LIST)
$(QUIET)$(MKDIR_P) $(@D)
[help] scrub default values in the checked-in version of the manuals Summary: The default values of config options can sometimes depend on build-time configuration values. This makes checking that the manuals "remain the same" trickier as the manuals can be different depending on the platform. This removes *all* default values from the checked-in manuals. We could be more fine-grained and scrub only the values that are susceptible to change but for now this is probably good enough. This is done by implementing new options `--help-scrubbed` and `--help-scrubbed-full` and using these in our tests instead of `--help` and `--help-full` (which remain unaffected). Also don't wrap the default values in `$(i,...)` anymore because the defaults can trigger line breaks and then the man page is ill-formatted because that format is stupid. Reviewed By: mityal Differential Revision: D16543779 fbshipit-source-id: bc929ff8c
5 years ago
$(QUIET)$(INFER_BIN) --help-scrubbed-full --help-format=plain > $@
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
$(INFER_GROFF_MANUALS_GZIPPED): %.gz: %
[make] install man pages Summary: `man infer` for the win! Reviewed By: mbouaziz Differential Revision: D5036764 fbshipit-source-id: 4567d24
8 years ago
$(QUIET)$(REMOVE) $@
gzip $<
[build] Add `manuals` make target Summary: Manuals were previously built as part of `make test`, but `test` takes too long so `make manuals` is a convenient replacement. Reviewed By: ngorogiannis Differential Revision: D20517145 fbshipit-source-id: 404c9921f
5 years ago
manuals:
$(QUIET)$(call silent_on_success,Building Infer manuals,\
$(MAKE) $(INFER_MANUALS))
[make] do not delete /usr/bin/infer* on uninstall Summary: Also, fix typo to actually install the man pages. Fixes #920 Reviewed By: mbouaziz Differential Revision: D8075978 fbshipit-source-id: e94786d
7 years ago
infer_models: src_build
add files lost in sync with internal repo
9 years ago
ifeq ($(BUILD_JAVA_ANALYZERS),yes)
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
$(QUIET)$(call silent_on_success,Building infer annotations,\
$(MAKE) -C $(ANNOTATIONS_DIR))
[clang] convert filter_args_and_run_fcp_clang to OCaml Summary: This also adds `-a compile` support to `InferClang`. This is needed for the `xcodebuild` integration, which is hard to fold into the same binary as the rest. Reviewed By: jberdine Differential Revision: D4008262 fbshipit-source-id: 0bbd53f
8 years ago
endif
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
$(QUIET)$(call silent_on_success,Building infer models,\
$(MAKE) -C $(MODELS_DIR) all)
[make] fewer phony dependencies Summary: This avoids rebuilding the man pages at every build. Also add a `byte_infer` target to build infer in bytecode + the models, and an `opt` target, as I found myself missing those. Reviewed By: mbouaziz Differential Revision: D6761008 fbshipit-source-id: ffedd4b
7 years ago
.PHONY: infer byte_infer
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
infer byte_infer: infer_models
[make] fewer phony dependencies Summary: This avoids rebuilding the man pages at every build. Also add a `byte_infer` target to build infer in bytecode + the models, and an `opt` target, as I found myself missing those. Reviewed By: mbouaziz Differential Revision: D6761008 fbshipit-source-id: ffedd4b
7 years ago
infer: src_build
byte_infer: byte
add files lost in sync with internal repo
9 years ago
[make] fewer phony dependencies Summary: This avoids rebuilding the man pages at every build. Also add a `byte_infer` target to build infer in bytecode + the models, and an `opt` target, as I found myself missing those. Reviewed By: mbouaziz Differential Revision: D6761008 fbshipit-source-id: ffedd4b
7 years ago
.PHONY: opt
opt:
$(QUIET)$(MAKE) BUILD_MODE=opt infer
[make] install man pages Summary: `man infer` for the win! Reviewed By: mbouaziz Differential Revision: D5036764 fbshipit-source-id: 4567d24
8 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: clang_setup
add files lost in sync with internal repo
9 years ago
clang_setup:
[make] let user know how to stop clang rebuilds Summary: Building clang takes long and sometimes only some minor step in the setup script has changed, triggering a spurious rebuild. Print a big bold message letting the user know of their options, but only if clang has been installed previously. ``` (warn_clang)jul@devvm2701:~/infer$ make -j 19 [04:02:44][2288770] Facebook setup... *** Now building clang, this will take a while... *** If you believe that facebook-clang-plugins/clang/install is up-to-date you can(TERM_RESET) *** interrupt the compilation (Control-C) and run this to prevent clang from being rebuilt: /home/jul/infer/facebook-clang-plugins/clang/setup.sh --only-record-install (TIP: you can also force a clang rebuild by removing /home/jul/infer/facebook-clang-plugins/clang/installed.version) [...] ``` Reviewed By: katiejots Differential Revision: D13956431 fbshipit-source-id: da163643d
6 years ago
# if clang is already built then let the user know they might not need to rebuild clang
[make] print @ commands when passed VERBOSE=1 Summary: It can be useful when debugging infer or the Makefiles themselves to see what `make` is doing. Instead of editing Makefiles to remove `@` now you can `make VERBOSE=1`. This is just `git ls-files | grep -e Makefile -e '.*\.make' | xargs sed -e 's/^\t@/\t$(QUIET)/' -i`, and adding the definition of `QUIET` to Makefile.config. Reviewed By: jeremydubreil Differential Revision: D4779115 fbshipit-source-id: e6e4642
8 years ago
$(QUIET)export CC="$(CC)" CFLAGS="$(CFLAGS)"; \
add files lost in sync with internal repo
9 years ago
export CXX="$(CXX)" CXXFLAGS="$(CXXFLAGS)"; \
export CPP="$(CPP)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS)"; \
[make] let user know how to stop clang rebuilds Summary: Building clang takes long and sometimes only some minor step in the setup script has changed, triggering a spurious rebuild. Print a big bold message letting the user know of their options, but only if clang has been installed previously. ``` (warn_clang)jul@devvm2701:~/infer$ make -j 19 [04:02:44][2288770] Facebook setup... *** Now building clang, this will take a while... *** If you believe that facebook-clang-plugins/clang/install is up-to-date you can(TERM_RESET) *** interrupt the compilation (Control-C) and run this to prevent clang from being rebuilt: /home/jul/infer/facebook-clang-plugins/clang/setup.sh --only-record-install (TIP: you can also force a clang rebuild by removing /home/jul/infer/facebook-clang-plugins/clang/installed.version) [...] ``` Reviewed By: katiejots Differential Revision: D13956431 fbshipit-source-id: da163643d
6 years ago
$(FCP_DIR)/clang/setup.sh --only-check-install || { \
if [ -x '$(FCP_DIR)'/clang/install/bin/clang ]; then \
echo '$(TERM_INFO)*** Now building clang, this will take a while...$(TERM_RESET)' >&2; \
echo '$(TERM_INFO)*** If you believe that facebook-clang-plugins/clang/install is up-to-date you can$(TERM_RESET)' >&2; \
echo '$(TERM_INFO)*** interrupt the compilation (Control-C) and run this to prevent clang from being rebuilt:$(TERM_RESET)' >&2; \
echo >&2 ; \
echo '$(TERM_INFO) $(FCP_DIR)/clang/setup.sh --only-record-install$(TERM_RESET)' >&2; \
echo >&2 ; \
echo '$(TERM_INFO)(TIP: you can also force a clang rebuild by removing $(FCP_DIR)/clang/installed.version)$(TERM_RESET)' >&2; \
echo >&2 ; \
fi; \
$(FCP_DIR)/clang/setup.sh; \
}
add files lost in sync with internal repo
9 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: clang_plugin
add files lost in sync with internal repo
9 years ago
clang_plugin: clang_setup
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)$(call silent_on_success,Building clang plugin,\
$(MAKE) -C $(FCP_DIR)/libtooling all \
Lock g++ platform so clang-plugins builds on devservers Reviewed By: codemiller Differential Revision: D9136267 fbshipit-source-id: 64819e7cf
6 years ago
CC="$(CC)" CXX="$(CXX)" \
add files lost in sync with internal repo
9 years ago
CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" \
CPP="$(CPP)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS)" \
LOCAL_CLANG=$(CLANG_PREFIX)/bin/clang \
CLANG_PREFIX=$(CLANG_PREFIX) \
[objc] pass SDK config to plugin Summary: This makes the plugin follow infer's configuration. Reviewed By: martintrojer Differential Revision: D18595972 fbshipit-source-id: f685dd057
5 years ago
CLANG_INCLUDES=$(CLANG_INCLUDES) \
SDKPATH=$(XCODE_ISYSROOT) \
)
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)$(call silent_on_success,Building clang plugin OCaml interface,\
$(MAKE) -C $(FCP_DIR)/clang-ocaml all \
add files lost in sync with internal repo
9 years ago
build/clang_ast_proj.ml build/clang_ast_proj.mli \
CC=$(CC) CXX=$(CXX) \
CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" \
CPP="$(CPP)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS)" \
LOCAL_CLANG=$(CLANG_PREFIX)/bin/clang \
CLANG_PREFIX=$(CLANG_PREFIX) \
[objc] pass SDK config to plugin Summary: This makes the plugin follow infer's configuration. Reviewed By: martintrojer Differential Revision: D18595972 fbshipit-source-id: f685dd057
5 years ago
CLANG_INCLUDES=$(CLANG_INCLUDES) \
SDKPATH=$(XCODE_ISYSROOT) \
)
[makefile] New target for running clang plugin tests Reviewed By: jvillard Differential Revision: D7637364 fbshipit-source-id: 36b5ca9
7 years ago
.PHONY: clang_plugin_test
clang_plugin_test: clang_setup
[objc] pass SDK config to plugin Summary: This makes the plugin follow infer's configuration. Reviewed By: martintrojer Differential Revision: D18595972 fbshipit-source-id: f685dd057
5 years ago
$(QUIET)$(call silent_on_success,Running facebook-clang-plugins/libtooling/ tests,\
$(MAKE) -C $(FCP_DIR)/libtooling test \
CC=$(CC) CXX=$(CXX) \
CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" \
CPP="$(CPP)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS)" \
LOCAL_CLANG=$(CLANG_PREFIX)/bin/clang \
CLANG_PREFIX=$(CLANG_PREFIX) \
CLANG_INCLUDES=$(CLANG_INCLUDES) \
SDKPATH=$(XCODE_ISYSROOT) \
)
$(QUIET)$(call silent_on_success,Running facebook-clang-plugins/clang-ocaml/ tests,\
$(MAKE) -C $(FCP_DIR)/clang-ocaml test \
CC=$(CC) CXX=$(CXX) \
CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" \
CPP="$(CPP)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS)" \
LOCAL_CLANG=$(CLANG_PREFIX)/bin/clang \
CLANG_PREFIX=$(CLANG_PREFIX) \
CLANG_INCLUDES=$(CLANG_INCLUDES) \
SDKPATH=$(XCODE_ISYSROOT) \
)
[clang plugin] bump version to include tests fix Summary: Also changes `clang_plugin_test` so that it also runs the clang-ocaml tests, and add a new `clang_plugin_test_replace` target. The controller you requested could not be found.: facebook-clang-plugins Reviewed By: jberdine Differential Revision: D10141902 fbshipit-source-id: 927c55a4f
6 years ago
.PHONY: clang_plugin_test
clang_plugin_test_replace: clang_setup
[objc] pass SDK config to plugin Summary: This makes the plugin follow infer's configuration. Reviewed By: martintrojer Differential Revision: D18595972 fbshipit-source-id: f685dd057
5 years ago
$(QUIET)$(call silent_on_success,Running facebook-clang-plugins/libtooling/ record tests,\
$(MAKE) -C $(FCP_DIR)/libtooling record-test-outputs \
CC=$(CC) CXX=$(CXX) \
CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" \
CPP="$(CPP)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS)" \
LOCAL_CLANG=$(CLANG_PREFIX)/bin/clang \
CLANG_PREFIX=$(CLANG_PREFIX) \
CLANG_INCLUDES=$(CLANG_INCLUDES) \
SDKPATH=$(XCODE_ISYSROOT) \
)
$(QUIET)$(call silent_on_success,Running facebook-clang-plugins/clang-ocaml/ record tests,\
$(MAKE) -C $(FCP_DIR)/clang-ocaml record-test-outputs \
CC=$(CC) CXX=$(CXX) \
CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" \
CPP="$(CPP)" LDFLAGS="$(LDFLAGS)" LIBS="$(LIBS)" \
LOCAL_CLANG=$(CLANG_PREFIX)/bin/clang \
CLANG_PREFIX=$(CLANG_PREFIX) \
CLANG_INCLUDES=$(CLANG_INCLUDES) \
SDKPATH=$(XCODE_ISYSROOT) \
)
[makefile] New target for running clang plugin tests Reviewed By: jvillard Differential Revision: D7637364 fbshipit-source-id: 36b5ca9
7 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: ocaml_unit_test
[make] make infer/src/Makefile less phony Reviewed By: jberdine Differential Revision: D4319515 fbshipit-source-id: 607022c
8 years ago
ocaml_unit_test: test_build
[sql] add proc attributes DB Summary: Use an SQLite database to store proc attributes, instead of files on disk. Wrap SQLite operations in two layers: 1. `SqliteUtils` provides helper functions to make sure DB operations succeed 2. `KeyValue` provides a functor to expose a simple and type-safe key/value store backed by the SQLite DB. Reviewed By: jberdine Differential Revision: D5640053 fbshipit-source-id: 31050e5
7 years ago
$(QUIET)$(REMOVE_DIR) infer-out-unit-tests
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)$(call silent_on_success,Running OCaml unit tests,\
[build] Replace custom make cmds w/ dune promotion and byte_complete Summary: Main changes are: 1. Dune can promote targets into the source tree as a part of build. This allows us to **remove custom promotion/installation logic in src/Makefile**. 2. Dune promotion only works for path within workspace. This required **moving dune-workspace one folder up**: from infer/infer/src to infer/infer. But this is not bad, since it makes it possible to migrate tests under dune at some point. 3. `checkCopyright` now also promoted into `infer/infer/bin` instead of `infer/scripts` partly for consistency and partly because of the dune-workspace location. 4. `byte` mode was replaced with `byte_complete`. The latter takes similar amount of time to build compared to `byte`, but produces standalone binaries that don't require InferCStubs to be installed. This allowed to remove `dune_exec_shim` and custom logic around `dune build InferCStubs.install` when dealing with byte targets. All in all, `infer/src/Makefile` is not about 2/3 its previous size with less custom logic in Makefiles/scripts and more encoded in dune build files. Reviewed By: jvillard Differential Revision: D20303902 fbshipit-source-id: 9e4c65bd0
5 years ago
INFER_ARGS=--results-dir^infer-out-unit-tests $(INFERUNIT_BIN))
add files lost in sync with internal repo
9 years ago
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
define silence_make
[make] restore output of errors Summary: Lost in D7569054: because `-e` is set, the command to run needs to be wrapped a bit more carefully to continue the execution in case of failure and get to the part where we print the error messages on the console. Reviewed By: mbouaziz Differential Revision: D7599442 fbshipit-source-id: 65f6bf7
7 years ago
$(1) 2> >(grep -v 'warning: \(ignoring old\|overriding\) \(commands\|recipe\) for target')
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
endef
Convert Eradicate and Checkers tests to direct format. Summary: This diff converts the Eradicate and Checkers tests to the new direct test format, which does not rely on buck or junit. A self-contained Makefile is used to compile and analyze the test files, including all the dependencies, and a special option in InferPrint is used to produce a file of expected results `issues.exp`, which is checked into the repository. Having an explicit Makefile makes it easy to edit and compile one set of test files in isolation, to investigate test failures, do debugging, etc. A bunch of boilerplate code is removed. For example, the single file of expected results `issues.exp` replaces the 1.5K LOC in `endtoend/java/eradicate`. Reviewed By: jvillard Differential Revision: D3764632 fbshipit-source-id: 6c68ab8
8 years ago
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
.PHONY: $(DIRECT_TESTS:%=direct_%_test)
$(DIRECT_TESTS:%=direct_%_test): infer
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Running test: $(subst _, ,$@),\
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(call silence_make,\
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
$(MAKE) -C \
$(INFER_DIR)/tests/codetoanalyze/$(shell printf $@ | cut -f 2 -d _)/$(shell printf $@ | cut -f 3 -d _) \
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
test))
[make] generate test rules automatically, add cpp checkers tests Summary: The direct test rules are very regular and depend only on their names, except for some *_infer_* rules that I had to change to *_errors_*. We can rename these directories if we want (to make them like Java). Reviewed By: jeremydubreil Differential Revision: D4081111 fbshipit-source-id: 3295acb
8 years ago
[make] run test analysis then test printing to group failures at the end Summary: This makes it a bit easier to read the results of `make test`. Reviewed By: jberdine Differential Revision: D4326467 fbshipit-source-id: dd69114
8 years ago
.PHONY: $(DIRECT_TESTS:%=direct_%_print)
$(DIRECT_TESTS:%=direct_%_print): infer
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Running: $(subst _, ,$@),\
$(call silence_make,\
[make] run test analysis then test printing to group failures at the end Summary: This makes it a bit easier to read the results of `make test`. Reviewed By: jberdine Differential Revision: D4326467 fbshipit-source-id: dd69114
8 years ago
$(MAKE) -C \
$(INFER_DIR)/tests/codetoanalyze/$(shell printf $@ | cut -f 2 -d _)/$(shell printf $@ | cut -f 3 -d _) \
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
print))
[make] run test analysis then test printing to group failures at the end Summary: This makes it a bit easier to read the results of `make test`. Reviewed By: jberdine Differential Revision: D4326467 fbshipit-source-id: dd69114
8 years ago
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
.PHONY: $(DIRECT_TESTS:%=direct_%_clean)
$(DIRECT_TESTS:%=direct_%_clean):
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Cleaning: $(subst _, ,$@),\
$(call silence_make,\
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
$(MAKE) -C \
$(INFER_DIR)/tests/codetoanalyze/$(shell printf $@ | cut -f 2 -d _)/$(shell printf $@ | cut -f 3 -d _) \
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
clean))
[tests] Convert the linter tests to the new direct format Reviewed By: jberdine Differential Revision: D3877153 fbshipit-source-id: a0efb3c
8 years ago
[tests] add a `replace` target to all tests Summary: Most of our tests work by comparing the output of some command to a baseline expected output. It's often needed to update that baseline. Previously, that was crudely done by attempting to move every foo.exp.test file to foo.exp. This does not work terribly well, in particular because foo.exp.test might be stale. Instead, add a `replace` target to every test that knows how to update the baseline. This allows custom behaviours too, eg in the differential tests. Most of the tests include base.make or differential.make, so add a replace target there. A few tests are completely custom, add a replace target to them too. Reviewed By: jeremydubreil Differential Revision: D4754279 fbshipit-source-id: ec34273
8 years ago
.PHONY: $(DIRECT_TESTS:%=direct_%_replace)
$(DIRECT_TESTS:%=direct_%_replace): infer
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Recording: $(subst _, ,$@),\
$(call silence_make,\
[tests] add a `replace` target to all tests Summary: Most of our tests work by comparing the output of some command to a baseline expected output. It's often needed to update that baseline. Previously, that was crudely done by attempting to move every foo.exp.test file to foo.exp. This does not work terribly well, in particular because foo.exp.test might be stale. Instead, add a `replace` target to every test that knows how to update the baseline. This allows custom behaviours too, eg in the differential tests. Most of the tests include base.make or differential.make, so add a replace target there. A few tests are completely custom, add a replace target to them too. Reviewed By: jeremydubreil Differential Revision: D4754279 fbshipit-source-id: ec34273
8 years ago
$(MAKE) -C \
$(INFER_DIR)/tests/codetoanalyze/$(shell printf $@ | cut -f 2 -d _)/$(shell printf $@ | cut -f 3 -d _) \
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
replace))
[tests] add a `replace` target to all tests Summary: Most of our tests work by comparing the output of some command to a baseline expected output. It's often needed to update that baseline. Previously, that was crudely done by attempting to move every foo.exp.test file to foo.exp. This does not work terribly well, in particular because foo.exp.test might be stale. Instead, add a `replace` target to every test that knows how to update the baseline. This allows custom behaviours too, eg in the differential tests. Most of the tests include base.make or differential.make, so add a replace target there. A few tests are completely custom, add a replace target to them too. Reviewed By: jeremydubreil Differential Revision: D4754279 fbshipit-source-id: ec34273
8 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: direct_tests
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
direct_tests: $(DIRECT_TESTS:%=direct_%_test)
[cost] Introduce make for only cost analysis Summary: Sometimes, we want to run/clean/replace tests for **only cost analysis**. Let's introduce a set of commands for this purpose. Reviewed By: skcho Differential Revision: D20141657 fbshipit-source-id: d0ad267b2
5 years ago
COST_TESTS += \
c_performance \
java_hoistingExpensive \
java_performance \
[make] Add missing cost test directories Summary: We were missing `performance-exclusive` and `fb-performance` tests in the list of cost analysis targets. Reviewed By: jvillard Differential Revision: D21837972 fbshipit-source-id: 550d27918
5 years ago
java_performance-exclusive \
[cost] Introduce make for only cost analysis Summary: Sometimes, we want to run/clean/replace tests for **only cost analysis**. Let's introduce a set of commands for this purpose. Reviewed By: skcho Differential Revision: D20141657 fbshipit-source-id: d0ad267b2
5 years ago
objc_performance \
[make] Add missing cost test directories Summary: We were missing `performance-exclusive` and `fb-performance` tests in the list of cost analysis targets. Reviewed By: jvillard Differential Revision: D21837972 fbshipit-source-id: 550d27918
5 years ago
ifeq ($(IS_FACEBOOK_TREE),yes)
COST_TESTS += java_fb-performance
endif
[cost] Introduce make for only cost analysis Summary: Sometimes, we want to run/clean/replace tests for **only cost analysis**. Let's introduce a set of commands for this purpose. Reviewed By: skcho Differential Revision: D20141657 fbshipit-source-id: d0ad267b2
5 years ago
.PHONY: cost_tests
cost_tests: $(COST_TESTS:%=direct_%_test)
.PHONY: cost_tests_clean
cost_tests_clean: $(COST_TESTS:%=direct_%_clean)
.PHONY: cost_tests_replace
cost_tests_replace: $(COST_TESTS:%=direct_%_replace)
.PHONY: cost_tests_print
cost_tests_print: $(COST_TESTS:%=direct_%_print)
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
.PHONY: $(BUILD_SYSTEMS_TESTS:%=build_%_test)
$(BUILD_SYSTEMS_TESTS:%=build_%_test): infer
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Running test: $(subst _, ,$@),\
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(call silence_make,\
$(MAKE) -C $(INFER_DIR)/tests/build_systems/$(patsubst build_%_test,%,$@) test))
add files lost in sync with internal repo
9 years ago
[make] run test analysis then test printing to group failures at the end Summary: This makes it a bit easier to read the results of `make test`. Reviewed By: jberdine Differential Revision: D4326467 fbshipit-source-id: dd69114
8 years ago
.PHONY: $(BUILD_SYSTEMS_TESTS:%=build_%_print)
$(BUILD_SYSTEMS_TESTS:%=build_%_print): infer
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Running: $(subst _, ,$@),\
$(call silence_make,\
$(MAKE) -C $(INFER_DIR)/tests/build_systems/$(patsubst build_%_print,%,$@) print))
[make] run test analysis then test printing to group failures at the end Summary: This makes it a bit easier to read the results of `make test`. Reviewed By: jberdine Differential Revision: D4326467 fbshipit-source-id: dd69114
8 years ago
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
.PHONY: $(BUILD_SYSTEMS_TESTS:%=build_%_clean)
$(BUILD_SYSTEMS_TESTS:%=build_%_clean):
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Cleaning: $(subst _, ,$@),\
$(call silence_make,\
$(MAKE) -C $(INFER_DIR)/tests/build_systems/$(patsubst build_%_clean,%,$@) clean))
[tests] convert ant integration test to a Makefile Summary: Time for this framework to die. This converts the ant test to a Makefile. The design is that each test or family of tests will have its own directory. Do the necessary plumbing from the toplevel Makefile so that `make test` runs the migrated tests. Reviewed By: jberdine Differential Revision: D4106298 fbshipit-source-id: 7bd694d
8 years ago
[tests] add a `replace` target to all tests Summary: Most of our tests work by comparing the output of some command to a baseline expected output. It's often needed to update that baseline. Previously, that was crudely done by attempting to move every foo.exp.test file to foo.exp. This does not work terribly well, in particular because foo.exp.test might be stale. Instead, add a `replace` target to every test that knows how to update the baseline. This allows custom behaviours too, eg in the differential tests. Most of the tests include base.make or differential.make, so add a replace target there. A few tests are completely custom, add a replace target to them too. Reviewed By: jeremydubreil Differential Revision: D4754279 fbshipit-source-id: ec34273
8 years ago
.PHONY: $(BUILD_SYSTEMS_TESTS:%=build_%_replace)
$(BUILD_SYSTEMS_TESTS:%=build_%_replace): infer
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Recording: $(subst _, ,$@),\
$(call silence_make,\
$(MAKE) -C $(INFER_DIR)/tests/build_systems/$(patsubst build_%_replace,%,$@) replace))
[tests] add a `replace` target to all tests Summary: Most of our tests work by comparing the output of some command to a baseline expected output. It's often needed to update that baseline. Previously, that was crudely done by attempting to move every foo.exp.test file to foo.exp. This does not work terribly well, in particular because foo.exp.test might be stale. Instead, add a `replace` target to every test that knows how to update the baseline. This allows custom behaviours too, eg in the differential tests. Most of the tests include base.make or differential.make, so add a replace target there. A few tests are completely custom, add a replace target to them too. Reviewed By: jeremydubreil Differential Revision: D4754279 fbshipit-source-id: ec34273
8 years ago
[toplevel] install infertop in infer/bin/ to get models and stuff Summary: Some paths are hardcoded in infer as being relative to the current executable, for instance the directory where to find the models. By copying infertop.bc to infer/bin like we do for `infer` these relative paths lead to the expected place, which means models can be loaded in the toplevel like they would be in a normal infer execution. This is more useful for debugging than previously. Reviewed By: jeremydubreil, mbouaziz Differential Revision: D9197142 fbshipit-source-id: 48c4f82fb
6 years ago
build_infertop_print build_infertop_test build_infertop_replace: toplevel_test
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
[tests] convert ant integration test to a Makefile Summary: Time for this framework to die. This converts the ant test to a Makefile. The design is that each test or family of tests will have its own directory. Do the necessary plumbing from the toplevel Makefile so that `make test` runs the migrated tests. Reviewed By: jberdine Differential Revision: D4106298 fbshipit-source-id: 7bd694d
8 years ago
.PHONY: build_systems_tests
[tests] kill empty build_integration_tests.py Reviewed By: jberdine Differential Revision: D4329664 fbshipit-source-id: dc59abc
8 years ago
build_systems_tests: $(BUILD_SYSTEMS_TESTS:%=build_%_test)
[tests] convert ant integration test to a Makefile Summary: Time for this framework to die. This converts the ant test to a Makefile. The design is that each test or family of tests will have its own directory. Do the necessary plumbing from the toplevel Makefile so that `make test` runs the migrated tests. Reviewed By: jberdine Differential Revision: D4106298 fbshipit-source-id: 7bd694d
8 years ago
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
.PHONY: endtoend_test
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
endtoend_test: $(BUILD_SYSTEMS_TESTS:%=build_%_test) $(DIRECT_TESTS:%=direct_%_test)
add files lost in sync with internal repo
9 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: check_missing_mli
add files lost in sync with internal repo
9 years ago
check_missing_mli:
Convert Reason to OCaml, and auto-format OCaml Summary: Conversion and reformat of infer source using ocamlformat auto-formatting tool. Current status: - Because Reason does not handle docstrings, the output of the conversion is not 'Warning 50'-clean, meaning that there are docstrings with ambiguous placement. I'll need to manually fix them just before landing. Reviewed By: jvillard Differential Revision: D5225546 fbshipit-source-id: 3bd2786
7 years ago
$(QUIET)for x in $$(find $(INFER_DIR)/src -name "*.ml"); do \
[tests] Convert java tests to avoid phony targets Summary: This diff revises the makefiles for java tests so that they are based on the files actually produced and depended on, instead of the existing imperative style. This is, I think, clearer and easier to modify, and enables a little more parallelism. Reviewed By: jvillard Differential Revision: D4072560 fbshipit-source-id: c16d4bd
8 years ago
test -f "$$x"i || echo Missing "$$x"i; done
add files lost in sync with internal repo
9 years ago
[linter] Make checkCopyright indep of Utils, and fix build Summary: This diff ports checkCopyright to Core, builds it separately from other executables, and fixes the build command in the linter. Reviewed By: jvillard Differential Revision: D4148217 fbshipit-source-id: 8aefc98
8 years ago
.PHONY: checkCopyright
[jbuilder] turn I{Std,List} and atd-generated files into libraries Summary: This simplifies the jbuild files: no need to list these files explicitly anymore, nor to exclude them explicitly from the main `InferModules` library (due to their different compilation flags). Isolate common parts into jbuild.common do `cat`-based code inclusion into jbuild files to factorize code. Reviewed By: jberdine Differential Revision: D5678328 fbshipit-source-id: 6d7d925
7 years ago
checkCopyright: src_build_common
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)$(call silent_on_success,Building checkCopyright,\
$(MAKE) -C $(SRC_DIR) checkCopyright)
[linter] Make checkCopyright indep of Utils, and fix build Summary: This diff ports checkCopyright to Core, builds it separately from other executables, and fixes the build command in the linter. Reviewed By: jvillard Differential Revision: D4148217 fbshipit-source-id: 8aefc98
8 years ago
Validate skel less often since it is slow Reviewed By: akotulski Differential Revision: D4375563 fbshipit-source-id: bc432d4
8 years ago
.PHONY: validate-skel
validate-skel:
ifeq ($(IS_FACEBOOK_TREE),yes)
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)$(call silent_on_success,Validating facebook/,\
$(MAKE) -C facebook validate)
Validate skel less often since it is slow Reviewed By: akotulski Differential Revision: D4375563 fbshipit-source-id: bc432d4
8 years ago
endif
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
.PHONY: crash_if_not_all_analyzers_enabled
crash_if_not_all_analyzers_enabled:
ifneq ($(BUILD_C_ANALYZERS)+$(BUILD_JAVA_ANALYZERS),yes+yes)
ifneq ($(BUILD_C_ANALYZERS),yes)
@echo '*** ERROR: Cannot run the full tests: the Clang analyzers are disabled.'
@echo '*** ERROR: You can run clang-only tests with:'
@echo '*** ERROR:'
@echo '*** ERROR: make config_tests'
@echo '*** ERROR:'
endif
ifneq ($(BUILD_JAVA_ANALYZERS),yes)
@echo '*** ERROR: Cannot run the full tests: the Java analyzers are disabled.'
@echo '*** ERROR: You can run Java-only tests with:'
@echo '*** ERROR:'
@echo '*** ERROR: make config_tests'
@echo '*** ERROR:'
endif
@echo '*** ERROR: To run the full set of tests, please enable all the analyzers.'
@exit 1
else
@:
endif
Validate skel less often since it is slow Reviewed By: akotulski Differential Revision: D4375563 fbshipit-source-id: bc432d4
8 years ago
[make] add mod_dep target to parallelise test Summary: This takes several seconds and is better tested in parallel with the other tests instead of at the end. Reviewed By: mbouaziz Differential Revision: D5591774 fbshipit-source-id: f474cae
7 years ago
.PHONY: mod_dep
mod_dep: src_build_common
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)$(call silent_on_success,Building Infer source dependency graph,\
$(MAKE) -C $(SRC_DIR) mod_dep.dot)
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
[build] Generate sources from atd using dune (but not FCP atds yet) Summary: Next step in moving logic from make to dune. Since dune understands build rules with multiple targets we don't need to introduce artificial pipelining as in make. Rules are pretty straightforward, albeit somewhat verbose. The tricky part here was adjusting deadcode detection. Reviewed By: jvillard Differential Revision: D20322605 fbshipit-source-id: 688e5f96f
5 years ago
# `test_build` and `src_build` (which is a dependency of `endtoend_test`) should not be run in
# parallel since they build infer with different profiles (and therefore conflict). Therefore,
# `test_build` is in the dependency, and `endtoend_test` in the recipe.
[make] add mod_dep target to parallelise test Summary: This takes several seconds and is better tested in parallel with the other tests instead of at the end. Reviewed By: mbouaziz Differential Revision: D5591774 fbshipit-source-id: f474cae
7 years ago
.PHONY: config_tests
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
config_tests: test_build ocaml_unit_test validate-skel mod_dep
$(MAKE) endtoend_test checkCopyright
[build] Add `manuals` make target Summary: Manuals were previously built as part of `make test`, but `test` takes too long so `make manuals` is a convenient replacement. Reviewed By: ngorogiannis Differential Revision: D20517145 fbshipit-source-id: 404c9921f
5 years ago
$(MAKE) manuals
[make] add mod_dep target to parallelise test Summary: This takes several seconds and is better tested in parallel with the other tests instead of at the end. Reviewed By: mbouaziz Differential Revision: D5591774 fbshipit-source-id: f474cae
7 years ago
[help] implement `--write-website` Summary: Write documentation for all documented issue types and all user-facing checkers in the "next" version of the documentation. Next diff shows the new website. Reviewed By: dulmarod Differential Revision: D21934370 fbshipit-source-id: 53315d2b4
5 years ago
ifneq ($(filter endtoend_test,$(MAKECMDGOALS)),)
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
checkCopyright: src_build
toplevel_test: checkCopyright
[make] better way of limiting concurrency and better jbuilder concurrency Summary: This gets rid of the horrible hack of asking jbuilder to build _build/{default,test}/.ppx/ppx_compare/ppx.exe prior to starting several jbuilds in parallel. We now refrain from starting several jbuilds in parallel. Also, I finally understood that order-only deps do nothing for phony targets, and not much else for non-phony ones. I hate make even more. Reviewed By: jberdine Differential Revision: D5678699 fbshipit-source-id: 52179e8
7 years ago
endif
[build] fail early if running `make test` with only some analyzers, add `make config_tests` Summary: We shouldn't encourage contributors to run only a subset of the tests with `make test`, but it's more helpful to complain clearly should they try to do so. Now `make test` will ensure that both the clang and the Java analyzers are enabled, otherwise it will refuse to run and suggest to run `make config_tests` instead. It can still be useful to be able to run only the Java or Clang tests. The diff also fixes the cases where that previously failed. Fixes #634 Reviewed By: jberdine Differential Revision: D4826515 fbshipit-source-id: 4b76029
8 years ago
.PHONY: test
test: crash_if_not_all_analyzers_enabled config_tests
[infer][tests] Print a message when all tests are passing Summary: This message should be printed in the standard output once all the tests have passed which makes it easier to dinstinguish the cases when some tests fail from the cases where all tests are fine. Reviewed By: sblackshear Differential Revision: D4150022 fbshipit-source-id: 6be39c2
8 years ago
ifeq (,$(findstring s,$(MAKEFLAGS)))
[tests] awesomize make output Summary: Hide the output of all the toplevel `make` actions and print messages instead, as if we had a better build system than Makefiles. When a command fails, print its stdout and stderr and prefix it with bold red letters. Also display timing information. ``` $ make -j 4 test [17:39:18][27290] Facebook setup... [17:39:18][27363] Building checkCopyright... [17:39:18][27443] Validating facebook/... [ 0s][27363] SUCCESS Building checkCopyright [ 0s][27290] SUCCESS Facebook setup [17:39:18][27863] Building clang plugin... [ 0s][27443] SUCCESS Validating facebook/ [ 0s][27863] SUCCESS Building clang plugin [17:39:18][27898] Building clang plugin OCaml interface... [ 0s][27898] SUCCESS Building clang plugin OCaml interface [17:39:18][27974] Testing Infer builds without warnings... [17:39:18][28033] Building native Infer... [ 12s][27974] SUCCESS Testing Infer builds without warnings [17:39:30][28998] Testing Infer toplevel builds... [ 6s][28998] SUCCESS Testing Infer toplevel builds [17:39:36][31417] Running OCaml unit tests... [17:39:36][31456] Testing infer OCaml REPL... [ 6s][31417] SUCCESS Running OCaml unit tests [ 9s][31456] SUCCESS Testing infer OCaml REPL [ 92s][28033] SUCCESS Building native Infer [17:40:50][ 2170] Building Java annotations... [ 0s][ 2170] SUCCESS Building Java annotations [17:40:50][ 2186] Building Infer models... [ 11s][ 2186] SUCCESS Building Infer models [17:41:01][ 2803] Running build assembly test... [17:41:01][ 2861] Running build ck analytics test... [17:41:01][ 2941] Running build ck imports test... [17:41:01][ 3035] Running build clang compilation db escaped test... [ 1s][ 3035] SUCCESS Running build clang compilation db escaped test [17:41:02][ 3139] Running build clang compilation db relpath test... [ 3s][ 2861] SUCCESS Running build ck analytics test [17:41:04][ 3296] Running build clang multiple files test... [*ERROR**][2803] *** ERROR Running build assembly test [*ERROR**][2803] *** command: ( make INTERACTIVE=1 -C /home/jul/infer/infer/tests/build_systems/assembly test 2> >(grep -v warning: (ignoring old|overriding) (commands|recipe) for target) ; exit 0) [*ERROR**][2803] *** CWD: /home/jul/infer [*ERROR**][2803] *** stdout: [*ERROR**][2803] make[1]: Entering directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] *** inner Testing infer/clang in build_systems/assembly [*ERROR**][2803] *** inner command: /home/jul/infer/infer/bin/infer --results-dir infer-out --dump-duplicate-symbols --report-custom-error --developer-mode --project-root ../codetoanalyze --no-failures-allowed -a infer -- clang -c ../codetoanalyze/example.S ../codetoanalyze/hello.c [*ERROR**][2803] *** inner CWD: /home/jul/infer/infer/tests/build_systems/assembly [*ERROR**][2803] Capturing in make/cc mode... [*ERROR**][2803] Starting analysis... [*ERROR**][2803] [*ERROR**][2803] legend: [*ERROR**][2803] "F" analyzing a file [*ERROR**][2803] "." analyzing a procedure [*ERROR**][2803] [*ERROR**][2803] Found 1 (out of 1) source files to be analyzed in /home/jul/infer/infer/tests/build_systems/assembly/infer-out [*ERROR**][2803] [*ERROR**][2803] [*ERROR**][2803] No issues found [*ERROR**][2803] [*ERROR**][2803] ../../infer.make:30: recipe for target 'test' failed [*ERROR**][2803] make[1]: Leaving directory '/home/jul/infer/infer/tests/build_systems/assembly' [*ERROR**][2803] F.--- build_systems/assembly/issues.exp 2017-03-22 16:25:44.583854270 +0000 [*ERROR**][2803] +++ build_systems/assembly/issues.exp.test 2017-03-28 17:41:04.743678254 +0100 [*ERROR**][2803] @@ -1 +0,0 @@ [*ERROR**][2803] -hello.c, test, 2, NULL_DEREFERENCE, [start of procedure test()] [*ERROR**][2803] [*ERROR**][2803] Test output (build_systems/assembly/issues.exp.test) differs from expected test output build_systems/assembly/issues.exp [*ERROR**][2803] Run the following command to replace the expected test output with the new output: [*ERROR**][2803] [*ERROR**][2803] make -C build_systems/assembly replace [*ERROR**][2803] [*ERROR**][2803] make[1]: *** [test] Error 1 [*ERROR**][2803] *** stderr: Makefile:230: recipe for target 'build_assembly_test' failed make: *** [build_assembly_test] Error 1 make: *** Waiting for unfinished jobs.... [...] ``` Reviewed By: jberdine Differential Revision: D4781857 fbshipit-source-id: cbce26d
8 years ago
$(QUIET)echo "$(TERM_INFO)ALL TESTS PASSED$(TERM_RESET)"
[infer][tests] Print a message when all tests are passing Summary: This message should be printed in the standard output once all the tests have passed which makes it easier to dinstinguish the cases when some tests fail from the cases where all tests are fine. Reviewed By: sblackshear Differential Revision: D4150022 fbshipit-source-id: 6be39c2
8 years ago
endif
[tests] Convert java tests to avoid phony targets Summary: This diff revises the makefiles for java tests so that they are based on the files actually produced and depended on, instead of the existing imperative style. This is, I think, clearer and easier to modify, and enables a little more parallelism. Reviewed By: jvillard Differential Revision: D4072560 fbshipit-source-id: c16d4bd
8 years ago
.PHONY: test-replace
[clang plugin] bump version to include tests fix Summary: Also changes `clang_plugin_test` so that it also runs the clang-ocaml tests, and add a new `clang_plugin_test_replace` target. The controller you requested could not be found.: facebook-clang-plugins Reviewed By: jberdine Differential Revision: D10141902 fbshipit-source-id: 927c55a4f
6 years ago
test-replace: $(BUILD_SYSTEMS_TESTS:%=build_%_replace) $(DIRECT_TESTS:%=direct_%_replace) \
clang_plugin_test_replace
[tests] Convert java tests to avoid phony targets Summary: This diff revises the makefiles for java tests so that they are based on the files actually produced and depended on, instead of the existing imperative style. This is, I think, clearer and easier to modify, and enables a little more parallelism. Reviewed By: jvillard Differential Revision: D4072560 fbshipit-source-id: c16d4bd
8 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: uninstall
add files lost in sync with internal repo
9 years ago
uninstall:
$(REMOVE_DIR) $(DESTDIR)$(libdir)/infer/
[make] do not delete /usr/bin/infer* on uninstall Summary: Also, fix typo to actually install the man pages. Fixes #920 Reviewed By: mbouaziz Differential Revision: D8075978 fbshipit-source-id: e94786d
7 years ago
$(REMOVE) $(DESTDIR)$(bindir)/infer
[make] install man pages Summary: `man infer` for the win! Reviewed By: mbouaziz Differential Revision: D5036764 fbshipit-source-id: 4567d24
8 years ago
$(REMOVE) $(INFER_COMMANDS:%=$(DESTDIR)$(bindir)/%)
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
$(REMOVE) $(foreach manual,$(INFER_GROFF_MANUALS_GZIPPED),\
[make] install man pages Summary: `man infer` for the win! Reviewed By: mbouaziz Differential Revision: D5036764 fbshipit-source-id: 4567d24
8 years ago
$(DESTDIR)$(mandir)/man1/$(notdir $(manual)))
[make] do not delete /usr/bin/infer* on uninstall Summary: Also, fix typo to actually install the man pages. Fixes #920 Reviewed By: mbouaziz Differential Revision: D8075978 fbshipit-source-id: e94786d
7 years ago
ifeq ($(IS_FACEBOOK_TREE),yes)
$(MAKE) -C facebook uninstall
endif
add files lost in sync with internal repo
9 years ago
[tests] share javac.make more broadly Summary: - rename java.make -> javac.make, config.make -> java.make, and move to infer/tests/ so it's easier to use from infer/tests/build_systems/ - use these from ant's test Makefile, much code reuse! - factor out common functionality between java and clang A wrinkle: sorting is now done the same way for --issues-tests and --issues-txt, which produces bogus (but still as deterministic) sorting for --issues-txt. This is more of a cosmetic issue, but I hope to fix it in a later diff that gets rid of calls to `sort` in favour of sorting directly from `InferPrint`. Reviewed By: jberdine Differential Revision: D4166841 fbshipit-source-id: ed6f232
8 years ago
.PHONY: test_clean
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
test_clean: $(DIRECT_TESTS:%=direct_%_clean) $(BUILD_SYSTEMS_TESTS:%=build_%_clean)
[tests] share javac.make more broadly Summary: - rename java.make -> javac.make, config.make -> java.make, and move to infer/tests/ so it's easier to use from infer/tests/build_systems/ - use these from ant's test Makefile, much code reuse! - factor out common functionality between java and clang A wrinkle: sorting is now done the same way for --issues-tests and --issues-txt, which produces bogus (but still as deterministic) sorting for --issues-txt. This is more of a cosmetic issue, but I hope to fix it in a later diff that gets rid of calls to `sort` in favour of sorting directly from `InferPrint`. Reviewed By: jberdine Differential Revision: D4166841 fbshipit-source-id: ed6f232
8 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: install
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
install: infer $(INFER_GROFF_MANUALS_GZIPPED)
add files lost in sync with internal repo
9 years ago
# create directory structure
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
test -d '$(DESTDIR)$(bindir)' || \
$(MKDIR_P) '$(DESTDIR)$(bindir)'
test -d '$(DESTDIR)$(mandir)/man1' || \
$(MKDIR_P) '$(DESTDIR)$(mandir)/man1'
test -d '$(DESTDIR)$(libdir)/infer/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/'
add files lost in sync with internal repo
9 years ago
ifeq ($(BUILD_C_ANALYZERS),yes)
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
test -d '$(DESTDIR)$(libdir)/infer/facebook-clang-plugins/libtooling/build/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/facebook-clang-plugins/libtooling/build/'
[release] install symlinks as symlinks Summary: The clang distribution uses symlinks in some places, which avoids copying rather large binaries. `make install` was replacing these with actual copies. Try not to be so wasteful anymore. Reviewed By: mbouaziz Differential Revision: D8260777 fbshipit-source-id: eccabab
7 years ago
find facebook-clang-plugins/clang/install/. -type d -print0 | xargs -0 -n 1 \
[make] fix `install` for xargs on osx Summary: This was meant to be part of D7569054 but the wrong version landed. classicblunder Reviewed By: mbouaziz Differential Revision: D7615865 fbshipit-source-id: a29b3af
7 years ago
$(SHELL) -x -c "test -d '$(DESTDIR)$(libdir)'/infer/\$$1 || \
$(MKDIR_P) '$(DESTDIR)$(libdir)'/infer/\$$1" --
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
test -d '$(DESTDIR)$(libdir)/infer/infer/lib/clang_wrappers/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/infer/lib/clang_wrappers/'
test -d '$(DESTDIR)$(libdir)/infer/infer/lib/linter_rules/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/infer/lib/linter_rules/'
test -d '$(DESTDIR)$(libdir)/infer/infer/etc/' || \
[objc] pass SDK config to plugin Summary: This makes the plugin follow infer's configuration. Reviewed By: martintrojer Differential Revision: D18595972 fbshipit-source-id: f685dd057
5 years ago
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/infer/etc'
add files lost in sync with internal repo
9 years ago
endif
ifeq ($(BUILD_JAVA_ANALYZERS),yes)
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
test -d '$(DESTDIR)$(libdir)/infer/infer/lib/java/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/infer/lib/java/'
endif
test -d '$(DESTDIR)$(libdir)/infer/infer/annotations/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/infer/annotations/'
test -d '$(DESTDIR)$(libdir)/infer/infer/lib/wrappers/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/infer/lib/wrappers/'
test -d '$(DESTDIR)$(libdir)/infer/infer/lib/specs/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/infer/lib/specs/'
test -d '$(DESTDIR)$(libdir)/infer/infer/bin/' || \
$(MKDIR_P) '$(DESTDIR)$(libdir)/infer/infer/bin/'
add files lost in sync with internal repo
9 years ago
# copy files
ifeq ($(BUILD_C_ANALYZERS),yes)
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
$(INSTALL_DATA) -C 'facebook-clang-plugins/libtooling/build/FacebookClangPlugin.dylib' \
'$(DESTDIR)$(libdir)/infer/facebook-clang-plugins/libtooling/build/FacebookClangPlugin.dylib'
[release] install symlinks as symlinks Summary: The clang distribution uses symlinks in some places, which avoids copying rather large binaries. `make install` was replacing these with actual copies. Try not to be so wasteful anymore. Reviewed By: mbouaziz Differential Revision: D8260777 fbshipit-source-id: eccabab
7 years ago
# do not use "install" for symbolic links as this will copy the destination file instead
find facebook-clang-plugins/clang/install/. -not -type d -not -type l -not -name '*.a' -print0 \
[make] do not install clang archive libraries Summary: They are not needed to run clang and our clang plugin. Reviewed By: mbouaziz Differential Revision: D8076205 fbshipit-source-id: 450e816
7 years ago
| xargs -0 -I \{\} $(INSTALL_PROGRAM) -C \{\} '$(DESTDIR)$(libdir)'/infer/\{\}
[release] install symlinks as symlinks Summary: The clang distribution uses symlinks in some places, which avoids copying rather large binaries. `make install` was replacing these with actual copies. Try not to be so wasteful anymore. Reviewed By: mbouaziz Differential Revision: D8260777 fbshipit-source-id: eccabab
7 years ago
# all the symlinks in clang are relative and safe to brutally copy over
find facebook-clang-plugins/clang/install/. -type l -not -name '*.a' -print0 \
| xargs -0 -I \{\} $(COPY) -a \{\} '$(DESTDIR)$(libdir)'/infer/\{\}
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
find infer/lib/clang_wrappers/* -print0 | xargs -0 -I \{\} \
$(INSTALL_PROGRAM) -C \{\} '$(DESTDIR)$(libdir)'/infer/\{\}
[make] do not install clang archive libraries Summary: They are not needed to run clang and our clang plugin. Reviewed By: mbouaziz Differential Revision: D8076205 fbshipit-source-id: 450e816
7 years ago
# only for files that point to infer
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
(cd '$(DESTDIR)$(libdir)/infer/infer/lib/wrappers/' && \
$(foreach cc,$(shell find '$(LIB_DIR)/wrappers' -type l), \
[ $(cc) -ef '$(INFER_BIN)' ] && \
$(REMOVE) '$(notdir $(cc))' && \
$(LN_S) ../../bin/infer '$(notdir $(cc))';))
find infer/lib/specs/* -print0 | xargs -0 -I \{\} \
$(INSTALL_DATA) -C \{\} '$(DESTDIR)$(libdir)'/infer/\{\}
$(INSTALL_DATA) -C 'infer/lib/linter_rules/linters.al' \
'$(DESTDIR)$(libdir)/infer/infer/lib/linter_rules/linters.al'
$(INSTALL_DATA) -C 'infer/etc/clang_ast.dict' \
'$(DESTDIR)$(libdir)/infer/infer/etc/clang_ast.dict'
add files lost in sync with internal repo
9 years ago
endif
ifeq ($(BUILD_JAVA_ANALYZERS),yes)
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
$(INSTALL_DATA) -C 'infer/annotations/annotations.jar' \
'$(DESTDIR)$(libdir)/infer/infer/annotations/annotations.jar'
find infer/lib/java/*.jar -print0 | xargs -0 -I \{\} \
$(INSTALL_DATA) -C \{\} '$(DESTDIR)$(libdir)'/infer/\{\}
$(INSTALL_PROGRAM) -C '$(LIB_DIR)'/wrappers/javac \
'$(DESTDIR)$(libdir)'/infer/infer/lib/wrappers/
endif
$(INSTALL_PROGRAM) -C '$(INFER_BIN)' '$(DESTDIR)$(libdir)'/infer/infer/bin/
(cd '$(DESTDIR)$(bindir)/' && \
add files lost in sync with internal repo
9 years ago
$(REMOVE) infer && \
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
$(LN_S) '$(libdir_relative_to_bindir)'/infer/infer/bin/infer infer)
[CLI] switch to infer-<command> (symlinks) executables Summary: Introduce `infer-<command>` for each command, except for internal commands (only `infer-clang` for now) which are not exported. Install these executables (which are just symlinks to `infer`) on `make install`. The main executable looks at the name it was invoked with to figure out if it should behave as a particular command. Get rid of `InferClang`, `InferAnalyze`, and `InferPrint`. As a bonus, we now only need to build one executable: `infer`, which should be a few seconds faster (less link time). `InferAnalyze` is now `infer-analyze` and `InferPrint` is `infer-print`. To run `InferClang`, use a symlink named `clang`, `clang++`, etc. to `infer`. There are such symlinks available in "infer/lib/wrappers/" already. I also noticed that the scripts in xcodebuild_wrappers/ don't seem useful anymore, so use wrappers/ instead, as for `make`. Reviewed By: mbouaziz Differential Revision: D5036495 fbshipit-source-id: 4a90030
8 years ago
for alias in $(INFER_COMMANDS); do \
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
(cd '$(DESTDIR)$(bindir)'/ && \
$(REMOVE) "$$alias" && \
$(LN_S) infer "$$alias"); done
[CLI] switch to infer-<command> (symlinks) executables Summary: Introduce `infer-<command>` for each command, except for internal commands (only `infer-clang` for now) which are not exported. Install these executables (which are just symlinks to `infer`) on `make install`. The main executable looks at the name it was invoked with to figure out if it should behave as a particular command. Get rid of `InferClang`, `InferAnalyze`, and `InferPrint`. As a bonus, we now only need to build one executable: `infer`, which should be a few seconds faster (less link time). `InferAnalyze` is now `infer-analyze` and `InferPrint` is `infer-print`. To run `InferClang`, use a symlink named `clang`, `clang++`, etc. to `infer`. There are such symlinks available in "infer/lib/wrappers/" already. I also noticed that the scripts in xcodebuild_wrappers/ don't seem useful anymore, so use wrappers/ instead, as for `make`. Reviewed By: mbouaziz Differential Revision: D5036495 fbshipit-source-id: 4a90030
8 years ago
for alias in $(INFER_COMMANDS); do \
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
(cd '$(DESTDIR)$(libdir)'/infer/infer/bin && \
$(REMOVE) "$$alias" && \
$(LN_S) infer "$$alias"); done
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
$(foreach man,$(INFER_GROFF_MANUALS_GZIPPED), \
[make] do not delete /usr/bin/infer* on uninstall Summary: Also, fix typo to actually install the man pages. Fixes #920 Reviewed By: mbouaziz Differential Revision: D8075978 fbshipit-source-id: e94786d
7 years ago
$(INSTALL_DATA) -C $(man) '$(DESTDIR)$(mandir)/man1/$(notdir $(man))';)
move internal scripts around and add install target Reviewed By: akotulski Differential Revision: D3392550 fbshipit-source-id: 326ebdc
9 years ago
ifeq ($(IS_FACEBOOK_TREE),yes)
[make] fix `install` for xargs on osx Summary: This was meant to be part of D7569054 but the wrong version landed. classicblunder Reviewed By: mbouaziz Differential Revision: D7615865 fbshipit-source-id: a29b3af
7 years ago
ifdef DESTDIR
ifeq (,$(findstring :/,:$(DESTDIR)))
# DESTDIR is set and relative
$(MAKE) -C facebook install 'DESTDIR=../$(DESTDIR)'
else
# DESTDIR is set and absolute
$(MAKE) -C facebook install
endif
else
# DESTDIR not set
[make] make sure no command fails Summary: Run with `SHELL = bash -e -u -o pipefail` to catch many kinds of failures. We were silently failing during `make install` because of some missing escaping, and the failure was hidden because it was happening inside a bash `for` loop. This fixes the escaping issue and makes sure such issues will result in an error as of now. Also removes dangerous `find -exec` instances: `find` will `exit 0` event if some commands failed. Fixes #887 Reviewed By: mbouaziz Differential Revision: D7569054 fbshipit-source-id: 542fe50
7 years ago
$(MAKE) -C facebook install
move internal scripts around and add install target Reviewed By: akotulski Differential Revision: D3392550 fbshipit-source-id: 326ebdc
9 years ago
endif
[travis] fix travis and install Summary: `brew install opam` is unhappy and wants us to run `brew unlink python` beforehand so do that. The `make install` logic in infer had a problem of nested `if` logic. Reviewed By: da319 Differential Revision: D7686760 fbshipit-source-id: dd0c988
7 years ago
endif
move internal scripts around and add install target Reviewed By: akotulski Differential Revision: D3392550 fbshipit-source-id: 326ebdc
9 years ago
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
# Nuke objects built from OCaml. Useful when changing the OCaml compiler, for instance.
.PHONY: ocaml_clean
ocaml_clean:
add files lost in sync with internal repo
9 years ago
ifeq ($(BUILD_C_ANALYZERS),yes)
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Cleaning facebook-clang-plugins OCaml build,\
$(MAKE) -C $(FCP_DIR)/clang-ocaml clean)
add files lost in sync with internal repo
9 years ago
endif
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Cleaning infer OCaml build,\
$(MAKE) -C $(SRC_DIR) clean)
$(QUIET)$(call silent_on_success,Cleaning ocamldot,\
$(MAKE) -C $(DEPENDENCIES_DIR)/ocamldot clean)
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
.PHONY: clean
[make] do not call external build systems to clean Summary: `make clean` would fail calling `xcodebuild` to clean. It also calls `ant clean`. Instead, do the cleaning ourselves by deleting the appropriate stuff so that it's faster and more reliable. Also clean the OCaml build before cleaning the tests as that's what more important most of the time. Also don't delete the man pages as part of `make clean` as they are checked in. Also fix ant's Makefile so that the build points at the right .class files (the path to the .class files was wrong so `make -C infer/tests/build_systems/ant` would start `ant` for *each* file instead of once). Reviewed By: martintrojer Differential Revision: D13956218 fbshipit-source-id: bce27fe11
6 years ago
clean: ocaml_clean test_clean
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
ifeq ($(BUILD_C_ANALYZERS),yes)
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Cleaning facebook-clang-plugins C++ build,\
$(MAKE) -C $(FCP_DIR) clean)
[build] avoid race condition, and do not run atdgen twice, add ocaml_clean Summary: Fixes 2 issues with the build: - The OCaml dependencies (Version.ml, atdgen-generated stuff, ...) would be generated twice when running `make -j test` from a clean tree, because `make` has no inter-Makefile visibility over common dependencies. - We would run `atdgen` twice: once for the .ml, once for the .mli, even though one invocation is enough for both. Add `make ocaml_clean` to nuke only the OCaml code (in particular because rebuilding the C++ code in the plugin is slow when all I want to get rid of the OCaml stuff). Reviewed By: mbouaziz Differential Revision: D5415318 fbshipit-source-id: 16f42c6
7 years ago
endif
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Cleaning Java annotations,\
$(MAKE) -C $(ANNOTATIONS_DIR) clean)
$(QUIET)$(call silent_on_success,Cleaning infer models,\
$(MAKE) -C $(MODELS_DIR) clean)
do not use the FB-ONLY literal string in non-fb-only files Reviewed By: jberdine Differential Revision: D3399011 fbshipit-source-id: cb2558c
9 years ago
ifeq ($(IS_FACEBOOK_TREE),yes)
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Cleaning facebook/,\
$(MAKE) -C facebook clean)
do not use the FB-ONLY literal string in non-fb-only files Reviewed By: jberdine Differential Revision: D3399011 fbshipit-source-id: cb2558c
9 years ago
endif
[make] move inferTraceBugs tests to build systems, hide more output Summary: Cosmetic changes to the output of `make clean` and `make test-replace`. Run the inferTraceBugs tests from tests/build_systems/ like other such e2e tests, so that they can run in parallel with other tests instead of sequentially at the end. Reviewed By: dulmarod Differential Revision: D5526599 fbshipit-source-id: 57231bd
7 years ago
$(QUIET)$(call silent_on_success,Removing *.o and *.o.sh,\
find $(INFER_DIR)/tests \( -name '*.o' -o -name '*.o.sh' \) -delete)
$(QUIET)$(call silent_on_success,Removing build logs,\
[make] do not call external build systems to clean Summary: `make clean` would fail calling `xcodebuild` to clean. It also calls `ant clean`. Instead, do the cleaning ourselves by deleting the appropriate stuff so that it's faster and more reliable. Also clean the OCaml build before cleaning the tests as that's what more important most of the time. Also don't delete the man pages as part of `make clean` as they are checked in. Also fix ant's Makefile so that the build points at the right .class files (the path to the .class files was wrong so `make -C infer/tests/build_systems/ant` would start `ant` for *each* file instead of once). Reviewed By: martintrojer Differential Revision: D13956218 fbshipit-source-id: bce27fe11
6 years ago
$(REMOVE_DIR) _build_logs)
add files lost in sync with internal repo
9 years ago
[infer][build] Move the .PHONY declarations next the target declarations to more easily keep the two in sync Summary: Doing like this makes it easier to keep the phony declarations in sync with the target definitions Reviewed By: jvillard Differential Revision: D4067679 fbshipit-source-id: 723bc0e
8 years ago
.PHONY: conf-clean
add files lost in sync with internal repo
9 years ago
conf-clean: clean
$(REMOVE) .buckversion
[build] Do not remove Makefile.config in conf-clean Summary: Makefile.config is checked in, don't clean it. Reviewed By: jvillard Differential Revision: D15964240 fbshipit-source-id: bac38317e
6 years ago
$(REMOVE) Makefile.autoconf
add files lost in sync with internal repo
9 years ago
$(REMOVE) acinclude.m4
$(REMOVE) aclocal.m4
$(REMOVE_DIR) autom4te.cache/
$(REMOVE) config.log
$(REMOVE) config.status
$(REMOVE) configure
[tests] convert ant integration test to a Makefile Summary: Time for this framework to die. This converts the ant test to a Makefile. The design is that each test or family of tests will have its own directory. Do the necessary plumbing from the toplevel Makefile so that `make test` runs the migrated tests. Reviewed By: jberdine Differential Revision: D4106298 fbshipit-source-id: 7bd694d
8 years ago
$(REMOVE_DIR) $(MODELS_DIR)/c/out/
$(REMOVE_DIR) $(MODELS_DIR)/cpp/out/
$(REMOVE_DIR) $(MODELS_DIR)/java/infer-out/
$(REMOVE_DIR) $(MODELS_DIR)/objc/out/
add files lost in sync with internal repo
9 years ago
[opam] add `make opam.lock` target Summary: Useful to update opam package versions. Reviewed By: jberdine Differential Revision: D5190763 fbshipit-source-id: 225462e
8 years ago
# phony because it depends on opam's internal state
[setup] opam 2 Summary: Switches from opam 1 to opam 2. Opam2 has some cool new features that simplify some of the scripting. Notable changes: 1. Use the new `opam lock` *plugin* from https://github.com/AltGr/opam-lock/ instead of https://github.com/rgrinberg/opam-lock. This has a simpler interface for our purposes. 2. Change the way `./build-infer.sh` can be called to use an already existing switch: simply pass `--user-opam-switch` to the script and it won't attempt to create/set the current switch. This can be used to build infer in a local switch for instance. 3. Take advantage of automatic pinning where possible, eg to install infer deps without using opam.locked. Reviewed By: ngorogiannis Differential Revision: D13167863 fbshipit-source-id: 1a667c270
6 years ago
.PHONY: opam.locked
opam.locked: opam
[dune] upgrade to 1.1.1 Summary: This seems to fix intermittent "Corrupted compilation unit description" failures in the build: https://github.com/ocaml/dune/issues/1157 It also fixes build warnings 58: https://github.com/ocaml/dune/issues/1107 Reviewed By: mbouaziz Differential Revision: D9420579 fbshipit-source-id: d63adee67
6 years ago
# allow users to not force a run of opam update since it's very slow
ifeq ($(NO_OPAM_UPDATE),)
[opam] add `make opam.lock` target Summary: Useful to update opam package versions. Reviewed By: jberdine Differential Revision: D5190763 fbshipit-source-id: 225462e
8 years ago
$(QUIET)$(call silent_on_success,opam update,$(OPAM) update)
[dune] upgrade to 1.1.1 Summary: This seems to fix intermittent "Corrupted compilation unit description" failures in the build: https://github.com/ocaml/dune/issues/1157 It also fixes build warnings 58: https://github.com/ocaml/dune/issues/1107 Reviewed By: mbouaziz Differential Revision: D9420579 fbshipit-source-id: d63adee67
6 years ago
endif
[setup] opam 2 Summary: Switches from opam 1 to opam 2. Opam2 has some cool new features that simplify some of the scripting. Notable changes: 1. Use the new `opam lock` *plugin* from https://github.com/AltGr/opam-lock/ instead of https://github.com/rgrinberg/opam-lock. This has a simpler interface for our purposes. 2. Change the way `./build-infer.sh` can be called to use an already existing switch: simply pass `--user-opam-switch` to the script and it won't attempt to create/set the current switch. This can be used to build infer in a local switch for instance. 3. Take advantage of automatic pinning where possible, eg to install infer deps without using opam.locked. Reviewed By: ngorogiannis Differential Revision: D13167863 fbshipit-source-id: 1a667c270
6 years ago
$(QUIET)$(call silent_on_success,generating opam.locked,\
$(OPAM) lock .)
[opam] add `make opam.lock` target Summary: Useful to update opam package versions. Reviewed By: jberdine Differential Revision: D5190763 fbshipit-source-id: 225462e
8 years ago
@allow-large-files [ocaml] upgrade core to v13 Summary: More newer = more better. This flips the Not_found -> Not_found_s switch, and forbids a bunch more polymorphic comparisons (mostly turned into `int` comparisons for convenience). Earlier diffs prepare for this so this diff is only about breaking changes in the API, of which there are only a few. Reviewed By: jberdine Differential Revision: D19861583 fbshipit-source-id: fe54ce8f0
5 years ago
OPAM_DEV_DEPS = ocp-indent merlin utop webbrowser
[make] do not install tuareg if emacs is not found Summary: Tuareg is only useful for emacs, and `opam install tuareg` fails if emacs is not found. Reviewed By: mbouaziz Differential Revision: D6098693 fbshipit-source-id: 167628a
7 years ago
ifneq ($(EMACS),no)
OPAM_DEV_DEPS += tuareg
endif
[setup] add automatic setup for the developer environment Summary: Useful for hacking on infer, and when eg the default opam switch changes and one has to remember which development packages to install all over again (merlin, etc.). Reviewed By: mbouaziz Differential Revision: D5328701 fbshipit-source-id: 7b7694e
8 years ago
.PHONY: devsetup
devsetup: Makefile.autoconf
$(QUIET)[ $(OPAM) != "no" ] || (echo 'No `opam` found, aborting setup.' >&2; exit 1)
$(QUIET)$(call silent_on_success,installing $(OPAM_DEV_DEPS),\
OPAMSWITCH=$(OPAMSWITCH); $(OPAM) install --yes --no-checksum user-setup $(OPAM_DEV_DEPS))
$(QUIET)echo '$(TERM_INFO)*** Running `opam user-setup`$(TERM_RESET)' >&2
$(QUIET)OPAMSWITCH=$(OPAMSWITCH); OPAMYES=1; $(OPAM) user-setup install
[make][dev] install gnu-sed on osx Summary: Used by `make deadcode`. Reviewed By: mbouaziz, dulmarod Differential Revision: D6845536 fbshipit-source-id: 79dda5b
7 years ago
$(QUIET)if [ "$(PLATFORM)" = "Darwin" ] && [ x"$(GNU_SED)" = x"no" ]; then \
echo '$(TERM_INFO)*** Installing GNU sed$(TERM_RESET)' >&2; \
brew install gnu-sed; \
fi
[ocamlformat] Install and use GNU instead of Tollef parallel Reviewed By: jeremydubreil Differential Revision: D5401598 fbshipit-source-id: 5cddc65
7 years ago
$(QUIET)if [ "$(PLATFORM)" = "Darwin" ] && ! $$(parallel -h | grep -q GNU); then \
echo '$(TERM_INFO)*** Installing GNU parallel$(TERM_RESET)' >&2; \
brew install parallel; \
fi
$(QUIET)if [ ! -d "$$HOME"/.parallel ]; then mkdir "$$HOME"/.parallel; fi
$(QUIET)touch "$$HOME"/.parallel/will-cite
[setup] add automatic setup for the developer environment Summary: Useful for hacking on infer, and when eg the default opam switch changes and one has to remember which development packages to install all over again (merlin, etc.). Reviewed By: mbouaziz Differential Revision: D5328701 fbshipit-source-id: 7b7694e
8 years ago
# expand all occurrences of "~" in PATH and MANPATH
$(QUIET)infer_repo_is_in_path=$$(echo $${PATH//\~/$$HOME} | grep -q "$(ABSOLUTE_ROOT_DIR)"/infer/bin; echo $$?); \
infer_repo_is_in_manpath=$$(echo $${MANPATH//\~/$$HOME} | grep -q "$(ABSOLUTE_ROOT_DIR)"/infer/man; echo $$?); \
[make] fix `make devsetup` Summary: Making the shell stricter revealed a bug in `make devsetup`: `shell_config_file` can be used without being initialised. Also, the error path when testing if `BUILD_MODE` was set to default was wrong and would execute all except the first `echo` command unconditionally. I changed the test so that it tests only if `BUILD_MODE` is set in the environment. Reviewed By: martinoluca Differential Revision: D7615333 fbshipit-source-id: 08c5eb0
7 years ago
shell_config_file="<could not auto-detect, please fill in yourself>"; \
if [ $$(basename "$(ORIG_SHELL)") = "bash" ]; then \
if [ "$(PLATFORM)" = "Linux" ]; then \
shell_config_file="$$HOME"/.bashrc; \
else \
shell_config_file="$$HOME"/.bash_profile; \
[setup] add automatic setup for the developer environment Summary: Useful for hacking on infer, and when eg the default opam switch changes and one has to remember which development packages to install all over again (merlin, etc.). Reviewed By: mbouaziz Differential Revision: D5328701 fbshipit-source-id: 7b7694e
8 years ago
fi; \
[make] fix `make devsetup` Summary: Making the shell stricter revealed a bug in `make devsetup`: `shell_config_file` can be used without being initialised. Also, the error path when testing if `BUILD_MODE` was set to default was wrong and would execute all except the first `echo` command unconditionally. I changed the test so that it tests only if `BUILD_MODE` is set in the environment. Reviewed By: martinoluca Differential Revision: D7615333 fbshipit-source-id: 08c5eb0
7 years ago
elif [ $$(basename "$(ORIG_SHELL)") = "zsh" ]; then \
shell_config_file="$$HOME"/.zshrc; \
fi; \
if [ "$$infer_repo_is_in_path" != "0" ] || [ "$$infer_repo_is_in_manpath" != "0" ]; then \
[setup] add automatic setup for the developer environment Summary: Useful for hacking on infer, and when eg the default opam switch changes and one has to remember which development packages to install all over again (merlin, etc.). Reviewed By: mbouaziz Differential Revision: D5328701 fbshipit-source-id: 7b7694e
8 years ago
echo >&2; \
echo '$(TERM_INFO)*** NOTE: `infer` is not in your PATH or MANPATH. If you are hacking on infer, you may$(TERM_RESET)' >&2; \
echo '$(TERM_INFO)*** NOTE: want to make infer executables and manuals available in your terminal. Type$(TERM_RESET)' >&2; \
echo '$(TERM_INFO)*** NOTE: the following commands to configure the current terminal and record the$(TERM_RESET)' >&2; \
printf '$(TERM_INFO)*** NOTE: changes in your shell configuration file (%s):$(TERM_RESET)\n' "$$shell_config_file">&2; \
echo >&2; \
if [ "$$infer_repo_is_in_path" != "0" ]; then \
printf '$(TERM_INFO) export PATH="%s/infer/bin":$$PATH$(TERM_RESET)\n' "$(ABSOLUTE_ROOT_DIR)" >&2; \
fi; \
if [ "$$infer_repo_is_in_manpath" != "0" ]; then \
printf '$(TERM_INFO) export MANPATH="%s/infer/man":$$MANPATH$(TERM_RESET)\n' "$(ABSOLUTE_ROOT_DIR)" >&2; \
fi; \
if [ "$$infer_repo_is_in_path" != "0" ]; then \
[setup] always reset terminal mode Reviewed By: akotulski Differential Revision: D5364078 fbshipit-source-id: d438173
8 years ago
printf "$(TERM_INFO) echo 'export PATH=\"%s/infer/bin\":\$$PATH' >> \"$$shell_config_file\"$(TERM_RESET)\n" "$(ABSOLUTE_ROOT_DIR)" >&2; \
[setup] add automatic setup for the developer environment Summary: Useful for hacking on infer, and when eg the default opam switch changes and one has to remember which development packages to install all over again (merlin, etc.). Reviewed By: mbouaziz Differential Revision: D5328701 fbshipit-source-id: 7b7694e
8 years ago
fi; \
if [ "$$infer_repo_is_in_manpath" != "0" ]; then \
[setup] always reset terminal mode Reviewed By: akotulski Differential Revision: D5364078 fbshipit-source-id: d438173
8 years ago
printf "$(TERM_INFO) echo 'export MANPATH=\"%s/infer/man\":\$$MANPATH' >> \"$$shell_config_file\"$(TERM_RESET)\n" "$(ABSOLUTE_ROOT_DIR)" >&2; \
[setup] add automatic setup for the developer environment Summary: Useful for hacking on infer, and when eg the default opam switch changes and one has to remember which development packages to install all over again (merlin, etc.). Reviewed By: mbouaziz Differential Revision: D5328701 fbshipit-source-id: 7b7694e
8 years ago
fi; \
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
fi; \
[make] fix `make devsetup` Summary: Making the shell stricter revealed a bug in `make devsetup`: `shell_config_file` can be used without being initialised. Also, the error path when testing if `BUILD_MODE` was set to default was wrong and would execute all except the first `echo` command unconditionally. I changed the test so that it tests only if `BUILD_MODE` is set in the environment. Reviewed By: martinoluca Differential Revision: D7615333 fbshipit-source-id: 08c5eb0
7 years ago
if [ -z "$(ORIG_SHELL_BUILD_MODE)" ]; then \
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
echo >&2; \
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
echo '$(TERM_INFO)*** NOTE: Set `BUILD_MODE=dev` in your shell to disable flambda by default.$(TERM_RESET)' >&2; \
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
echo '$(TERM_INFO)*** NOTE: Compiling with flambda is ~5 times slower than without, so unless you are$(TERM_RESET)' >&2; \
echo '$(TERM_INFO)*** NOTE: testing infer on a very large project it will not be worth it. Use the$(TERM_RESET)' >&2; \
[make] fix `make devsetup` Summary: Making the shell stricter revealed a bug in `make devsetup`: `shell_config_file` can be used without being initialised. Also, the error path when testing if `BUILD_MODE` was set to default was wrong and would execute all except the first `echo` command unconditionally. I changed the test so that it tests only if `BUILD_MODE` is set in the environment. Reviewed By: martinoluca Differential Revision: D7615333 fbshipit-source-id: 08c5eb0
7 years ago
echo '$(TERM_INFO)*** NOTE: commands below to set the default build mode. You can then use `make opt`$(TERM_RESET)' >&2; \
[build] switch to 4.05.0+flambda by default Summary: With flambda (`-O3`), compilation time is ~5x slower, but the backend is ~25% faster! To mitigate the atrocious compilation times, introduce a new `opt` build mode in the jbuilder files. - build in "opt" mode by default from the toplevel (so that install scripts and external users get the fastest infer by default), in "default" mode by default from infer/src (since the latter is only called directly by infer devs, for faster builds) - `make byte` is as fast as before in any mode - `make test` will build "opt" by default, which is very slow. Solution for testing (or building the models) locally: `make BUILD_MODE=default test`. - You can even change the default locally with `export BUILD_MODE=default`. The benchmarks are to be taken with a sizable pinch of salt because I ran them only once and other stuff could be running in the background. That said, the perf win is consistent across all projects, with 15-20% win in wallclock time and around 25% win in total CPU time, ~9% win in sys time, and ~25% fewer minor allocations, and ~5-10% fewer overall allocations. This is only for the backend; the capture is by and large unaffected (either the same or a tad faster within noise range). Here are the results running on OpenSSL 1.0.2d on osx (12 cores, 32G RAM) === base infer binary: 26193088 bytes compile time: 40s capture: ```lang=text real 1m7.513s user 3m11.437s sys 0m55.236s ``` analysis: ```lang=text real 5m41.580s user 61m37.855s sys 1m12.870s ``` Memory profile: ```lang=json { ... "minor_gb": 0.1534719169139862, "promoted_gb": 0.0038930922746658325, "major_gb": 0.4546157643198967, "allocated_gb": 0.6041945889592171, "minor_collections": 78, "major_collections": 23, "compactions": 7, "top_heap_gb": 0.07388687133789062, "stack_kb": 0.3984375, "minor_heap_kb": 8192.0, ... } ``` === flambda with stock options (no `-Oclassic`, just the same flags as base) Exactly the same as base. === flambda `-O3` infer binary: 56870376 bytes (2.17x bigger) compile time: 191s (4.78x slower) capture is the same as base: ```lang=text real 1m9.203s user 3m12.242s sys 0m58.905s ``` analysis is ~20% wallclock time faster, ~25% CPU time faster: ```lang=text real 4m32.656s user 46m43.987s sys 1m2.424s ``` memory usage is a bit lower too: ```lang=json { ... "minor_gb": 0.11583046615123749, // 75% of previous "promoted_gb": 0.00363825261592865, // 93% of previous "major_gb": 0.45415670424699783, // about same "allocated_gb": 0.5663489177823067, // 94% of previous "minor_collections": 73, "major_collections": 22, "compactions": 7, "top_heap_gb": 0.07165145874023438, "stack_kb": 0.3359375, "minor_heap_kb": 8192.0, ... } ``` === flambda `-O2` Not nearly as exciting as `-O3`, but the compilation cost is still quite high: infer: 37826856 bytes compilation of infer: 100s Capture and analysis timings are mostly the same as base. Reviewed By: jberdine Differential Revision: D4867979 fbshipit-source-id: 99230b7
7 years ago
echo '$(TERM_INFO)*** NOTE: when you really do want to enable flambda.$(TERM_RESET)' >&2; \
echo >&2; \
[RFC][build] Use dune environments and profiles instead of contexts Summary: With profiles and `(env ...)` stanza it's possible to consolidate various ocamlc/ocamlopt/etc setups in a single place. Where previously we needed to append `dune.common` to every dune file and specify `flags` and `ocamlopt_flags` now the flags are specified in `env` and applied accross the board. This allows to 1. simplify build definitions, 2. avoid the need to generate dune files, 3. use plain sexps instead of OCaml and JBuilder plugin in build files. (I'll try to address 2 and 3 in the followup patches). Existing `make` targets should continue working as before. Also, we can use dune CLI like so: ``` infer/src$ dune printenv --profile opt # <- very useful for introspection infer/src$ dune build check infer/src$ dune build check --profile test infer/src$ dune build infer.exe --profile dev infer/src$ dune build infer.exe --profile opt ``` Also, with just 1 context something like `dune runtest` will run unit tests only once instead of N times, where N is the number of contexts. Now, there's one difference compared to the previous setup with contexts: - Previously, each context had its own build folder, and building infer in opt context didn't invalidate any of the build artifacts in default context. Therefore, alternating between `make` and `make opt` had low overhead at the expense of having N copies of all build artifacts (1 for every context). - Now, there's just 1 build folder and switching between profiles does invalidate some artifacts (but not all) and rebuild takes a bit more time. So, if you're alternating like crazy between profiles your experience may get worse (but not necessarily, more on that below). If you want to trigger an opt build occasionally, you shouldn't notice much difference. For those who are concerned about slower build times when alternating between different build profiles, there's a solution: [dune cache](https://dune.readthedocs.io/en/stable/caching.html). You can enable it by creating a file `~/.config/dune/config` with the following contents: ``` (lang dune 2.0) (cache enabled) ``` With cache enabled switching between different build profiles (but also branches and commits) has ~0 overhead. Dune cache works fine on Linux, but unfortunately there are [certain problems with MacOS](https://github.com/ocaml/dune/issues/3233) (hopefully, those will be fixed soon and then there will be no downsides to using profiles compared to contexts for our case). Reviewed By: jvillard Differential Revision: D20247864 fbshipit-source-id: 5f8afa0db
5 years ago
printf "$(TERM_INFO) export BUILD_MODE=dev$(TERM_RESET)\n" >&2; \
printf "$(TERM_INFO) echo 'export BUILD_MODE=dev' >> \"$$shell_config_file\"$(TERM_RESET)\n" >&2; \
[make] fix `make devsetup` Summary: Making the shell stricter revealed a bug in `make devsetup`: `shell_config_file` can be used without being initialised. Also, the error path when testing if `BUILD_MODE` was set to default was wrong and would execute all except the first `echo` command unconditionally. I changed the test so that it tests only if `BUILD_MODE` is set in the environment. Reviewed By: martinoluca Differential Revision: D7615333 fbshipit-source-id: 08c5eb0
7 years ago
fi
[setup] add automatic setup for the developer environment Summary: Useful for hacking on infer, and when eg the default opam switch changes and one has to remember which development packages to install all over again (merlin, etc.). Reviewed By: mbouaziz Differential Revision: D5328701 fbshipit-source-id: 7b7694e
8 years ago
$(QUIET)PATH=$(ORIG_SHELL_PATH); if [ "$$(ocamlc -where 2>/dev/null)" != "$$($(OCAMLC) -where)" ]; then \
echo >&2; \
echo '$(TERM_INFO)*** NOTE: The current shell is not set up for the right opam switch.$(TERM_RESET)' >&2; \
echo '$(TERM_INFO)*** NOTE: Please run:$(TERM_RESET)' >&2; \
echo >&2; \
[setup] opam 2 Summary: Switches from opam 1 to opam 2. Opam2 has some cool new features that simplify some of the scripting. Notable changes: 1. Use the new `opam lock` *plugin* from https://github.com/AltGr/opam-lock/ instead of https://github.com/rgrinberg/opam-lock. This has a simpler interface for our purposes. 2. Change the way `./build-infer.sh` can be called to use an already existing switch: simply pass `--user-opam-switch` to the script and it won't attempt to create/set the current switch. This can be used to build infer in a local switch for instance. 3. Take advantage of automatic pinning where possible, eg to install infer deps without using opam.locked. Reviewed By: ngorogiannis Differential Revision: D13167863 fbshipit-source-id: 1a667c270
6 years ago
echo "$(TERM_INFO) eval \$$($(OPAM) env)$(TERM_RESET)" >&2; \
[setup] add automatic setup for the developer environment Summary: Useful for hacking on infer, and when eg the default opam switch changes and one has to remember which development packages to install all over again (merlin, etc.). Reviewed By: mbouaziz Differential Revision: D5328701 fbshipit-source-id: 7b7694e
8 years ago
fi
[doc] add `doc-publish` target for publishing man pages and odoc Summary: See the results online! http://fbinfer.com/docs/man-pages.html http://fbinfer.com/docs/internal-API.html These html pages are written by hand, but their target is auto-generated. I cheated a bit by generating the docs for the current version of infer and not 0.15.0 but they are hopefully very similar. Depends on D8314572 Reviewed By: jeremydubreil Differential Revision: D8318132 fbshipit-source-id: ffca43c
7 years ago
GHPAGES ?= no
[doc] add `make doc` target for building html API doc Summary: `make doc` will use `jbuilder` (which in turn uses `odoc`) to generate the documentation for infer's modules. This is useful to browse the APIs of infer and gives a more discoverable place to host more general documentation about infer's internals. Besides the actual plumbing necessary to generate the docs, this diff also - Moves the various infer/src/*/README.md to index.mld files that make it to the generated docs - Fixes some doc comments that would anger `ocamldoc` Closes #435 Reviewed By: mbouaziz Differential Revision: D8314572 fbshipit-source-id: 4a5c70e
7 years ago
.PHONY: doc
doc: src_build_common
$(QUIET)$(call silent_on_success,Generating infer documentation,\
$(MAKE_SOURCE) doc)
[doc] add `doc-publish` target for publishing man pages and odoc Summary: See the results online! http://fbinfer.com/docs/man-pages.html http://fbinfer.com/docs/internal-API.html These html pages are written by hand, but their target is auto-generated. I cheated a bit by generating the docs for the current version of infer and not 0.15.0 but they are hopefully very similar. Depends on D8314572 Reviewed By: jeremydubreil Differential Revision: D8318132 fbshipit-source-id: ffca43c
7 years ago
# do not call the browser if we are publishing the docs
[help] implement `--write-website` Summary: Write documentation for all documented issue types and all user-facing checkers in the "next" version of the documentation. Next diff shows the new website. Reviewed By: dulmarod Differential Revision: D21934370 fbshipit-source-id: 53315d2b4
5 years ago
ifneq ($(NO_BROWSE_DOC),yes)
[doc] add `make doc` target for building html API doc Summary: `make doc` will use `jbuilder` (which in turn uses `odoc`) to generate the documentation for infer's modules. This is useful to browse the APIs of infer and gives a more discoverable place to host more general documentation about infer's internals. Besides the actual plumbing necessary to generate the docs, this diff also - Moves the various infer/src/*/README.md to index.mld files that make it to the generated docs - Fixes some doc comments that would anger `ocamldoc` Closes #435 Reviewed By: mbouaziz Differential Revision: D8314572 fbshipit-source-id: 4a5c70e
7 years ago
$(QUIET)$(call silent_on_success,Opening in browser,\
[odoc] fix doc generation, no need for public names Summary: All dune libraries in infer/src/ were declared with their own public names, each one needing its own .opam file. There's no need for that: they can all be part of the `infer` library by calling them `infer.Foo`. One wrinkle: now we need to explicitly point at their .mld files in the generated documentation. Reviewed By: jberdine Differential Revision: D20798914 fbshipit-source-id: 64b64261c
5 years ago
browse $(INFER_DIR)/_build/default/_doc/_html/index.html)
[doc] add `make doc` target for building html API doc Summary: `make doc` will use `jbuilder` (which in turn uses `odoc`) to generate the documentation for infer's modules. This is useful to browse the APIs of infer and gives a more discoverable place to host more general documentation about infer's internals. Besides the actual plumbing necessary to generate the docs, this diff also - Moves the various infer/src/*/README.md to index.mld files that make it to the generated docs - Fixes some doc comments that would anger `ocamldoc` Closes #435 Reviewed By: mbouaziz Differential Revision: D8314572 fbshipit-source-id: 4a5c70e
7 years ago
$(QUIET)echo "Tip: you can generate the doc for all the opam dependencies of infer like this:"
$(QUIET)echo
$(QUIET)echo " odig odoc # takes a while, run it only when the dependencies change"
$(QUIET)echo " odig doc"
[doc] add `doc-publish` target for publishing man pages and odoc Summary: See the results online! http://fbinfer.com/docs/man-pages.html http://fbinfer.com/docs/internal-API.html These html pages are written by hand, but their target is auto-generated. I cheated a bit by generating the docs for the current version of infer and not 0.15.0 but they are hopefully very similar. Depends on D8314572 Reviewed By: jeremydubreil Differential Revision: D8318132 fbshipit-source-id: ffca43c
7 years ago
endif
[doc] add `make doc` target for building html API doc Summary: `make doc` will use `jbuilder` (which in turn uses `odoc`) to generate the documentation for infer's modules. This is useful to browse the APIs of infer and gives a more discoverable place to host more general documentation about infer's internals. Besides the actual plumbing necessary to generate the docs, this diff also - Moves the various infer/src/*/README.md to index.mld files that make it to the generated docs - Fixes some doc comments that would anger `ocamldoc` Closes #435 Reviewed By: mbouaziz Differential Revision: D8314572 fbshipit-source-id: 4a5c70e
7 years ago
[doc] add `doc-publish` target for publishing man pages and odoc Summary: See the results online! http://fbinfer.com/docs/man-pages.html http://fbinfer.com/docs/internal-API.html These html pages are written by hand, but their target is auto-generated. I cheated a bit by generating the docs for the current version of infer and not 0.15.0 but they are hopefully very similar. Depends on D8314572 Reviewed By: jeremydubreil Differential Revision: D8318132 fbshipit-source-id: ffca43c
7 years ago
.PHONY: doc-publish
[help] implement `--write-website` Summary: Write documentation for all documented issue types and all user-facing checkers in the "next" version of the documentation. Next diff shows the new website. Reviewed By: dulmarod Differential Revision: D21934370 fbshipit-source-id: 53315d2b4
5 years ago
doc-publish:
ifeq ($(IS_FACEBOOK_TREE),yes)
$(QUIET)$(call silent_on_success,Cleaning up FB-only files,\
$(MAKE) -C $(SRC_DIR) clean; \
$(MAKE) -C facebook clean)
endif
$(QUIET)$(call silent_on_success,Building infer and manuals,\
$(MAKE) $(INFER_GROFF_MANUALS))
[website] code to publish current docs Summary: Fix `make doc-publish` and make it publish the documentation to website/static/{man,doc}/next/. Reviewed By: ngorogiannis Differential Revision: D21552291 fbshipit-source-id: fb6d07cfc
5 years ago
$(QUIET)$(MKDIR_P) "$(WEBSITE_DIR)"/static/man/next "$(WEBSITE_DIR)"/static/odoc/next
[doc] add `doc-publish` target for publishing man pages and odoc Summary: See the results online! http://fbinfer.com/docs/man-pages.html http://fbinfer.com/docs/internal-API.html These html pages are written by hand, but their target is auto-generated. I cheated a bit by generating the docs for the current version of infer and not 0.15.0 but they are hopefully very similar. Depends on D8314572 Reviewed By: jeremydubreil Differential Revision: D8318132 fbshipit-source-id: ffca43c
7 years ago
$(QUIET)$(call silent_on_success,Copying man pages,\
[website] code to publish current docs Summary: Fix `make doc-publish` and make it publish the documentation to website/static/{man,doc}/next/. Reviewed By: ngorogiannis Differential Revision: D21552291 fbshipit-source-id: fb6d07cfc
5 years ago
$(REMOVE) "$(WEBSITE_DIR)"/static/man/*; \
[man] check in manual pages Summary: This allows infer devs to see the effects their changes have on the infer manuals. Check in the manuals for each subcommand + the output of `--help-full` to get a complete picture. If this is too annoying we can also check in only `--help-full`. Reviewed By: mbouaziz Differential Revision: D9916404 fbshipit-source-id: b981e2c33
6 years ago
for man in $(INFER_GROFF_MANUALS); do \
[website] code to publish current docs Summary: Fix `make doc-publish` and make it publish the documentation to website/static/{man,doc}/next/. Reviewed By: ngorogiannis Differential Revision: D21552291 fbshipit-source-id: fb6d07cfc
5 years ago
groff -Thtml "$$man" > "$(WEBSITE_DIR)"/static/man/next/$$(basename "$$man").html; \
[doc] add `doc-publish` target for publishing man pages and odoc Summary: See the results online! http://fbinfer.com/docs/man-pages.html http://fbinfer.com/docs/internal-API.html These html pages are written by hand, but their target is auto-generated. I cheated a bit by generating the docs for the current version of infer and not 0.15.0 but they are hopefully very similar. Depends on D8314572 Reviewed By: jeremydubreil Differential Revision: D8318132 fbshipit-source-id: ffca43c
7 years ago
done)
[website] code to publish current docs Summary: Fix `make doc-publish` and make it publish the documentation to website/static/{man,doc}/next/. Reviewed By: ngorogiannis Differential Revision: D21552291 fbshipit-source-id: fb6d07cfc
5 years ago
$(QUIET)$(call silent_on_success,Building OCaml modules documentation,\
[help] implement `--write-website` Summary: Write documentation for all documented issue types and all user-facing checkers in the "next" version of the documentation. Next diff shows the new website. Reviewed By: dulmarod Differential Revision: D21934370 fbshipit-source-id: 53315d2b4
5 years ago
$(MAKE) IS_FACEBOOK_TREE=no NO_BROWSE_DOC=yes doc)
[website] code to publish current docs Summary: Fix `make doc-publish` and make it publish the documentation to website/static/{man,doc}/next/. Reviewed By: ngorogiannis Differential Revision: D21552291 fbshipit-source-id: fb6d07cfc
5 years ago
$(QUIET)$(call silent_on_success,Copying OCaml modules documentation,\
rsync -a --delete $(BUILD_DIR)/default/_doc/_html/ "$(WEBSITE_DIR)"/static/odoc/next/)
[help] implement `--write-website` Summary: Write documentation for all documented issue types and all user-facing checkers in the "next" version of the documentation. Next diff shows the new website. Reviewed By: dulmarod Differential Revision: D21934370 fbshipit-source-id: 53315d2b4
5 years ago
$(QUIET)$(call silent_on_success,Building infer,\
$(MAKE) src_build)
$(QUIET)$(call silent_on_success,Calling 'infer help --write-website',\
$(INFER_BIN) help --write-website "$(WEBSITE_DIR)")
[doc] add `make doc` target for building html API doc Summary: `make doc` will use `jbuilder` (which in turn uses `odoc`) to generate the documentation for infer's modules. This is useful to browse the APIs of infer and gives a more discoverable place to host more general documentation about infer's internals. Besides the actual plumbing necessary to generate the docs, this diff also - Moves the various infer/src/*/README.md to index.mld files that make it to the generated docs - Fixes some doc comments that would anger `ocamldoc` Closes #435 Reviewed By: mbouaziz Differential Revision: D8314572 fbshipit-source-id: 4a5c70e
7 years ago
[tests] share javac.make more broadly Summary: - rename java.make -> javac.make, config.make -> java.make, and move to infer/tests/ so it's easier to use from infer/tests/build_systems/ - use these from ant's test Makefile, much code reuse! - factor out common functionality between java and clang A wrinkle: sorting is now done the same way for --issues-tests and --issues-txt, which produces bogus (but still as deterministic) sorting for --issues-txt. This is more of a cosmetic issue, but I hope to fix it in a later diff that gets rid of calls to `sort` in favour of sorting directly from `InferPrint`. Reviewed By: jberdine Differential Revision: D4166841 fbshipit-source-id: ed6f232
8 years ago
# print list of targets
.PHONY: show-targets
show-targets:
[make] print @ commands when passed VERBOSE=1 Summary: It can be useful when debugging infer or the Makefiles themselves to see what `make` is doing. Instead of editing Makefiles to remove `@` now you can `make VERBOSE=1`. This is just `git ls-files | grep -e Makefile -e '.*\.make' | xargs sed -e 's/^\t@/\t$(QUIET)/' -i`, and adding the definition of `QUIET` to Makefile.config. Reviewed By: jeremydubreil Differential Revision: D4779115 fbshipit-source-id: e6e4642
8 years ago
$(QUIET)$(MAKE) -pqrR . | grep --only-matching -e '^[a-zA-Z0-9][^ ]*:' | cut -d ':' -f 1 | sort