Jeremy Dubreil
3fb25e2a74
[infer][java] removing dead code
...
Summary: This code does not seem to be used
Reviewed By: mbouaziz
Differential Revision: D6609425
fbshipit-source-id: f39a16b
7 years ago
Martino Luca
e950103428
Add the --log-events flag to turn on events logging
...
Reviewed By: mbouaziz
Differential Revision: D6611878
fbshipit-source-id: 6137f77
7 years ago
Mehdi Bouaziz
d8bd7b7deb
[inferbo] Only use inferbo models when biabduction is off
...
Reviewed By: sblackshear
Differential Revision: D6611037
fbshipit-source-id: 6d75743
7 years ago
Jeremy Dubreil
93b9f2c488
[infer][java] catch Invalid_argument exception when translating the bytecode to the Sawja JBir representation
...
Reviewed By: sblackshear, mbouaziz, jvillard
Differential Revision: D6602288
fbshipit-source-id: b63f6dc
7 years ago
Sam Blackshear
8732c7d7a1
[quandary] add curl_easy_setop with CURLOPT_POSTFIELDS as sink
...
Reviewed By: the-st0rm
Differential Revision: D6598553
fbshipit-source-id: 5b5a91a
7 years ago
Martino Luca
7d78588f49
Emit log identifier in stderr, when Infer is launched
...
Reviewed By: jvillard
Differential Revision: D6592147
fbshipit-source-id: 63f9b91
7 years ago
Mehdi Bouaziz
3fc41af811
[inferbo] Model for folly::split
...
Summary:
Model for `folly::split` that handles the representation in the cpp model.
Depends on D6544992
Reviewed By: jvillard
Differential Revision: D6545006
fbshipit-source-id: 2b7a139
7 years ago
Dino Distefano
e3e2fb22a1
Change pattern-matching order
...
Reviewed By: jvillard
Differential Revision: D6591630
fbshipit-source-id: 2316d17
7 years ago
Sam Blackshear
82a3b2649e
[quandary] only warn on shell/sql injection from stringy gflag sources
...
Reviewed By: jeremydubreil
Differential Revision: D6573250
fbshipit-source-id: 5680773
7 years ago
Sam Blackshear
afb04cf459
[thread-safety][experimental] switch access path may-alias condition to syntactic equality
...
Reviewed By: peterogithub
Differential Revision: D5858783
fbshipit-source-id: e74a64b
7 years ago
Jeremy Dubreil
71cf1760c5
[infer][nullable checker] find the nullable violation involving annotated protocol methods
...
Summary:
Before this diff, the nullable checker would not be able to find annotations involving methods annotated in the protocols
update-submodule: facebook-clang-plugins
Reviewed By: sblackshear
Differential Revision: D6534893
fbshipit-source-id: 39bd3dd
7 years ago
Martino Luca
67142e7478
Log events in machine-readable format, and dump them via `infer events` command
...
Reviewed By: mbouaziz, jvillard
Differential Revision: D6259580
fbshipit-source-id: 9289d2f
7 years ago
Mehdi Bouaziz
96face188a
[dispatcher] Uncouple function argument matching and capturing
...
Summary:
Allows:
- matching function arguments with or without capturing,
- capturing part of an argument, e.g. expression only,
- optional arguments, wrapped into an OCaml option if captured.
Reviewed By: jvillard
Differential Revision: D6544992
fbshipit-source-id: a64ba45
7 years ago
Jeremy Dubreil
32deab86bd
[infer][nullable checker] avoid reporting the nullable violations that are already reported by the biabduction analysis
...
Summary: This is to allow the bi-abduction analysis and the nullable checker for Clang languages to run together without stepping on each other toes.
Reviewed By: sblackshear
Differential Revision: D6567934
fbshipit-source-id: a318c33
7 years ago
Sam Blackshear
d6ed9e3bbe
[liveness] remove special-casing for destructor reads
...
Reviewed By: jeremydubreil
Differential Revision: D6569310
fbshipit-source-id: f072e05
7 years ago
Sam Blackshear
f37344358b
[experimental] interprocedural should_update analysis
...
Reviewed By: jeremydubreil
Differential Revision: D6411833
fbshipit-source-id: 4609a6b
7 years ago
Jules Villard
303b79b6ae
[sqlite] create `SQLite` serialization/deserialization modules where needed
...
Summary: This factors out some duplicated code for {,de}serializing source files.
Reviewed By: mbouaziz
Differential Revision: D6324234
fbshipit-source-id: 1741657
7 years ago
Jules Villard
a91e7dda50
[cfg] move cfgs to sqlite
...
Summary:
Instead of storing the cfgs of source files inside their own individual files,
put them in results.db, in their own table. (that table may change in the
future to map source files to more than just their cfgs, eg their tenv as well)
Reviewed By: jberdine
Differential Revision: D6297201
fbshipit-source-id: 7fa891d
7 years ago
Jules Villard
26f27fe147
[make] add toplevel target to build and start the toplevel
...
Summary: Convenient.
Reviewed By: mbouaziz
Differential Revision: D6545072
fbshipit-source-id: a05d384
7 years ago
Dulma Churchill
4db780d364
[retain cycles] Enable retain cycles, quality and message are better now
...
Reviewed By: ddino
Differential Revision: D6567274
fbshipit-source-id: 49589e7
7 years ago
Martino Luca
cd49acc1cf
Refactor directory traversal into its own utility function
...
Reviewed By: mbouaziz
Differential Revision: D6533384
fbshipit-source-id: 4d05b16
7 years ago
Jeremy Dubreil
f283416fa1
[infer] no longer print the list of Eradicate warnings to standard output
...
Reviewed By: sblackshear
Differential Revision: D6563402
fbshipit-source-id: e8ddc86
7 years ago
Jeremy Dubreil
1f6d73269e
[infer] simplify the API to report errors
...
Summary: There was a back and forth conversion between `string` and `IssueType.t` which was not necessary.
Reviewed By: sblackshear
Differential Revision: D6562747
fbshipit-source-id: 70b57a2
7 years ago
Jeremy Dubreil
c62dd2a0c2
[infer][nullable checker] add models for mutations of mutable dictionaries and mutable arrays
...
Reviewed By: sblackshear
Differential Revision: D6559987
fbshipit-source-id: e3175dd
7 years ago
Sam Blackshear
b23e967f1b
[liveness] print type of unused var
...
Reviewed By: jeremydubreil
Differential Revision: D6539887
fbshipit-source-id: 9e819b0
7 years ago
Sam Blackshear
41129087e4
[quandary] only Intents created from Uris should be sources
...
Reviewed By: jeremydubreil
Differential Revision: D6560709
fbshipit-source-id: bc2b5d3
7 years ago
Sam Blackshear
32675a7b02
[quandary] improve curl_easy_setopt sink
...
Reviewed By: jeremydubreil
Differential Revision: D6557133
fbshipit-source-id: 4df7b49
7 years ago
Sam Blackshear
156ea2f759
[racerd] use a record instead of ginormous tuple in reporting code
...
Reviewed By: da319
Differential Revision: D6538782
fbshipit-source-id: 2035c2e
7 years ago
Dulma Churchill
5b5b72f983
[retain cycles] Improve the message by adding info about when each of the objects involved was last updated.
...
Reviewed By: mbouaziz
Differential Revision: D6544978
fbshipit-source-id: 2bb65e2
7 years ago
Jules Villard
5ce024bf6e
[clang] do not error on bogus arguments to `fsanitize`
...
Summary: Simpler approach than having to look into argfiles
Reviewed By: mbouaziz
Differential Revision: D6546388
fbshipit-source-id: 3d08001
7 years ago
Dulma Churchill
d7dc9b38f7
[retain cycles] Refactoring of computing cycles using dedicated data structure
...
Reviewed By: mbouaziz
Differential Revision: D6534576
fbshipit-source-id: 119b618
7 years ago
Mehdi Bouaziz
cf11590800
[clang] Ignore -fsanitize=builtin
...
Reviewed By: jvillard
Differential Revision: D6543987
fbshipit-source-id: 8eda1d2
7 years ago
Jeremy Dubreil
83118865aa
[infer] add arrayByAddingObject: to the list of methods asserting the parameters
...
Reviewed By: mbouaziz
Differential Revision: D6529090
fbshipit-source-id: fd282af
7 years ago
Sam Blackshear
d3f4043bc0
[quandary] curl function for setting URL as sink
...
Reviewed By: the-st0rm
Differential Revision: D6485858
fbshipit-source-id: fd38654
7 years ago
Jules Villard
1f3cae9fa4
[make] some missing dependencies
...
Summary: minor fixes
Reviewed By: mbouaziz
Differential Revision: D6405261
fbshipit-source-id: 4204f7b
7 years ago
Daiva Naudziuniene
d8a004f0cc
[LockConsistency] Adding conditional ownership to the rest of the formal parameters of constructors.
...
Reviewed By: sblackshear
Differential Revision: D6519671
fbshipit-source-id: 7508fe0
7 years ago
Josh Berdine
22ec29fabc
[racerd] Report only once per unique pair of final trace locations
...
Summary:
This diff adds a layer of report deduplication logic in addition to
the existing scheme.
Suppose issue 1 with trace1a and trace1b, and issue 2 with trace2a and
trace2b. If trace1a ends at the same location as trace2a (resp.,
trace2b) and trace1b ends at the same location as trace2b (resp.,
trace2a), then consider issues 1 and 2 to be duplicates.
This chooses to report the issue with the smaller sum of trace
lengths, breaking ties using the issue hashes, and eventually the
entire issue. Therefore there is a potential for flakiness with
respect the the choice of which report to make within a
hash-equivalence class.
Reviewed By: sblackshear
Differential Revision: D6519607
fbshipit-source-id: 63210ab
7 years ago
Sam Blackshear
7e8739de0a
[quandary] more fine-grained issue types for Java
...
Reviewed By: AmarBhosale
Differential Revision: D6513437
fbshipit-source-id: b9acbcf
7 years ago
Sam Blackshear
d81faea3b3
[de-duplication] fix bug causing under-aggregation
...
Reviewed By: jeremydubreil
Differential Revision: D6520644
fbshipit-source-id: f7bb550
7 years ago
Sam Blackshear
647e1cd62d
[dead stores] config file for custom scope guard types
...
Reviewed By: da319
Differential Revision: D6517706
fbshipit-source-id: 3b6f805
7 years ago
Sam Blackshear
432fa4913c
[quandary] report all Intents constructed from URIs
...
Reviewed By: AmarBhosale
Differential Revision: D5263602
fbshipit-source-id: 16f4967
7 years ago
Sam Blackshear
6abbe66ee6
[quandary] file creation as sink
...
Reviewed By: jeremydubreil, mbouaziz
Differential Revision: D6486526
fbshipit-source-id: cad09f1
7 years ago
Sam Blackshear
19824aa27b
[quandary] don't taint this var of endpoints
...
Reviewed By: mbouaziz
Differential Revision: D6509322
fbshipit-source-id: e24357e
7 years ago
Sam Blackshear
a32903bcea
[racerd] print just one conflict in error message to avoid formatting issues
...
Reviewed By: jberdine
Differential Revision: D6505351
fbshipit-source-id: 8eca496
7 years ago
Josh Berdine
972b9eb488
[lock-consistency] Suppress folly::fbstring_core
...
Reviewed By: da319
Differential Revision: D6497534
fbshipit-source-id: 947af7c
7 years ago
Josh Berdine
5e3cd22a1f
[lock-consistency] Suppress folly::futures
...
Reviewed By: da319
Differential Revision: D6496997
fbshipit-source-id: a19f766
7 years ago
Peter O'Hearn
700adc2d44
[racerd] deep ownership
...
Reviewed By: sblackshear
Differential Revision: D6424928
fbshipit-source-id: d3a1735
7 years ago
Sam Blackshear
735b0b2ef7
[quandary] include source/sink caller in error message
...
Reviewed By: jeremydubreil
Differential Revision: D6489705
fbshipit-source-id: e6dbd13
7 years ago
Jeremy Dubreil
75de2006dd
[infer] make sure adding or removing parameters does not affect the bug hash on Objective C methods
...
Summary: As Dulma pointed out, adding or removing paramters in a method in Objective C is changing the name of the method. Such changes should not make pre-exisiting issues reported as introduced. This diff is to prevent this by only keeping in the bug hash the part of the name that is before the first colon.
Reviewed By: dulmarod
Differential Revision: D6491215
fbshipit-source-id: 3c00fae
7 years ago
Sam Blackshear
6799e7a7fb
[dead stores] whitelist more RAII guard types
...
Reviewed By: jeremydubreil
Differential Revision: D6490095
fbshipit-source-id: ae11859
7 years ago